Re: optimization for pop movemail

2005-07-05 Thread Richard M. Stallman
I'll revise the patch and check it in, should be sometime this week... Thank you. ___ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: optimization for pop movemail

2005-07-05 Thread Ken Raeburn
+ if (line == pop_error && strlen (line) < sizeof (pop_error) - 5) That code is a horrible kludge. Yeah, true... even worse than the existing kludge of using the error-return buffer, sometimes, to hold the message to be sent out. It would be better to copy the string to a temporary buffe

Re: optimization for pop movemail

2005-07-04 Thread Richard M. Stallman
Thanks for noticing this issue. + if (line == pop_error && strlen (line) < sizeof (pop_error) - 5) That code is a horrible kludge. It would be better to copy the string to a temporary buffer and add the \r\n there. You could allocate it with alloca. That is clean, and you could do it uncondit