Re: URL library problem

2005-10-03 Thread Paul Pogonyshev
Stefan Monnier wrote: > > Would the patch below do the trick? > > No, it clearly wouldn't. Try this one instead. > > > Stefan > > > --- url-http.el 25 aoû 2005 10:56:43 -0400 1.20 > +++ url-http.el 03 oct 2005 11:26:27 -0400 > @@ -198,7 +198,12 @@ > ;; allows us to el

Re: URL library problem

2005-10-03 Thread Stefan Monnier
> Would the patch below do the trick? No, it clearly wouldn't. Try this one instead. Stefan --- url-http.el 25 aoû 2005 10:56:43 -0400 1.20 +++ url-http.el 03 oct 2005 11:26:27 -0400 @@ -198,7 +198,12 @@ ;; allows us to elide null lines directly, at the cost of making

Re: URL library problem

2005-10-03 Thread Stefan Monnier
> Note how explicit UTF-8 encoding helps nothing, because `url-request-data' > is later concatenated with some strings turning multibyte again: The problem here is not so much the use of string concatenation but the fact that string concatenation uses string-make-multibyte rather than string-to-mu

Re: URL library problem

2005-10-02 Thread Richard M. Stallman
Of course, uncoditional encoding in UTF-8 is not a right thing to do. Actually, encoding of the complete request is not right. A proper patch would simply avoid concatenating `url-request-data' with anything and send it to the connection verbatim, assuming that the user of the

Re: URL library problem

2005-10-02 Thread Mark A. Hershberger
Paul Pogonyshev wrote: I believe I have found a serious problem in the URL library. You aren't the first. I raised this issue back in June (http://thread.gmane.org/gmane.emacs.devel/38531) and offered a patch. However, because I didn't (and, to some extent, still don't) understand all the

URL library problem

2005-10-02 Thread Paul Pogonyshev
Hello, I believe I have found a serious problem in the URL library. If you look at the very end of function `url-http', you can see that the result of `url-http-create-request' is sent to the connection as-is. But encoding of the connection is binary! It means, that multibyte strings are sent in