branch: externals/modus-operandi-theme commit 9954f4747fc88a3f8f427428a5032167aab1dd0a Author: Protesilaos Stavrou <i...@protesilaos.com> Commit: Protesilaos Stavrou <i...@protesilaos.com>
Major Review of fly{check,make,spell} for GUI/TUI For GUI Emacs, all affected faces will now just use a colour-coded wavy underline. We no longer change the foreground value of the offending text. Whereas before the text would also get a colour, which was too intrusive in most circumstances. If support for wavy underlines is not available, we assume the presence of a TUI, which generally is also more limited in its ability to reproduce colours accurately. So for those cases we apply a straight underline combined with a colour-coded foreground for the affected text. This makes it more intense compared to the GUI equivalent, but is the necessary course of action to overcome the constraints imposed by the underlying terminal. --- modus-operandi-theme.el | 28 ++++++++++++++-------------- modus-vivendi-theme.el | 28 ++++++++++++++-------------- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/modus-operandi-theme.el b/modus-operandi-theme.el index 4d8f77e..6bdd3e5 100644 --- a/modus-operandi-theme.el +++ b/modus-operandi-theme.el @@ -1590,8 +1590,8 @@ Also bind `class' to ((class color) (min-colors 89))." ;;;; flycheck `(flycheck-error ((,(append '((supports :underline (:style wave))) class) - (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style wave))) - (,class (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style line))))) + (:underline (:color ,fg-lang-error :style wave))) + (,class (:foreground ,fg-lang-error :underline t)))) `(flycheck-error-list-checker-name ((,class (:foreground ,magenta-active)))) `(flycheck-error-list-column-number ((,class (:foreground ,fg-special-cold)))) `(flycheck-error-list-error ((,class (:foreground ,red :weight ,modus-theme-bold)))) @@ -1607,13 +1607,13 @@ Also bind `class' to ((class color) (min-colors 89))." `(flycheck-fringe-warning ((,class (:inherit modus-theme-fringe-yellow)))) `(flycheck-info ((,(append '((supports :underline (:style wave))) class) - (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style wave))) - (,class (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style line))))) + (:underline (:color ,fg-lang-note :style wave))) + (,class (:foreground ,fg-lang-note :underline t)))) `(flycheck-verify-select-checker ((,class (:box (:line-width 1 :color nil :style released-button))))) `(flycheck-warning ((,(append '((supports :underline (:style wave))) class) - (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style wave))) - (,class (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style line))))) + (:underline (:color ,fg-lang-warning :style wave))) + (,class (:foreground ,fg-lang-warning :underline t)))) ;;;; flycheck-indicator `(flycheck-indicator-disabled ((,class (:foreground ,fg-inactive :slant ,modus-theme-slant)))) `(flycheck-indicator-error ((,class (:foreground ,red-active :weight ,modus-theme-bold)))) @@ -1631,24 +1631,24 @@ Also bind `class' to ((class color) (min-colors 89))." ;;;; flymake `(flymake-error ((,(append '((supports :underline (:style wave))) class) - (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style wave))) - (,class (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style line))))) + (:underline (:color ,fg-lang-error :style wave))) + (,class (:foreground ,fg-lang-error :underline t)))) `(flymake-note ((,(append '((supports :underline (:style wave))) class) - (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style wave))) - (,class (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style line))))) + (:underline (:color ,fg-lang-note :style wave))) + (,class (:foreground ,fg-lang-note :underline t)))) `(flymake-warning ((,(append '((supports :underline (:style wave))) class) - (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style wave))) - (,class (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style line))))) + (:underline (:color ,fg-lang-warning :style wave))) + (,class (:foreground ,fg-lang-warning :underline t)))) ;;;; flyspell `(flyspell-duplicate ((,(append '((supports :underline (:style wave))) class) - (:foreground ,fg-lang-warning :underline (:style wave))) + (:underline (:color ,fg-lang-warning :style wave))) (,class (:foreground ,fg-lang-warning :underline t)))) `(flyspell-incorrect ((,(append '((supports :underline (:style wave))) class) - (:foreground ,fg-lang-error :underline (:style wave))) + (:underline (:color ,fg-lang-error :style wave))) (,class (:foreground ,fg-lang-error :underline t)))) ;;;; flyspell-correct `(flyspell-correct-highlight-face ((,class (:inherit modus-theme-refine-green)))) diff --git a/modus-vivendi-theme.el b/modus-vivendi-theme.el index c3f59a2..58a59a2 100644 --- a/modus-vivendi-theme.el +++ b/modus-vivendi-theme.el @@ -1590,8 +1590,8 @@ Also bind `class' to ((class color) (min-colors 89))." ;;;; flycheck `(flycheck-error ((,(append '((supports :underline (:style wave))) class) - (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style wave))) - (,class (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style line))))) + (:underline (:color ,fg-lang-error :style wave))) + (,class (:foreground ,fg-lang-error :underline t)))) `(flycheck-error-list-checker-name ((,class (:foreground ,magenta-active)))) `(flycheck-error-list-column-number ((,class (:foreground ,fg-special-cold)))) `(flycheck-error-list-error ((,class (:foreground ,red :weight ,modus-theme-bold)))) @@ -1607,13 +1607,13 @@ Also bind `class' to ((class color) (min-colors 89))." `(flycheck-fringe-warning ((,class (:inherit modus-theme-fringe-yellow)))) `(flycheck-info ((,(append '((supports :underline (:style wave))) class) - (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style wave))) - (,class (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style line))))) + (:underline (:color ,fg-lang-note :style wave))) + (,class (:foreground ,fg-lang-note :underline t)))) `(flycheck-verify-select-checker ((,class (:box (:line-width 1 :color nil :style released-button))))) `(flycheck-warning ((,(append '((supports :underline (:style wave))) class) - (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style wave))) - (,class (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style line))))) + (:underline (:color ,fg-lang-warning :style wave))) + (,class (:foreground ,fg-lang-warning :underline t)))) ;;;; flycheck-indicator `(flycheck-indicator-disabled ((,class (:foreground ,fg-inactive :slant ,modus-theme-slant)))) `(flycheck-indicator-error ((,class (:foreground ,red-active :weight ,modus-theme-bold)))) @@ -1631,24 +1631,24 @@ Also bind `class' to ((class color) (min-colors 89))." ;;;; flymake `(flymake-error ((,(append '((supports :underline (:style wave))) class) - (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style wave))) - (,class (:foreground ,red-nuanced :underline (:color ,fg-lang-error :style line))))) + (:underline (:color ,fg-lang-error :style wave))) + (,class (:foreground ,fg-lang-error :underline t)))) `(flymake-note ((,(append '((supports :underline (:style wave))) class) - (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style wave))) - (,class (:foreground ,blue-nuanced :underline (:color ,fg-lang-note :style line))))) + (:underline (:color ,fg-lang-note :style wave))) + (,class (:foreground ,fg-lang-note :underline t)))) `(flymake-warning ((,(append '((supports :underline (:style wave))) class) - (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style wave))) - (,class (:foreground ,yellow-nuanced :underline (:color ,fg-lang-warning :style line))))) + (:underline (:color ,fg-lang-warning :style wave))) + (,class (:foreground ,fg-lang-warning :underline t)))) ;;;; flyspell `(flyspell-duplicate ((,(append '((supports :underline (:style wave))) class) - (:foreground ,fg-lang-warning :underline (:style wave))) + (:underline (:color ,fg-lang-warning :style wave))) (,class (:foreground ,fg-lang-warning :underline t)))) `(flyspell-incorrect ((,(append '((supports :underline (:style wave))) class) - (:foreground ,fg-lang-error :underline (:style wave))) + (:underline (:color ,fg-lang-error :style wave))) (,class (:foreground ,fg-lang-error :underline t)))) ;;;; flyspell-correct `(flyspell-correct-highlight-face ((,class (:inherit modus-theme-refine-green))))