branch: master
commit de40f70fbbd6dfe03f43eae3eb4c928a05215c54
Author: Stefan Monnier
Commit: Stefan Monnier
* debbugs: Use cl-lib. Use lexical-binding when available
* debbugs-gnu.el: Only require subr-x at compile time. Use cl-lib.
(debbugs-gnu-print-entry): Remove unused var `title-length'.
(debbugs-gnu-sort-title): Mark `s2' as unused.
* debbugs-org.el (debbugs-gnu): Use cl-lib.
* debbugs.el: Add `cl-lib' as dependency. Use cl-lib.
(debbugs-soap-invoke-async): Mark `args' as unused.
---
packages/debbugs/debbugs-gnu.el | 11 ++-
packages/debbugs/debbugs-org.el | 10 +-
packages/debbugs/debbugs.el | 39 +--
3 files changed, 32 insertions(+), 28 deletions(-)
diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
index 10a31cb..a195814 100644
--- a/packages/debbugs/debbugs-gnu.el
+++ b/packages/debbugs/debbugs-gnu.el
@@ -1,4 +1,4 @@
-;;; debbugs-gnu.el --- interface for the GNU bug tracker
+;;; debbugs-gnu.el --- interface for the GNU bug tracker -*-
lexical-binding:t -*-
;; Copyright (C) 2011-2016 Free Software Foundation, Inc.
@@ -141,8 +141,8 @@
(require 'debbugs)
(require 'tabulated-list)
(require 'add-log)
-(require 'subr-x)
-(eval-when-compile (require 'cl))
+(eval-when-compile (require 'subr-x))
+(eval-when-compile (require 'cl-lib))
(autoload 'article-decode-charset "gnus-art")
(autoload 'diff-goto-source "diff-mode")
@@ -717,7 +717,8 @@ Used instead of `tabulated-list-print-entry'."
(submitter(aref cols 2))
(submitter-length (nth 1 (aref tabulated-list-format 2)))
(title(aref cols 3))
- (title-length (nth 1 (aref tabulated-list-format 3
+ ;; (title-length (nth 1 (aref tabulated-list-format 3)))
+)
(when (and
;; We may have a narrowing in effect.
(or (not debbugs-gnu-limit)
@@ -951,7 +952,7 @@ The following commands are available:
t)
(t nil
-(defun debbugs-gnu-sort-title (s1 s2)
+(defun debbugs-gnu-sort-title (s1 _s2)
(let ((owner (if (cdr (assq 'owner (car s1)))
(car (mail-header-parse-address
(decode-coding-string (cdr (assq 'owner (car s1)))
diff --git a/packages/debbugs/debbugs-org.el b/packages/debbugs/debbugs-org.el
index a95672d..ecd522d 100644
--- a/packages/debbugs/debbugs-org.el
+++ b/packages/debbugs/debbugs-org.el
@@ -1,4 +1,4 @@
-;;; debbugs-org.el --- Org-mode interface for the GNU bug tracker
+;;; debbugs-org.el --- Org-mode interface for the GNU bug tracker -*-
lexical-binding:t -*-
;; Copyright (C) 2013-2016 Free Software Foundation, Inc.
@@ -100,7 +100,7 @@
(require 'debbugs-gnu)
(require 'org)
-(eval-when-compile (require 'cl))
+(eval-when-compile (require 'cl-lib))
;; Buffer-local variables.
(defvar debbugs-gnu-local-query)
@@ -109,7 +109,7 @@
(defconst debbugs-org-severity-priority
(let ((priority ?A))
(mapcar
- (lambda (x) (prog1 (cons x (char-to-string priority)) (incf priority)))
+ (lambda (x) (prog1 (cons x (char-to-string priority)) (cl-incf priority)))
debbugs-gnu-all-severities))
"Mapping of debbugs severities to TODO priorities.")
@@ -288,10 +288,10 @@ returned."
;; Handle tags.
(when (string-match "^\\([0-9.]+\\); \\(.+\\)$" subject)
- (let ((x (match-string 1 subject))) (pushnew x tags :test #'equal))
+ (let ((x (match-string 1 subject))) (cl-pushnew x tags :test #'equal))
(setq subject (match-string 2 subject)))
(when archived
- (pushnew "ARCHIVE" tags :test #'equal))
+ (cl-pushnew "ARCHIVE" tags :test #'equal))
(setq tags
(mapcar
;; Replace all invalid TAG characters by "_".
diff --git a/packages/debbugs/debbugs.el b/packages/debbugs/debbugs.el
index cedf93f..f3dc7c6 100644
--- a/packages/debbugs/debbugs.el
+++ b/packages/debbugs/debbugs.el
@@ -1,4 +1,4 @@
-;;; debbugs.el --- SOAP library to access debbugs servers
+;;; debbugs.el --- SOAP library to access debbugs servers -*-
lexical-binding:t -*-
;; Copyright (C) 2011-2016 Free Software Foundation, Inc.
@@ -6,7 +6,7 @@
;; Keywords: comm, hypermedia
;; Package: debbugs
;; Version: 0.9.3
-;; Package-Requires: ((soap-client "3.1.1"))
+;; Package-Requires: ((soap-client "3.1.1") (cl-lib "0.5"))
;; This file is not part of GNU Emacs.
@@ -35,7 +35,7 @@
;(setq soap-debug t message-log-max t)
(require 'soap-client)
-(eval-when-compile (require 'cl))
+(eval-when-compile (require 'cl-lib))
(defgroup debbugs nil
"Debbugs library"
@@ -120,8 +120,8 @@ This corresponds to the Debbugs server to be accessed,
either
(defun debbugs-soap-invoke-async (operation-name parameters)
"Invoke the SOAP connection asynchronously."
(apply
- 'soap-invoke-async
- (lambda (response args)
+