How to improve my extension source code don't generate so many timers?

2020-07-17 Thread numbch...@gmail.com
I write an extension org-link-beautify ( https://github.com/stardiviner/org-link-beautify). It use text-property to display all-the-icons icon for links. When I use `list-timers`, I found many timers like this: #+begin_example 1179.80 -#f(compiled-function () # [# ("-1003358868.jpg" :

c-y inserts after entry

2020-07-17 Thread Samuel Wales
in recent maint in emacs 25. * x asd fnjkasn dkfjan ksdjfn kajsdfn ^ajsdf kasdn kfjasnd jkfan ksdfn * kill this whole header line and insert before caret what i expect is that it is inserted above caret what occurs is it gets inserted below * z this is surprising because i expected pl

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Kyle Meyer
Basil L. Contovounesios writes: >> @@ -161,11 +161,17 @@ (defun org-eldoc-documentation-function () >> (defun org-eldoc-load () >>"Set up org-eldoc documentation function." >>(interactive) >> - (if (boundp 'eldoc-documentation-functions) >> - (add-hook 'eldoc-documentation-functions

Re: Why is Babel-C trimming its output?

2020-07-17 Thread Michaƫl Cadilhac
Thanks for the investigation Ian. So, since the tests run just fine without it, and it offers an inconsistent and at times detrimental feature, can we consider removing it, and/or adding some options for that? I'd be fine having to flag my src-block with a ":verbatim t" option to make sure that t

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Eric Abrahamsen
"Basil L. Contovounesios" writes: > Kyle Meyer writes: > >> All right, thanks. Here's that in patch form. I briefly tested with >> Emacs 26, 27, and 28, and things seemed to work fine (though I'm not an >> org-eldoc user). > > I'm not either, but it seems to get pulled in automatically when >

Re: Why is Babel-C trimming its output?

2020-07-17 Thread ian martins
Fortunately the author wrote tests, so we can tie the behavior of the code to use cases. Unfortunately all the tests pass with the call to org-trim removed. Also the call is there from the first commit of the file in git, so there's no commit message to explain. My guess is that it was added to cl

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Joseph Mingrone
On Fri, 2020-07-17 at 01:41, Kyle Meyer wrote: > All right, thanks. Here's that in patch form. I briefly tested with > Emacs 26, 27, and 28, and things seemed to work fine (though I'm not an > org-eldoc user). > I'll plan to apply it in a day or two unless there are objections. So far so good

Re: [PATCH] org-eldoc: Fix compatibility with Emacs 28

2020-07-17 Thread Basil L. Contovounesios
Kyle Meyer writes: > All right, thanks. Here's that in patch form. I briefly tested with > Emacs 26, 27, and 28, and things seemed to work fine (though I'm not an > org-eldoc user). I'm not either, but it seems to get pulled in automatically when org-plus-contrib is installed - that's how I no