Re: org-cycle-internal-local unfold a plain list in parent

2021-05-01 Thread Bastien
Hi Yasushi, Yasushi SHOJI writes: > I see a plain list unfolded when I cycle a sub headline. Fixed in maint with commit 5021bada9, thanks again for reporting this. -- Bastien

Re: Bug: Babel+R handles spaces wrongly in tables [9.3.6 (release_9.3.6 @ /home/cassou/.emacs.d/lib/org/lisp/)]

2021-05-01 Thread Bastien
Hi Damien and Jeremie, Jeremie Juste writes: > The following patch will at least harmonize the results towards the > data.frame. I see the patch has been applied - thanks! I'm marking this bug as resolved right now, feel free to reopen it if I'm wrong. Thanks, -- Bastien

Re: Bug: org-table-wrap-region incorrectly places the wrapped region [9.4 (9.4-elpaplus @ /home/marko/.emacs.d/elpa/org-plus-contrib-20200914/)]

2021-05-01 Thread Bastien
Hi Marko, Marko Schuetz-Schmuck writes: > Marking the region from the 'I' of "Includes" to the space just left of > the right bottom column border and calling org-table-wrap-region > > | Includes all aspects of| > | information about | > | proposed project. | > > wraps

Re: Bug: org-insert-heading-respect-content before first heading [9.4 (9.4-19-gb1de0c-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201019/)]

2021-05-01 Thread Gustavo Barros
Hi Bastien, On Sat, 01 May 2021 at 13:02, Bastien wrote: Hi Gustavo, Gustavo Barros writes: I just found a misbehaving of `org-insert-heading-respect-content': when it's called before the first heading in the buffer, it breaks the structure of that fist heading by inserting a new

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Juan Manuel Macías
Hi all, Thanks for your comments, Bastien and Nicolas. I think macros can work out of the box as a perfect 'backend' for those LaTeX commands that include at least one argument with textual content. In my case they are very useful to 'extend' the markup language. Apart from the LaTeX example

Re: [Feature Request] More flexibility in org-speed-commands customization

2021-05-01 Thread Gustavo Barros
Hi Bastien, On Sat, 01 May 2021 at 13:24, Bastien wrote: Hi Gustavo, Gustavo Barros writes: I don't know if there is a strong reason to hard-code the set of keys in `org-speed-commands-default'. But, if there isn't, could you consider (somehow) exposing the whole set of

Re: Free up C-c SPC/org-table-blank-field?

2021-05-01 Thread Eric Abrahamsen
On 04/28/21 05:50 AM, Bastien wrote: > Eric Abrahamsen writes: > >> That took a while, for such a simple patch! Hope this is acceptable. > > ... and it took a while to install it, but finally done with commit > 7a1c8cadf. > > Thanks! Awesome, thank you!

Re: Bug: Org line commands and visual-line mode bindings [9.3.7 (9.3.7-15-gc9abb4-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200727/)]

2021-05-01 Thread Gustavo Barros
Hi Bastien, On Sat, 01 May 2021 at 17:28, Bastien wrote: Hi Gustavo, Gustavo Barros writes: The Org line commands -- `org-beginning-of-line', `org-end-of-line', and `org-kill-line' -- all take due care for the presence of `visual-line-mode' to do the right thing if it is turned on.

Re: Bug: org-toggle-link-display and org-hide-emphasis-markers [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)]

2021-05-01 Thread Gustavo Barros
Hi Bastien, On Sat, 01 May 2021 at 13:42, Bastien wrote: Hi Gustavo, Gustavo Barros writes: when using `org-hide-emphasis-markers', making links visible with `org-toggle-link-display' also unhides the emphasis markers. I believe this to be unexpected behavior (it certainly is to me),

Re: [PATCH] ob-tangle.el: Speed up tangling

2021-05-01 Thread Bastien
Hi Sébastien, Sébastien Miquel writes: > Indeed, I hadn't thought to run the tests, sorry. I've fixed my code > and modified the `block-order` test in order for it to pass. Applied with commit a2cb9b853, thank you very much for the updated patch. > The patch does modify the order of the

Re: Bug: SETUPFILE and visual-line-mode [9.3 (release_9.3 @ /usr/local/share/emacs/28.0.50/lisp/org/)]

2021-05-01 Thread Bastien
Hi Caio, Bastien writes: > thanks for reporting this -- it seems to be a variant of what Gustavo > has been reporting in this thread: > > https://orgmode.org/list/87a6zkv3m2@gmail.com/ > > ... for which I don't have a solution yet. I'm confirming this bug > for https://updates.orgmode.org.

Re: Bug: Org line commands and visual-line mode bindings [9.3.7 (9.3.7-15-gc9abb4-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200727/)]

2021-05-01 Thread Bastien
Hi Gustavo, Gustavo Barros writes: > The Org line commands -- `org-beginning-of-line', `org-end-of-line', and > `org-kill-line' -- all take due care for the presence of > `visual-line-mode' to do the right thing if it is turned on. However, > when `visual-line-mode' is indeed on, the

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Bastien
Kyle Meyer writes: > Kyle Meyer writes: > >> Ah, sorry for not writing that more clearly. By the above, I wasn't >> saying that the ones I commented on were the _only_ ones I see with >> Emacs 24.5 on maint. > > I've dealt with a few more. Thank you both very much! -- Bastien

Re: A small idea to simplify (further) time input in the date/time prompt

2021-05-01 Thread Gustavo Barros
Hi Bastien, On Sat, 01 May 2021 at 12:40, Bastien wrote: Hi Gustavo, sorry for the slow reply. I applied this patch in master with commit e8562a332. Thanks! Thank you very much! Looking forward to enjoy this one. Best, Gustavo.

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Kyle Meyer
Kyle Meyer writes: > Ah, sorry for not writing that more clearly. By the above, I wasn't > saying that the ones I commented on were the _only_ ones I see with > Emacs 24.5 on maint. I've dealt with a few more. * ob-C.el:477:1:Error: Unknown upattern `(quote integerp)' Introduced by

Re: [PATCH] ob-tangle.el: Speed up tangling

2021-05-01 Thread Sébastien Miquel
Hi Bastien, Bastien writes: The compiler is complaining with In toplevel form: ob-tangle.el:196:1: Warning: Variable ‘modes’ left uninitialized Also, it breaks these two tests for me: 2 unexpected results: FAILED ob-tangle/block-order FAILED

Re: [PATCH] org-agenda.el: Add a M-, binding for org-priority-show

2021-05-01 Thread Adam Spiers
On Sat, 1 May 2021 at 11:45, Bastien wrote: > Kyle Meyer writes: > > With a C-u, org-agenda-priority calls org-priority-show. So perhaps > > instead of adding a new binding, the documentation should be improved. > > I pushed a small enhancement for org-agenda-priority's docstring > with commit

Re: Transforming table and then exporting as CSV

2021-05-01 Thread Kyle Meyer
Pankaj Jangid writes: [...] > Same org file has multiple tables, so I am asking for “Table Name”. I > want to do two improvements: > > 1. When asking for table name, I want to offer all the table names in >the file as completion options. You could collect names with something like (require

Re: [PATCH] LaTeX export: arbitrary float environments

2021-05-01 Thread Timothy
Thomas S. Dye writes: > Aloha Timothy, :waves: > Sorry for the clumsy patch, which I guess would also benefit from an addition > to > the manual, as well? No problem, we all start somewhere :) (and I know I'm still making mistakes) An update to the manual to describe the changed behaviour

Re: [PATCH] avoid loading major modes when exporting to file

2021-05-01 Thread Timothy
Bastien writes: > This even be "auto-mode-alist" instead of "(auto-mode-alist nil)". Ah, it can indeed. > I'm still unsure the patch is correct: what if people *need* major > mode initialization before any contents is exported to a file? I haven't responded to this concern, because I

Re: Bug: org-plot gives Invalid function error

2021-05-01 Thread Bastien
Timothy writes: > I think it makes sense to leave this open until a fix has been > applied. Done, thanks. -- Bastien

Re: [PATCH] LaTeX export: arbitrary float environments

2021-05-01 Thread Thomas S. Dye
Aloha Timothy, Thanks for your kind response. Sorry for the clumsy patch, which I guess would also benefit from an addition to the manual, as well? Larger question: do we really want to tinker with ob-latex in this way? Or, should changes like this patch follow a path indicated by Tim

Re: Bug: org-plot gives Invalid function error

2021-05-01 Thread Timothy
Bastien writes: >>> plot '/tmp/org-plotiPs0To' using 1:3 with histograms title 'H-index' >> >> This is not valid gnuplot command to create histograms. > > I'm closing this bug now - feel free to reopen it if I misunderstood > the thread. The bug has been identified, but not fixed. I should

Re: Separator "::" -> what is it for in headlines?

2021-05-01 Thread Diego Zamboni
Why does the separator "::" work with headlines? > It doesn't seem to have any effect for me, it gets handled as part of the headline, both in fontification and in exports: [image: image.png] [image: image.png] Which is, as I understand it, as it should be, since it doesn't have any special

Re: Bug: org-plot gives Invalid function error

2021-05-01 Thread Bastien
Hi Ihor and Timothy, Ihor Radchenko writes: > Of course, the described bug may be related to something else. > [after some testing...] > Of course, it is: > >> plot '/tmp/org-plotiPs0To' using 1:3 with histograms title 'H-index' > > This is not valid gnuplot command to create histograms. I'm

Re: Bug: Org bold emphasis gobbles leading stars on next headline [9.3.7 (release_9.3.7-710-g3f04ad @ /home/n/.emacs.d/straight/build/org/)]

2021-05-01 Thread Bastien
Hi, Bastien writes: > Indeed, I can reproduce this bug with latest Org. FWIW I cannot reproduce this anymore (with latest Org and Emacs), I'm closing this bug now. Feel free to reopen it if necessary. -- Bastien

Re: org-goto and org-store-link/org-id-get-create

2021-05-01 Thread Bastien
Bastien writes: > Applied in maint with commit 0a8079b4d, thanks a lot! Er, sorry, I should have explained why I applied it to maint too, on top of applying it to master three days ago: first of all, this is a bugfix, and I also want to take the opportunity of releasing Org 9.4.6 so that more

Re: [PATCH] avoid loading major modes when exporting to file

2021-05-01 Thread Bastien
Hi Timothy, Timothy writes: > Another little patch, this time a one-liner. This even be "auto-mode-alist" instead of "(auto-mode-alist nil)". I'm still unsure the patch is correct: what if people *need* major mode initialization before any contents is exported to a file? > I think the commit

Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match

2021-05-01 Thread Utkarsh Singh
On 2021-05-01, 18:06 +0200, Bastien wrote: > I let you and Nicolas move forward on separators guessing, because so > far I'm not really convinved Org should try to be too clever here. Yes! Nicolas has also convinced me on that front. There was some misunderstanding on my side as I was

Re: org-goto and org-store-link/org-id-get-create

2021-05-01 Thread Bastien
Applied in maint with commit 0a8079b4d, thanks a lot! Ihor Radchenko writes: > Bastien writes: > >> Can you provide a patch for this? > > Sure. Attached. -- Bastien

Re: Bug: org-toggle-link-display and org-hide-emphasis-markers [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)]

2021-05-01 Thread Bastien
Hi Gustavo, Gustavo Barros writes: > when using `org-hide-emphasis-markers', making links visible with > `org-toggle-link-display' also unhides the emphasis markers. I believe > this to be unexpected behavior (it certainly is to me), but I might be > wrong here, given that the emphasis

Re: [Feature Request] More flexibility in org-speed-commands customization

2021-05-01 Thread Bastien
Hi Gustavo, Gustavo Barros writes: > I don't know if there is a strong reason to hard-code the set of keys > in `org-speed-commands-default'. But, if there isn't, could you > consider (somehow) exposing the whole set of `org-speed-commands' to > user customization? Well, no, I don't see a

Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match

2021-05-01 Thread Bastien
Hi Utkarsh, Utkarsh Singh writes: > Actually, I proposed a revised patch in the following tread (which also > include more patches building up on this patch): > https://orgmode.org/list/87zgxpwqa7@gmail.com/T/#m38de818718a71f670fbc21b7abb8c789ef485181 thanks for the heads up. I thought

Re: Bug: org-insert-heading-respect-content before first heading [9.4 (9.4-19-gb1de0c-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201019/)]

2021-05-01 Thread Bastien
Hi Gustavo, Gustavo Barros writes: > I just found a misbehaving of `org-insert-heading-respect-content': when > it's called before the first heading in the buffer, it breaks the > structure of that fist heading by inserting a new heading on the line > the previous heading existed. Fixed

Re: Fwd: Bug: Texinfo export: Inline images are NOT rendered in INFO viewer [9.4.5 (release_9.4.5-354-g40b70c @ /home/rameshnedunchezian/src/org-mode/lisp/)]

2021-05-01 Thread Ramesh Nedunchezian
On 30/04/21 7:25 pm, Nicolas Goaziou wrote: > Hello, > > Ramesh Nedunchezian writes: > >> Bug: Texinfo export: Inline images are NOT rendered in INFO viewer > > Fixed. Thank you. Verified. Thanks.

Re: A small idea to simplify (further) time input in the date/time prompt

2021-05-01 Thread Bastien
Hi Gustavo, sorry for the slow reply. I applied this patch in master with commit e8562a332. Thanks! -- Bastien

Re: [PATCH] Add 'simple option to org-fast-tag-selection-single-key.

2021-05-01 Thread Bastien
Hi tumashu, tumashu writes: > This is v2 patch, use completing-read-multipul. Thanks for the patch. You can already do this: (setq org-use-fast-tag-selection nil) Then you'll be able to select tags the way you implemented it with this simple mode. -- Bastien

Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match

2021-05-01 Thread Utkarsh Singh
Hi Bastien, On 2021-05-01, 10:51 +0200, Bastien wrote: > Hi Utkarsh, > > Utkarsh Singh writes: > >> Can we give small flexibility in choosing the filename interactively for >> `org-table-import'? Currently org-table-import will just throw an error >> when file name doesn't have .txt, .csv or

Re: [PATCH] ob-tangle.el: Speed up tangling

2021-05-01 Thread Bastien
Hi Sébastien, thanks for the patch! I applied against master and tested it. The compiler is complaining with In toplevel form: ob-tangle.el:196:1: Warning: Variable ‘modes’ left uninitialized Also, it breaks these two tests for me: 2 unexpected results:

Re: [PATCH] etc/ORG-NEWS: Announce clocktable per-file time percentages (':formula %')

2021-05-01 Thread Bastien
Hi Alan, "Alan D. Salewski" writes: > Sure thing; included below. Applied in master as commit a2403321a, thanks! -- Bastien

Re: [PATCH] Bug: fragile org refile cache

2021-05-01 Thread Maxim Nikulin
On 29/04/2021 23:08, Ihor Radchenko wrote: My experience is exactly opposite. Or maybe I miss something. Can you elaborate? Some additions. org-outline-path-cache is used solely by org-refile-get-targets (maybe there are some calls in other packages) but it efficiency is questionable. It

[PATCH] etc/ORG-NEWS: Announce clocktable per-file time percentages (':formula %')

2021-05-01 Thread Alan D. Salewski
On Sat, May 1, 2021, at 05:52, Bastien wrote: > Hi Alan, > > applied in master as commit 9aa9f3b1f. > > Thanks you very much! Great, and thank /you/ for all the work you do on org-mode! > Can you announce this by providing a patch for etc/ORG-NEWS? > > -- > Bastien Sure thing; included

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Kyle Meyer
Ihor Radchenko writes: > Kyle Meyer writes: > >> Here are a few notes on ones present in maint that I've glanced at. > > I confirm that there are no warning using Emacs 25.3.1 on maint. > > For Emacs 24.5.1, I see that following in addition to what you > mentioned: Ah, sorry for not writing

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Bastien
Applied as commit 5f619205e with a change log in the commit message. Thanks! Ihor Radchenko writes: >>> In end of data: >>> ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to >>> be > > This does not appear on maint. Only on master. The patch for master attached. --

Re: prettify-symbols-mode in org agenda?

2021-05-01 Thread Ihor Radchenko
William Xu writes: >> (org-agenda-highlight-todo): Preserve composition property used, >> i.e. by `prettify-symbols-mode'. > > It looks like this change is not really needed, my emacs is built from > git master. Maybe the 'composition property is now preserved > automatically in the buffer?

Re: stability of toc links

2021-05-01 Thread Timothy
Nicolas Goaziou writes: > I pointed out some concerns I have about the robustness of this system > already. I don't think you answered to any of them. I fear we may be > communicating past each other in this thread. Sorry about that. I'll try to address the bits I've missed in these last few

Re: stability of toc links

2021-05-01 Thread Nicolas Goaziou
Timothy writes: > Nicolas Goaziou writes: > >> I don't think such a system would preserve properties offered by >> `org-export-get-reference', for example in non-latin languages. Also, >> header content is not stable enough: when you're linking to the custom >> ID, you may be able to change the

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Ihor Radchenko
Bastien writes: > could you provide a patch for these two warnings for the maint branch? >> In end of data: >> ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to >> be This does not appear on maint. Only on master. The patch for master attached. >> In

Re: stability of toc links

2021-05-01 Thread Timothy
Nicolas Goaziou writes: > I don't think such a system would preserve properties offered by > `org-export-get-reference', for example in non-latin languages. Also, > header content is not stable enough: when you're linking to the custom > ID, you may be able to change the title and yet preserve

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Ihor Radchenko
Kyle Meyer writes: > Here are a few notes on ones present in maint that I've glanced at. I confirm that there are no warning using Emacs 25.3.1 on maint. For Emacs 24.5.1, I see that following in addition to what you mentioned: Compiling /home/yantar92/Git/org-mode/lisp/ob-python.el...

Re: prettify-symbols-mode in org agenda?

2021-05-01 Thread William Xu
Ihor Radchenko writes: > Bastien writes: > >> Thanks for bringing this idea up. >> >> If allowing prettify-symbols-mode in Org agenda mode does not slow >> down the agenda display and does not create spacing problems, then >> yes, why not. > > Here is the patch. It will be great if other people

Re: wip-cite status question and feedback

2021-05-01 Thread Bruce D'Arcus
On Fri, Apr 30, 2021 at 5:48 PM Denis Maier wrote: > Yes, this should be equivalent to the behaviour in pandoc. > > However, as I've said before, this behaviour is only correct in American > English. Denis and I are working on sorting out the details of how to address this off-list ATM. But

Re: Bug: org-columns does not respect global-visual-line-mode for long text within headlines

2021-05-01 Thread Nicolas Goaziou
Hello, Nick Savage writes: > I'm filing a bug in relation to org-columns and its interactions with > global-visual-line-mode, which I do not think is expected behaviour. > > 1. Start `emacs -Q' > 2. Create /tmp/test.org (or something like this) > 3. Enable M-x global-visual-line-mode > 4.

Re: stability of toc links

2021-05-01 Thread Nicolas Goaziou
Hello, Timothy writes: > Nicolas Goaziou writes: > >> With the above in mind, I think there are two ways to "improve TOC links >> stability": >> >> 1. Improve the system behind `org-export-get-reference', e.g., so it >>behaves better during plain export. But please keep in mind that >>

Separator "::" -> what is it for in headlines?

2021-05-01 Thread Ypo
Why does the separator "::" work with headlines? Example: * Headline with separator :: This would be the description of a list, but what is it here? 2.6 Plain Lists /Description /list items are unordered list items, and contain the separator ‘::’ to distinguish the description term from

Re: stability of toc links

2021-05-01 Thread Timothy
Nicolas Goaziou writes: > With the above in mind, I think there are two ways to "improve TOC links > stability": > > 1. Improve the system behind `org-export-get-reference', e.g., so it >behaves better during plain export. But please keep in mind that >current major properties must be

Re: stability of toc links

2021-05-01 Thread Nicolas Goaziou
Hello, Tim Cross writes: > Given this is not the first time we have seen a similar discussion > regarding link stability for external references, perhaps it would be > good to summarise and put it on worg for reference? > > First attempt - let me know if I've got it close! > [...] > The org

Re: prettify-symbols-mode in org agenda?

2021-05-01 Thread Ihor Radchenko
Bastien writes: > Thanks for bringing this idea up. > > If allowing prettify-symbols-mode in Org agenda mode does not slow > down the agenda display and does not create spacing problems, then > yes, why not. Here is the patch. It will be great if other people test it first, as I rewrote it from

Re: [PATCH] A proposal to add LaTeX attributes to verse blocks

2021-05-01 Thread Juan Manuel Macías
Hi Bastien, Thank you very much again for your kind suggestions. Bastien writes: > I'm copying Eric, a poweruser of the LaTeX backend, so that he can > perhaps comment on the general usefulness of this addition. I think these additions (line numbers, optical centering of the poem, etc.) can

Re: [PATCH] Babel: remove LaTeX environment -type #+results

2021-05-01 Thread Timothy
Bastien writes: > Applied in master as commit b90b850ae. > > Can you add a etc/ORG-NEWS entry for this? Great! News entry added. -- Timothy

Re: [PATCH] org-capture.el: Add new capture template option :refile-to

2021-05-01 Thread Bastien
Hi Richard, thanks for this addition! I think ":refile-targets" is more straightforward. I applied your patch with this change and a slightly modified commit message. Also, I documented this in the manual and added an entry to etc/ORG-NEWS. Thanks! -- Bastien

Re: wip-cite status question and feedback

2021-05-01 Thread Nicolas Goaziou
Hello, Denis Maier writes: > However, as I've said before, this behaviour is only correct in > American English. TO quuote the Chicago Manual of Style 6.9: "In an > alternative system, sometimes called British Style (as described in > the /New Oxford Style Manual ...) ... only those punctuation

Re: [PATCH] LaTeX export: arbitrary float environments

2021-05-01 Thread Timothy
Hi Thomas, On the surface, this looks reasonable to me :) Just commenting on some technicalities with the patch itself: - In ORG-NEWS it would be good to wrap the content over multiple lines instead of having a single 270 char line :) - You seem to have an anomalous change to the ob-python

Re: [PATCH] Babel: remove LaTeX environment -type #+results

2021-05-01 Thread Bastien
Hi Timothy, Timothy writes: > I think there's potential for some really nice experiences leveraging > Org's latex rendering in combination with some languages' symbolic maths > ability. Applied in master as commit b90b850ae. Can you add a etc/ORG-NEWS entry for this? -- Bastien

Re: [PATCH] A proposal to add LaTeX attributes to verse blocks

2021-05-01 Thread Timothy
Hi Juan, Sorry it's still taking a while for your patch to be looked at. Assuming it does get merged, it would be good to check if you'd be willing to write a manual entry to accompany this (in a separate patch works). Thanks again for the patch, Timothy. Juan Manuel Macías writes:

Re: [PATCH] org-src.el Do not ask to revert unmodified buffers

2021-05-01 Thread Bastien
Timothy writes: > Hi pillule, should we consider this patch cancelled? It is already :) -- Bastien

Re: [PATCH] A proposal to add LaTeX attributes to verse blocks

2021-05-01 Thread Bastien
Hi Juan, Juan Manuel Macías writes: > I am attaching a new version of my patch for adding LaTeX attributes to > verse blocks. Following the kind suggestions from Timothy, I have also > documented this new features that I propose. I don't know if I have done > it correctly and in the right

Re: [PATCH] org-src.el Do not ask to revert unmodified buffers

2021-05-01 Thread Timothy
Hi pillule, should we consider this patch cancelled? pillule writes: > You are right I clearly missed org-src-ask-before-returning-to-edit-buffer > Don't know how . . . > > Sorry for the noise.

Re: [PATCH] ob-plantuml: Add PlantUML block post-processing.

2021-05-01 Thread Bastien
Hi Nick, Nick Daly writes: > +(org-babel-plantuml-post-process out-file) Note that I had to remove the line above from your second patch. Can you confirm it is not necessary for your second patch to work? Thanks, -- Bastien

Re: [PATCH] org-agenda.el: Add a M-, binding for org-priority-show

2021-05-01 Thread Bastien
Hi Kyle and Adam, Kyle Meyer writes: > With a C-u, org-agenda-priority calls org-priority-show. So perhaps > instead of adding a new binding, the documentation should be improved. I pushed a small enhancement for org-agenda-priority's docstring with commit e080eb759. I am reluctant adding

Re: [PATCH] ob-sql: blocks without :engine get stuck in org-edit-src-code on indent

2021-05-01 Thread Bastien
Hi Ivan, thanks for the explanations. I applied your patch in maint with commit 45ca597f9, adding a commit message to it. See https://orgmode.org/worg/org-contribute.html#commit-messages Thanks, -- Bastien

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-05-01 Thread Bastien
Hi Emily, thanks for the patch and sorry to reactivate this old thread. Did you find time to make the tests and, perhaps, to update the patch? Please let us know - thanks! -- Bastien

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Bastien
Nicolas Goaziou writes: > So, again, I'm not saying we should do this. TBH, I'm not convinced by > the idea of duplicate syntax (comma-escaping and alternate characters) > for the same thing. But hard-core macro users may have a word to say > about it. FWIW I'm not convinced too but I'd also

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Bastien
Nicolas Goaziou writes: > So, maybe it is a bit early to close it. Okay, thanks for the heads up, I'm reopening then. -- Bastien

Re: [PATCH] org-protocol: Make org protocol defaults work on windows

2021-05-01 Thread Bastien
Hi, Maxim Nikulin writes: > On 20/11/2020 23:26, Robert wrote: >> Attached a little patch to make the default org-protocol >> handlers work on windows. > > Unsure, but the issue might be addressed by the following change: > https://code.orgmode.org/bzg/org-mode/commit/928e67df > org-protocol:

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Nicolas Goaziou
Hello, Bastien writes: > thank you for the patch. I understand the general idea, but I think > we should be careful not to overload the macro syntax - escaping the > coma seems okay to me. I'm closing this suggestion. > > I'm cc'ing Nicolas: if he thinks it's a useful addition, I won't of >

Re: [PATCH] Add font-lock rule for inline export snippets

2021-05-01 Thread Bastien
Hi Timothy, Timothy writes: > The latest in my visually-oriented (mostly) short patch series, adding > basic fontification to inline export snippets --- @@comment:these > things@@. Applied in master with commit eef9027c, thanks! I also added a note in etc/ORG-NEWS. -- Bastien

Re: [PATCH] fix point position shifting in some org-src instances

2021-05-01 Thread Bastien
Applied in maint as commit 400d2d9fd, with a minor modification of the commit message. Thanks! -- Bastien

Re: [PATCH] org-clock.el: clocktable ':formula %' now includes per-file time pct

2021-05-01 Thread Bastien
Hi Alan, applied in master as commit 9aa9f3b1f. Thanks you very much! Can you announce this by providing a patch for etc/ORG-NEWS? -- Bastien

Re: Emacs Lisp book (was: Step by step tutorial on Worg on how to create a new export backend)

2021-05-01 Thread Marcin Borkowski
On 2021-05-01, at 10:37, Timothy wrote: > Marcin Borkowski writes: > >> Surprise, surprise! >> >> The book is out! >> >> Before you get too excited - it's not complete yet. I published a draft >> on Leanpub, which is a platform for publishing (and selling) books in >> progress. I plan to

Re: Bug: JavaScript in HTML export not recognized by LibreJS as free [9.4.5 (9.4.5-16-g94be20-elpaplus @ /home/jorge/.config/emacs/elpa/org-plus-contrib-20210412/)]

2021-05-01 Thread Bastien
Hi Anthony, Anthony Carrico writes: > The original implementation flip-flops between cached and normal > classes (six statements removed in the original patch), whereas my > clone adds and removes a class name from the classList (three > statements inserted in the original patch). Thanks - I

Re: [PATCH] ob-plantuml: Add PlantUML block post-processing.

2021-05-01 Thread Bastien
Hi Nick, Nick Daly writes: > Nick Daly writes: > >> Please see the attached patch that allows for post-processing of >> PlantUML diagrams based on the exported file extension. > > If the above patch was too generic and heavy-weight for consideration, > please see this alternative, simpler,

Re: [PATCH] Have C-c C-c recognise #+plot lines

2021-05-01 Thread Bastien
Eric S Fraga writes: > On Saturday, 1 May 2021 at 08:56, Bastien wrote: >> I have fixed this with commit ee507de47, can you confirm? > > Seems to work just fine now. Thank you. Thanks for confirming! -- Bastien

Re: bug#47820: [PATCH] org-table-import: Give option to import interactively even if filename doesn't match

2021-05-01 Thread Bastien
Hi Utkarsh, Utkarsh Singh writes: > Can we give small flexibility in choosing the filename interactively for > `org-table-import'? Currently org-table-import will just throw an error > when file name doesn't have .txt, .csv or .tsv as extension. Applied in master as commit 7c99d1555, thanks.

Re: could a :var header argument refer to a data table in another file?

2021-05-01 Thread Eric S Fraga
On Saturday, 1 May 2021 at 07:58, Michael Welle wrote: > I smell something strange going on here ;). Synchronicity, aka great minds think alike. :-) -- : Eric S Fraga via Emacs 28.0.50, Org release_9.4.5-405-g0a689b

Re: [PATCH] Have C-c C-c recognise #+plot lines

2021-05-01 Thread Eric S Fraga
Hi Bastien, On Saturday, 1 May 2021 at 08:56, Bastien wrote: > I have fixed this with commit ee507de47, can you confirm? Seems to work just fine now. Thank you. -- : Eric S Fraga via Emacs 28.0.50, Org release_9.4.5-405-g0a689b

Re: Emacs Lisp book (was: Step by step tutorial on Worg on how to create a new export backend)

2021-05-01 Thread Timothy
Marcin Borkowski writes: > Surprise, surprise! > > The book is out! > > Before you get too excited - it's not complete yet. I published a draft > on Leanpub, which is a platform for publishing (and selling) books in > progress. I plan to finish it by September, but if you want to take > a

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Bastien
Hi Juan, thank you for the patch. I understand the general idea, but I think we should be careful not to overload the macro syntax - escaping the coma seems okay to me. I'm closing this suggestion. I'm cc'ing Nicolas: if he thinks it's a useful addition, I won't of course insist on rejecting

Emacs Lisp book (was: Step by step tutorial on Worg on how to create a new export backend)

2021-05-01 Thread Marcin Borkowski
On 2020-02-16, at 01:46, Jean-Christophe Helary wrote: > Aren't you supposed to write a book about Emacs already ? ;) Surprise, surprise! The book is out! Before you get too excited - it's not complete yet. I published a draft on Leanpub, which is a platform for publishing (and selling)

Re: [PATCH] Have C-c C-c recognise #+plot lines

2021-05-01 Thread Bastien
Hi Eric, Eric S Fraga writes: > On Thursday, 29 Apr 2021 at 02:04, Timothy wrote: >> Have you had a chance to test this out? > > Further on this, I don't have time to debug right now but the patch > seems to have broken org table recalculation, specifically C-u C-c C-c > on a table. I have