Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

2024-03-15 Thread Aaron Zeng
Thanks for the merge! On Fri, Mar 15, 2024, at 17:38, Matt wrote: > Finally had time to commit it. > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0e2a9524dc6da8b4d60672e85aba74076baac211 > > Nice catch and thanks for your contribution! > > -- > Matt Trzcinski > Emacs Org

[BUG] Bad interaction between org-add-log-setup and org-with-remote-undo [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)]

2023-08-04 Thread Aaron Zeng
Hi folks, It seems there is a bad interaction between org-add-log-setup and org-with-remote-undo, such that org-agenda-undo does not function correctly. For example, 1. Enable logging on reschedule, by setting `org-log-reschedule' to `time'. 2. Reschedule an already-scheduled TODO item

[PATCH] Fix bug in orgtbl-self-insert-command when used with evil-escape

2023-04-06 Thread Aaron Zeng
There appears to be a bug in orgtbl-self-insert-command, which uses last-input-event instead of last-command-event. self-insert-command itself uses the latter variable. Reproduction steps: 1. Enable evil-mode and evil-escape-mode 2. Set `evil-escape-key-sequence' to "fd" (the default) 3. In

Re: [PATCH] org--batch-store-agenda-views: Fix treatment of lambda functions

2023-02-08 Thread Aaron Zeng
New patch looks good. Thanks! On Wed, Feb 8, 2023 at 05:09 Ihor Radchenko wrote: > "Aaron L. Zeng" writes: > > > * org-agenda.el (org--batch-store-agenda-views): Fix treatment of > > lambda functions used as custom agenda commands. > > `org-agenda-custom-commands' entries may specify a custom

Re: [PATCH] org--batch-store-agenda-views: Fix treatment of lambda functions

2023-02-07 Thread Aaron Zeng
Thanks Ihor, I sent a new patch with your comment included verbatim, and also added a ChangeLog entry. On Tue, Feb 7, 2023 at 12:47 PM Aaron L. Zeng wrote: > * org-agenda.el (org--batch-store-agenda-views): Fix treatment of > lambda functions used as custom agenda commands. >

Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Aaron Zeng
Much obliged :) On Tue, Jan 24, 2023 at 1:20 PM Ihor Radchenko wrote: > Aaron Zeng writes: > > > Hi Ihor, I just noticed that this patch only fixes one of the lines > calling > > `string-pad'. There is another callsite below which needs to be removed. > > Oops. Now

Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Aaron Zeng
Hi Ihor, I just noticed that this patch only fixes one of the lines calling `string-pad'. There is another callsite below which needs to be removed. On Tue, Jan 24, 2023 at 11:30 AM Aaron Zeng wrote: > Thanks for the quick response, Ihor! > > On Tue, Jan 24, 2023 at 4:23 AM Ihor

Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Aaron Zeng
Thanks for the quick response, Ihor! On Tue, Jan 24, 2023 at 4:23 AM Ihor Radchenko wrote: > "Aaron L. Zeng" writes: > > > * org-compat.el (org-string-pad): Add compatibility function > > `org-string-pad' for `string-pad', introduced in Emacs 28.1. > > > > * org-agenda.el

Re: [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer

2022-05-25 Thread Aaron Zeng
Thanks Ihor! And, noted for the future. On Thu, May 26, 2022 at 12:34 AM Ihor Radchenko wrote: > "Aaron L. Zeng" writes: > > > (I'm resubmitting this patch because my previous submission was > in-reply-to > > another email which I suspect was ignored. Would love to get this > relatively > >

[PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer

2022-03-18 Thread Aaron Zeng
The following changes since commit 668205f7693e028f15240ffc043e037b411daf81: Backport commit d52c929e3 from Emacs (2022-03-02 23:02:50 -0500) are available in the Git repository at: g...@github.com:bcc32/org-mode.git bugfix for you to fetch changes up to

Re: Bug: Infinite loop in org-agenda-dim-blocked-tasks

2021-05-10 Thread Aaron Zeng
Hi Bastien, Unfortunately, I think this bug is still there (I also didn't see any commits addressing it, but I could have missed it in the log somewhere). I tried the master branch but was still able to reproduce the bug using `emacs -q -L ~/src/org-mode/lisp`: After using

Re: [O] Bug: org-clock-cancel doesn't set org-clock-current-task correctly [9.2.3 (9.2.3-23-g967801-elpaplus @ /.emacs.d/elpa/26.2/develop/org-plus-contrib-20190603/)]

2019-06-10 Thread Aaron Zeng
Yes, I still see this with a vanilla config. I tried with [emacs -q] and the builtin org mode (9.1.9), as well as with 967801. On Mon, Jun 10, 2019 at 10:43 PM Kyle Meyer wrote: > Aaron Zeng writes: > > > (I'm running org mode from the Spacemacs org layer, which includes the

[O] Bug: org-clock-cancel doesn't set org-clock-current-task correctly [9.2.3 (9.2.3-23-g967801-elpaplus @ /.emacs.d/elpa/26.2/develop/org-plus-contrib-20190603/)]

2019-06-10 Thread Aaron Zeng
(I'm running org mode from the Spacemacs org layer, which includes the org-plus-contrib package). Reproduction: 1. Create a new entry "* TODO Temp" 2. Clock in under that entry 3. Cancel the clock 4. [M-x describe-variable org-clock-current-task] is still set to "Temp" instead of being nil, which