Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-25 Thread Ihor Radchenko
Jens Schmidt writes: >> There is no universal rule when and when not to add trailing spaces in >> the tests. > > Not sure what you mean by that, but some tests rely on trailing spaces > and fail when these are not present. An explicit test on that would > make the issue more visible. See below

Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Jens Schmidt
On 2023-08-24 14:24, Ihor Radchenko wrote: > Jens Schmidt writes: > >> Would you mind if I added a test that explicitly and with some nice >> error message tests for that condition? I.e. if some unwary user >> strips off trailing whitespace in test-org.el, that test would fail >> with a

Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Ihor Radchenko
Ihor Radchenko writes: > What we can do is setting `delete-trailing-lines' to nil in tests - via > directory-local variable. Never mind. This will not affect deleting empty lines that are not at the end of buffer.

Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Ihor Radchenko
Jens Schmidt writes: > Would you mind if I added a test that explicitly and with some nice > error message tests for that condition? I.e. if some unwary user > strips off trailing whitespace in test-org.el, that test would fail > with a reasonable message. There is no universal rule when and

Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Jens Schmidt
On 2023-08-24 13:41, Ihor Radchenko wrote: > Jens Schmidt writes: > >> Seems the insert-heading-issue is still struggling, this time during >> a "make check" @ d5ee33fed8dd80d3f9f9811d86a73827fde80780 using Emacs 29: >> ... >>FAILED 998/1094 test-org/insert-heading (0.018306 sec) at >>

Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Ihor Radchenko
Jens Schmidt writes: > Seems the insert-heading-issue is still struggling, this time during > a "make check" @ d5ee33fed8dd80d3f9f9811d86a73827fde80780 using Emacs 29: > ... >FAILED 998/1094 test-org/insert-heading (0.018306 sec) at > ../lisp/test-org.el:1845 I cannot reproduce on my

[BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29)

2023-08-24 Thread Jens Schmidt
Seems the insert-heading-issue is still struggling, this time during a "make check" @ d5ee33fed8dd80d3f9f9811d86a73827fde80780 using Emacs 29: Test test-org/insert-heading condition: (ert-test-failed ((should (equal "* 1\n** 1.1\n** 1.2\n*\n* 2"