Re: [O] [PATCH] ob-core: do not ask for confirmation if cached value is current

2013-03-09 Thread Achim Gratz
Based on discussion with Nicolas Goaziou and Eric Schulte, this patch has been refactored and reimplemented as a patch series. Eric Schulte has contributed additional improvements. The functionality is now in Org. Regards, Achim. -- +[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk

Re: [O] [PATCH] ob-core: do not ask for confirmation if cached value is current

2013-02-27 Thread Bastien
Hi Achim, Achim Gratz strom...@nexgo.de writes: Babel asks for confirmation to evaluate a source block even when it is going to use the cached value. This patch skips the superfluous confirmation in that case (no evaluation takes place, the cached value is used). thanks for the patch. I

Re: [O] [PATCH] ob-core: do not ask for confirmation if cached value is current

2013-02-27 Thread Achim Gratz
Bastien bzg at altern.org writes: thanks for the patch. I applied it but renamed cache? and cache-current? to cache-p and cache-current-p. Thanks. I have no preference either way regarding the names, I was just following the example of cache?, which I copied from the original code. There's

Re: [O] [PATCH] ob-core: do not ask for confirmation if cached value is current

2013-02-27 Thread Bastien
Achim Gratz strom...@nexgo.de writes: There's another cache? in ob-lob, IIRC. Fixed, thanks. -- Bastien

Re: [O] [PATCH] ob-core: do not ask for confirmation if cached value is current

2013-02-27 Thread Achim Gratz
Bastien bzg at altern.org writes: thanks for the patch. I applied it but renamed cache? and cache-current? to cache-p and cache-current-p. That patch needs amending. You let-bind cache-current, but then try to use cache-current-p. Regards, Achim.

Re: [O] [PATCH] ob-core: do not ask for confirmation if cached value is current

2013-02-27 Thread Bastien
Achim Gratz strom...@nexgo.de writes: Bastien bzg at altern.org writes: thanks for the patch. I applied it but renamed cache? and cache-current? to cache-p and cache-current-p. That patch needs amending. You let-bind cache-current, but then try to use cache-current-p. Er... fixed,

[O] [PATCH] ob-core: do not ask for confirmation if cached value is current

2013-02-26 Thread Achim Gratz
Babel asks for confirmation to evaluate a source block even when it is going to use the cached value. This patch skips the superfluous confirmation in that case (no evaluation takes place, the cached value is used). From da687f5a40767921c7f3f309eeda0cadb09f7116 Mon Sep 17 00:00:00 2001 From: