Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-05 Thread Alan Schmitt
Rasmus writes: > Alan Schmitt writes: > >> Rasmus: do you want to change these, or should I do it and apply the >> patch? (The former would be simpler, I have to say.) > > Attached. Sorry about the delay. They should fix Nicholas' > 'concerns'. Applied and pushed, thanks. Alan

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-05 Thread Alan Schmitt
Alan Schmitt writes: > Hello Rasmus, > > I applied the first patch, with the following small changes. Please ignore this email, there was something wrong in my setup (I was in the maint branch ...). Sorry for the noise. Alan

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-05 Thread Alan Schmitt
Hello Rasmus, I applied the first patch, with the following small changes. This part would not apply: --8<---cut here---start->8--- @@ -252,7 +258,7 @@ This option can also be set with the OPTIONS keyword, e.g.: :group 'org-export-koma-letter) (defcustom

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-05 Thread Rasmus
Nicolas Goaziou writes: > No. Other groups are `org-export-latex', `org-export-html'... Bastien writes: > Unless I miss something, other groups are > > org-export-html > org-export-latex > > etc. > > so org-export-koma-letter seems right. Right. That's a late night blunder on my part! Thank

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-05 Thread Alan Schmitt
Rasmus writes: > Quick but unrelated question. I'm updating the Worg page and I > noticed that the customize-group for ox-koma-letter is > org-export-koma-letter. Given that other groups are org-latex and > org-html etc., should the group not be called org-koma-letter? Yes, org-koma-letter sou

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-04 Thread Bastien
Hi Rasmus, Rasmus writes: > Quick but unrelated question. I'm updating the Worg page and I > noticed that the customize-group for ox-koma-letter is > org-export-koma-letter. Given that other groups are org-latex and > org-html etc., should the group not be called org-koma-letter? Unless I mis

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-04 Thread Nicolas Goaziou
Hello, Rasmus writes: > Given that other groups are org-latex and > org-html etc., should the group not be called org-koma-letter? No. Other groups are `org-export-latex', `org-export-html'... Regards, -- Nicolas Goaziou

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-04 Thread Rasmus
Quick but unrelated question. I'm updating the Worg page and I noticed that the customize-group for ox-koma-letter is org-export-koma-letter. Given that other groups are org-latex and org-html etc., should the group not be called org-koma-letter? –Rasmus PS: Sorry for not starting a new thread

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-04 Thread Rasmus
Alan Schmitt writes: > Rasmus: do you want to change these, or should I do it and apply the > patch? (The former would be simpler, I have to say.) Attached. Sorry about the delay. They should fix Nicholas' 'concerns'. –Rasmus -- Vote for proprietary math! >From 8f3e69f5ca3d0153b6f4c80b74c7a

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-04 Thread Rasmus Pank Roulund
>>> Would you give the attached patches a spin? I think they work nicely; >>> only the second patch is non-trivial. Basically, one can ignore >>> subject and title differences as now by setting >>> org-koma-letter-prefer-subject to t and not use the SUBJECT keyword. >>> >>> I have set the default

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-02-04 Thread Alan Schmitt
Hello, Sorry for not replying earlier, I've been swamped by traveling and work. Nicolas Goaziou writes: > Hello, > > Rasmus writes: > >> Would you give the attached patches a spin? I think they work nicely; >> only the second patch is non-trivial. Basically, one can ignore >> subject and tit

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-01-25 Thread Nicolas Goaziou
Hello, Rasmus writes: > Would you give the attached patches a spin? I think they work nicely; > only the second patch is non-trivial. Basically, one can ignore > subject and title differences as now by setting > org-koma-letter-prefer-subject to t and not use the SUBJECT keyword. > > I have se

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-01-25 Thread Rasmus
Nicolas, Nicolas Goaziou writes: > Rasmus writes: > >> Nicolas Goaziou writes: >> I finally had the time to fix these old patches. Sorry about the wait. >>> >>> You should update Org first. I modified large parts of ox-koma-letter.el >>> recently so your patches will probably not ap

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-01-18 Thread Nicolas Goaziou
Rasmus writes: > Nicolas Goaziou writes: > >>> I finally had the time to fix these old patches. Sorry about the >>> wait. >> >> You should update Org first. I modified large parts of ox-koma-letter.el >> recently so your patches will probably not apply. Also, some parts are >> not necessary any

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-01-18 Thread Rasmus
Nicolas Goaziou writes: >> I finally had the time to fix these old patches. Sorry about the >> wait. > > You should update Org first. I modified large parts of ox-koma-letter.el > recently so your patches will probably not apply. Also, some parts are > not necessary anymore. I did. . . And I f

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-01-18 Thread Nicolas Goaziou
Hello, Rasmus writes: > I finally had the time to fix these old patches. Sorry about the > wait. You should update Org first. I modified large parts of ox-koma-letter.el recently so your patches will probably not apply. Also, some parts are not necessary anymore. Regards, -- Nicolas Goazio

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2014-01-18 Thread Rasmus
Alan, I finally had the time to fix these old patches. Sorry about the wait. Alan Schmitt writes: > Hello, >> Attached are a couple of changes to ox-koma-letter following a recent >> bug report by James. >> >> 1. Minor fixes around. The way subject-format was handled before was >>ugly. U

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2013-11-25 Thread Michael Strey
Hi Rasmus, ras...@gmx.us writes: [...] > 3. When studying the KOMA manual to answer James' second question I >came across the komavar title which is currently not supported. I >have added support for a separate SUBJECT keyword. The heuristic >is something like this (i) if title and

[O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes

2013-11-24 Thread Rasmus
Hi all, Attached are a couple of changes to ox-koma-letter following a recent bug report by James. 1. Minor fixes around. The way subject-format was handled before was ugly. Updated some docstrings etc. 2. better test of whether values have changed in the buffer. I think Alan added this