Hello,
Ryo TAKAISHI writes:
> But, I had forgot to escape double quote in docstring, so attach patch
> fixing it.
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
Hello,
Nicolas Goaziou writes:
> Hello,
>
> Ryo TAKAISHI writes:
>
>> I create a complete patch for current commit.
>
> I've pushed your patch on master (with some documentation tweaks). Thank
> you for your work.
Thank you very much.
But, I had forgot to escape double quote in docstring, so a
Hello,
Ryo TAKAISHI writes:
> I create a complete patch for current commit.
I've pushed your patch on master (with some documentation tweaks). Thank
you for your work.
Also, please consider signing FSF papers if you want to make other
contributions to Org.
Regards,
--
Nicolas Goaziou
Nicolas Goaziou writes:
> Otherwise the code is fine. Would you provide a complete patch, i.e.
> with `git format-patch'? The changelog entry may be:
I create a complete patch for current commit.
Regards,
Ryo
>From d82c99bb643e2c61e1f5b598a687160340a1558f Mon Sep 17 00:00:00 2001
From: Ryo TAK
Ryo TAKAISHI writes:
> I fixed and added document in docstring & org.texi.
Thank you.
> + @r{If sexp's attr is link keyword (@code{%:keyword}),}
> + @r{it will be expanded using @code{org-store-link-plist}.}
Documentation should not contain a reference to `org
Nicolas Goaziou writes:
> The code looks good, although I would have moved the external `mapcar'
> within the worker function in order to make its purpose clearer.
>
> Also, would you mind to provide a docstring for the function? Something
> along the lines of:
>
> "Recursively replace captur
Hello,
> I fix these problem. A new patch expand keyword recursively, and only
> symbol.
Great.
> + (let* ((sexp (mapcar 'org-capture-expand-keyword-in-embedded-elisp
> + (read (current-buffer
> +(result (org-eval sexp)))
> (delete-region temp
Nicolas Goaziou writes:
> Ryo TAKAISHI writes:
>
>> I did'nt come up with to use it.
>> But "%(func %:description)" or "%(func (plist-get
>> org-store-link-plist :description))", I think the former is readble
>> template than the latter.
>
> Probably, but it's also more error-prone.
>
> For exam
Ryo TAKAISHI writes:
> I did'nt come up with to use it.
> But "%(func %:description)" or "%(func (plist-get org-store-link-plist
> :description))", I think the former is readble template than the latter.
Probably, but it's also more error-prone.
For example, your code operates only at top-leve
Nicolas Goaziou writes:
> Hello,
>
> Thanks for your patch. Here are a few comments about it.
>
> Ryo TAKAISHI writes:
>
>> * lisp/org-capture.el: If %(SEXP) has %:keyword, expand it using
>> org-store-link-plist.
>>
>> I want to expand %:description keyword in sexp "%(func %:description)".
>
Hello,
Thanks for your patch. Here are a few comments about it.
Ryo TAKAISHI writes:
> * lisp/org-capture.el: If %(SEXP) has %:keyword, expand it using
> org-store-link-plist.
>
> I want to expand %:description keyword in sexp "%(func %:description)".
> But if org-capture template is "%(functi
* lisp/org-capture.el: If %(SEXP) has %:keyword, expand it using
org-store-link-plist.
I want to expand %:description keyword in sexp "%(func %:description)".
But if org-capture template is "%(function %:keyword)", function take a symbol
%:keyword, it does'nt expand.
This patch expand %:keyword
12 matches
Mail list logo
