Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-21 Thread Bastien
Hi Ian, Ian Kelling i...@iankelling.org writes: Done. I was actually following the instructions in man git-format-patch by not attaching it before, but I will avoid that in future. Applied, thanks. I slightly rewrote the changelog message, please have a look for further patches. Thanks! --

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-08 Thread Ian Kelling
Eric Schulte schulte.e...@gmail.com writes: This looks good to me. Could you reformat the patch with git format-patch and attach the results (this will be easier to apply). Done. I was actually following the instructions in man git-format-patch by not attaching it before, but I will

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-07 Thread Eric Schulte
This looks good to me. Could you reformat the patch with git format-patch and attach the results (this will be easier to apply). Also, this patch is small enough to apply without any sort of copyright attribution, but if you think you might make larger contributions in the future, please

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-04 Thread Eric Schulte
Ian Kelling i...@iankelling.org writes: Ian Kelling i...@iankelling.org writes: It's a bit late. here is the same patch with correct indentation. That patch went out of it's way not to check more of the list than was necessary, but after sending it, I kept thinking that it does extra

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-04 Thread Ian Kelling
Eric Schulte schulte.e...@gmail.com writes: Hi Ian, You should use the `org-every' function here. Look at the source of that function to see code to efficiently perform this sort of check. Best, Brilliant. Thank you. The updated patch below should be good. -- 8 -- Subject: [PATCH] Fix

[O] [PATCH] Fix error prone babel table output format detection

2014-05-01 Thread Ian Kelling
From dc0b727328266785528fe160046ae1aa8df8a993 Mon Sep 17 00:00:00 2001 Message-ID: 87zjj2ous9@treetowl.lan MIME-Version: 1.0 Content-Type: text/plain * lisp/ob-core.el: Test that all elements are in a list are lists instead of just the first. org-babel table output uses different formatting

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-01 Thread Achim Gratz
Ian Kelling writes: org-babel table output uses different formatting for a list of lists, but detects it incorrectly causing an error, as in this example: #+begin_src emacs-lisp '((1) 2) #+end_src So this isn't a proper table, what do you expect to happen? -

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-01 Thread Ian Kelling
Achim Gratz strom...@nexgo.de writes: Ian Kelling writes: org-babel table output uses different formatting for a list of lists, but detects it incorrectly causing an error, as in this example: #+begin_src emacs-lisp '((1) 2) #+end_src So this isn't a proper table, what do you expect to

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-01 Thread Ian Kelling
Ian Kelling i...@iankelling.org writes: Achim Gratz strom...@nexgo.de writes: Ian Kelling writes: org-babel table output uses different formatting for a list of lists, but detects it incorrectly causing an error, as in this example: #+begin_src emacs-lisp '((1) 2) #+end_src So this

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-01 Thread Ian Kelling
Ian Kelling i...@iankelling.org writes: Below is a patch that addresses the 2 previously mentioned problems. It's a bit late. here is the same patch with correct indentation. -- 8 -- Subject: [PATCH] Fix error prone babel table output format detection * lisp/ob-core.el: Test that all

Re: [O] [PATCH] Fix error prone babel table output format detection

2014-05-01 Thread Ian Kelling
Ian Kelling i...@iankelling.org writes: It's a bit late. here is the same patch with correct indentation. That patch went out of it's way not to check more of the list than was necessary, but after sending it, I kept thinking that it does extra things which possibly negate any performance