Re: [O] [PATCH] Lookup functions for tables

2012-09-21 Thread Bastien
Hi Jarmo Jarmo Hurri writes: > Bastien writes: > >> The patch is longer than 20 lines, so we would need you to sign the >> FSF papers to be able to accept it. > > Request submitted. Thanks -- I added your name in the "pending" section of this Worg page (which will get updated soon) : http://o

Re: [O] [PATCH] Lookup functions for tables

2012-09-20 Thread Michael Brand
Hi Jarmo On Fri, Sep 21, 2012 at 7:44 AM, Jarmo Hurri wrote: > Ok. I guess this also means changing the (next,prev,up) parts of > @node-commands. Yes. > Do you want me to make the change and submit a new patch? Yes please, I suggest to wait a bit if there will be more comments. Michael

Re: [O] [PATCH] Lookup functions for tables

2012-09-20 Thread Jarmo Hurri
>> --- a/doc/org.texi >> +++ b/doc/org.texi >> @@ -2399,6 +2399,7 @@ formula, moving these references by arrow keys >> * Formula syntax for Lisp:: Writing formulas in Emacs Lisp >> * Durations and time values:: How to compute durations and time values >> * Field and range formulas::Fo

Re: [O] [PATCH] Lookup functions for tables

2012-09-20 Thread Achim Gratz
Jarmo Hurri writes: > 2. When I tried to run "make test", it failed because I don't have ERT >installed. I am running Emacs 23.3.1, which does not include ERT, and >I could not find a package providing ert.el in the repositories of >Fedora 16. Because I was running out of time, I decide

Re: [O] [PATCH] Lookup functions for tables

2012-09-20 Thread Michael Brand
Hi Jarmo On Wed, Sep 19, 2012 at 6:48 PM, Jarmo Hurri wrote: > --- a/doc/org.texi > +++ b/doc/org.texi > @@ -2399,6 +2399,7 @@ formula, moving these references by arrow keys > * Formula syntax for Lisp:: Writing formulas in Emacs Lisp > * Durations and time values:: How to compute duratio

Re: [O] [PATCH] Lookup functions for tables

2012-09-20 Thread Jarmo Hurri
>> I tested the new functions locally, as can be seen from the >> examples. I also ran make without problems. I am, however, unable to >> install org from the git version (for some unknown reason), so I was >> unable to test the final, committed version. > > I can't decode that last part… you inst

Re: [O] [PATCH] Lookup functions for tables

2012-09-20 Thread Jarmo Hurri
Achim Gratz writes: > Well, it doesn't become a TINYCHANGE just because you put that stamp > on it. This patch clearly is over 20 non-trivial lines, so you will > need to assign copyright to the FSF. The program code (one macro and two calls) is less than 20 lines, and I was hoping documentatio

Re: [O] [PATCH] Lookup functions for tables

2012-09-20 Thread Jarmo Hurri
Bastien writes: > The patch is longer than 20 lines, so we would need you to sign the > FSF papers to be able to accept it. Request submitted. -- Jarmo

Re: [O] [PATCH] Lookup functions for tables

2012-09-19 Thread Achim Gratz
Jarmo Hurri writes: > I tested the new functions locally, as can be seen from the examples. I > also ran make without problems. I am, however, unable to install org > from the git version (for some unknown reason), so I was unable to test > the final, committed version. I can't decode that last pa

Re: [O] [PATCH] Lookup functions for tables

2012-09-19 Thread Achim Gratz
Jarmo Hurri writes: > * lisp/org-table.el: added functions org-lookup-first and > org-lookup-last > * doc/org.texi: documented the use of lookup functions > > TINYCHANGE Well, it doesn't become a TINYCHANGE just because you put that stamp on it. This patch clearly is over 20 non-trivial lines, so

Re: [O] [PATCH] Lookup functions for tables

2012-09-19 Thread Bastien
Jarmo Hurri writes: > I am, however, unable to install org > from the git version (for some unknown reason), so I was unable to test > the final, committed version. Please let us know what's wrong here, we will try to help. -- Bastien

Re: [O] [PATCH] Lookup functions for tables

2012-09-19 Thread Bastien
Hi Jarmo, Jarmo Hurri writes: > The patch posted here is the first patch I have ever made with git, so I > hope it is ok. thanks for contributing to Org! The patch is longer than 20 lines, so we would need you to sign the FSF papers to be able to accept it. The form is here: http://orgmod

Re: [O] [PATCH] Lookup functions for tables

2012-09-19 Thread Jarmo Hurri
Greetings. The patch posted here is the first patch I have ever made with git, so I hope it is ok. I tested the new functions locally, as can be seen from the examples. I also ran make without problems. I am, however, unable to install org from the git version (for some unknown reason), so I was

[O] [PATCH] Lookup functions for tables

2012-09-19 Thread Jarmo Hurri
* lisp/org-table.el: added functions org-lookup-first and org-lookup-last * doc/org.texi: documented the use of lookup functions TINYCHANGE --- doc/org.texi | 88 +++- lisp/org-table.el | 10 ++ 2 files changed, 96 insertions(+), 2 del