Andreas Gerler writes:
> * lisp/ob-eval.el: (org-babel-eval-error-notify): Display standard
> error only if command exits non zero.
>
> The problem is that sql connections might give warnings.
> Now the information is available in the *Org-Babel Error* buffer
> without displaying.
> If you need
Hi Ihor,
way too busy right now.
As soon as I find some time I’ll rework that change. Might take a week or two.
so long...
Andreas Gerler
> On Jan 27, 2023, at 2:11 PM, Ihor Radchenko wrote:
>
> Andreas Gerler writes:
>
>> +(defcustom org-babel-eval-error-display-notify nil
>> + "Display
Andreas Gerler writes:
> +(defcustom org-babel-eval-error-display-notify nil
> + "Display org-babel-eval-errors always or only if exit code is not 0."
This docstring is confusing. What will happen if the value is nil?
non-nil? I cannot answer these questions by reading the docstring.
Also,
Ping -- I don't think anyone else has replied / reviewed this patch yet,
unless it has happened in a different thread.
Best,
RY
Andreas Gerler writes:
> [[PGP Signed Part:Undecided]]
>
> [2. text/x-patch; 0001-lisp-ob-eval.el-Display-error-fix.patch]...
>
>
>
> Hi Ruijie,
>
> thanks for
0001-lisp-ob-eval.el-Display-error-fix.patch
Description: Binary data
Hi Ruijie,
thanks for asking.
I combined them now and tested again all variants.
Andreas
> On 7. Jan 2023, at 22:33, Ruijie Yu via General discussions about Org-mode.
> wrote:
>
>
> Hi Andreas,
>
> -
Hi Andreas,
-(display-buffer buf))
+(if org-babel-eval-error-display-notify
+(display-buffer buf)
+ (if (or (not (numberp exit-code))
+ (> exit-code 0))
+ (display-buffer buf
Quick question, does it help or hurt readability if we change this
0001-lisp-ob-eval.el-Display-error-fix.patch
Description: Binary data
Dear all,
since commit
f7b16402e6a694d592210f766544f6114056b4b0
every sql code block is displaying the *Org-Babel Error Output* for me due to
warning messages from the database.
I added a check to display the buffer only
