Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-10 Thread Alan Schmitt
On 2015-09-09 17:59, Dmitri Makarov writes: > This is refactored patch that uses org-mac-paste-applescript-links LGTM (with a tiny caveat that I can fix: the first line of the commit message should not end with a dot). Nicolas, can I push this? Thanks, Alan --

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-10 Thread Nicolas Goaziou
Hello, Dmitri Makarov writes: > If you haven't pushed the patch yet, here is attached an updated > patch, with a correction in the commit message, and a minor correction > in one of the comments. Thank you. Some comments follow. > > On Thu, Sep 10, 2015 at 11:28

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-10 Thread Dmitri Makarov
Hello Alan, If you haven't pushed the patch yet, here is attached an updated patch, with a correction in the commit message, and a minor correction in one of the comments. Regards, Dmitri On Thu, Sep 10, 2015 at 11:28 AM, Alan Schmitt wrote: > On 2015-09-09

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-10 Thread Dmitri Makarov
Attached is the patch with requested corrections. I hope now this small patch is sufficiently well commented. Regards, Dmitri On Thu, Sep 10, 2015 at 11:57 AM, Nicolas Goaziou wrote: > Hello, > > Dmitri Makarov writes: > >> If you haven't

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-10 Thread Alan Schmitt
On 2015-09-10 12:26, Dmitri Makarov writes: > Attached is the patch with requested corrections. I hope now this > small patch is sufficiently well commented. Applied and pushed. Thanks! Alan -- OpenPGP Key ID : 040D0A3B4ED2E5C7 Last week athmospheric CO₂ average

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-09 Thread Alan Schmitt
Hello, On 2015-09-09 12:42, Dmitri Makarov writes: > This is my second attempt to submit a patch that enables grabbing > links from Adobe Acrobat Pro. I do not have Acrobat to test, but I have a small comment. > +(defun org-mac-acrobat-get-page () > +

[O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-09 Thread Dmitri Makarov
This is my second attempt to submit a patch that enables grabbing links from Adobe Acrobat Pro. Regards, Dmitri From b9feb9b3ebd618d0fc8e82dc266d62e8252775ed Mon Sep 17 00:00:00 2001 From: Dmitri Makarov Date: Wed, 24 Jun 2015 12:22:44 +0200 Subject: [PATCH]

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-09-09 Thread Dmitri Makarov
This is refactored patch that uses org-mac-paste-applescript-links Regards, Dmitri On Wed, Sep 9, 2015 at 4:11 PM, Alan Schmitt wrote: > Hello, > > On 2015-09-09 12:42, Dmitri Makarov writes: > >> This is my second attempt to

[O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.

2015-06-24 Thread Dmitri Makarov
https://github.com/dmakarov/org-mode/commit/b9feb9b3ebd618d0fc8e82dc266d62e8252775ed g...@github.com:dmakarov/org-mode.git * contrib/lisp/org-mac-link.el: Add new link type acrobat to grab links to documents open in Adobe Acrobat application. Regards, Dmitri