Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-25 Thread Valentin Wüstholz
On Thu, Aug 18, 2011 at 6:44 PM, Bastien wrote: > Valentin Wüstholz writes: > >> I was thinking of the the 80 character line limit for both code and >> commit messages, which doesn't seem to be in there. It might also make >> sense to link to some style guide for Emacs Lisp (e.g., >> http://www.g

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-18 Thread Bastien
Hi Valentin, Valentin Wüstholz writes: > I was thinking of the the 80 character line limit for both code and > commit messages, which doesn't seem to be in there. It might also make > sense to link to some style guide for Emacs Lisp (e.g., > http://www.gnu.org/software/emacs/elisp/html_node/Codi

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-17 Thread Valentin Wüstholz
Hi Bastien. On Wed, Aug 17, 2011 at 11:40 AM, Bastien wrote: >> Maybe that's something that could be added to the >> corresponding worg page (http://orgmode.org/worg/org-contribute.html). > > This is already described here: > >  http://orgmode.org/worg/org-contribute.html#sec-5 > > Feel free to

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-17 Thread Bastien
Hi Valentin, Valentin Wüstholz writes: > thanks for the comments. I'll certainly keep that in mind for future > patches. Thanks :) > Maybe that's something that could be added to the > corresponding worg page (http://orgmode.org/worg/org-contribute.html). This is already described here: h

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-16 Thread Valentin Wüstholz
Hi Bastien, thanks for the comments. I'll certainly keep that in mind for future patches. Maybe that's something that could be added to the corresponding worg page (http://orgmode.org/worg/org-contribute.html). Best regards, Valentin On Tue, Aug 16, 2011 at 9:18 PM, Bastien wrote: > Hi Valent

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-16 Thread Bastien
Hi Valentin, Valentin Wüstholz writes: >> Meanwhile, could you please reformat a bit your patch (no more than 80 >> columns, no parents on their own line), add a commit message followed >> by TINYCHANGE (unless you have signed FSF papers already) and use git >> format-patch for the output? > > S

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-16 Thread Bastien
Hi Nicolas, Nicolas Goaziou writes: > Valentin Wüstholz writes: > >> Sure. I have attached the output. > > Thank you. I have applied it to master. Thanks for taking care of applying this patch. -- Bastien

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-10 Thread Nicolas Goaziou
Hello, Valentin Wüstholz writes: > Sure. I have attached the output. Thank you. I have applied it to master. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-09 Thread Valentin Wüstholz
Hi Nicolas. On Tue, Aug 9, 2011 at 3:21 PM, Nicolas Goaziou wrote: >> I would love to hear how other people feel about this. > > Same here. I don't use such blocks very often after all. > > Meanwhile, could you please reformat a bit your patch (no more than 80 > columns, no parents on their own

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-09 Thread Valentin Wüstholz
Hi Nicolas. On Tue, Aug 9, 2011 at 11:18 AM, Nicolas Goaziou wrote: > Hello, > > Valentin Wüstholz writes: > >> Sure. At least four use cases come to my mind for this: (a) literal >> console output, (b) blocks of pseudo code (can't really use SRC blocks >> since there is no actual language for

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-09 Thread Nicolas Goaziou
Valentin Wüstholz writes: > At least that's my understanding of what /literal/ examples should > give you. Besides, you don't need to fix each line separately: simply > removing the indentation and auto-indenting the block will get you the > desired results. Ah, true. I hadn't thought about that

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-09 Thread Nicolas Goaziou
Hello, Valentin Wüstholz writes: > Sure. At least four use cases come to my mind for this: (a) literal > console output, (b) blocks of pseudo code (can't really use SRC blocks > since there is no actual language for this), (c) blocks of source code > in experimental or little known programming l

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-08 Thread Valentin Wüstholz
Hi Nicolas, thanks for the quick response. On Tue, Aug 9, 2011 at 12:33 AM, Nicolas Goaziou wrote: > Valentin Wüstholz writes: > >> Colons are great for short snippets. However, blocks are far more >> convenient for longer passages. > > That's certainly true, but I fail to see an use case for

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-08 Thread Nicolas Goaziou
Valentin Wüstholz writes: > Colons are great for short snippets. However, blocks are far more > convenient for longer passages. That's certainly true, but I fail to see an use case for such long passages. May I know what you do have in mind? > What potential hassle were you thinking of? Being

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-08 Thread Valentin Wüstholz
Hi Nicolas. On Mon, Aug 8, 2011 at 10:40 PM, Nicolas Goaziou wrote: > Hello, > > Valentin Wüstholz writes: > >> lines in example blocks are currently indented like the surrounding >> begin and end delimiters. ¨This works fine unless, you want to indent >> some lines manually; > > You

Re: [O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-08 Thread Nicolas Goaziou
Hello, Valentin Wüstholz writes: > lines in example blocks are currently indented like the surrounding > begin and end delimiters. ¨This works fine unless, you want to indent > some lines manually; You may use colons instead. They are meant for this task. I.e.: : some text : ^ > in this c

[O] [PATCH] org.el: Preserve indentation of manually indented lines in example blocks.

2011-08-08 Thread Valentin Wüstholz
Hi, lines in example blocks are currently indented like the surrounding begin and end delimiters. ¨This works fine unless, you want to indent some lines manually; in this case, auto-indenting the buffer reverts the manual indentation. This patch should prevent this from happening. Best regards,