Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-09-19 Thread Nicolas Goaziou
Hello, "N. Raghavendra" writes: > Subject: [PATCH] ox-html.el: Partially revert d5bbf36553 Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-09-19 Thread N. Raghavendra
At 2017-09-19T06:24:37+05:30, N. Raghavendra wrote: > Attached is a patch that implements these changes. Attached is a simplified patch with an unnecessary conditional removed. Raghu. -- N. Raghavendra , http://www.retrotexts.net/ Harish-Chandra Research Institute,

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-09-18 Thread N. Raghavendra
At 2017-06-14T23:02:12+05:30, N. Raghavendra wrote: > At 2017-06-12T12:45:13-04:00, Matt Price wrote: > >> As it stands right now, both changes (addition of `data-editor-type` >> attribute and moving the language name class from `pre` to `code`) >> are necessary to make klipse work > > I tried

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-14 Thread N. Raghavendra
At 2017-06-12T12:45:13-04:00, Matt Price wrote: > As it stands right now, both changes (addition of `data-editor-type` > attribute and moving the language name class from `pre` to `code`) are > necessary to make klipse work I tried with some examples, and the editing facility of klipse seems to

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-12 Thread Matt Price
Hi, You raise two important-seeming points about my patch: 1) a feature (display of language on hover) is removed by the patch 2) the patch also breaks XHTML validation That patch was submitted to add support for live code examples in exported HTML (using the klipse.js library). As it stands

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-08 Thread Matt Price
Thanks for CCing me, Nicholas. I'll take a look at this in the next 24 hours -- have been away form my computer all day and have lots of stuff to respond to! matt On 06/08/2017 03:24 PM, Nicolas Goaziou wrote: > Hello, > > "N. Raghavendra" writes: > >> Continuing the

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-08 Thread N. Raghavendra
At 2017-06-08T21:24:31+02:00, Nicolas Goaziou wrote: > I'm Cc'ing Matt Price, who introduced klipse feature, for some > insight. Thanks for the reply, and for the information. I'll wait for Matt Price's response. > You posted the patch only two days ago. I hope you understand a "bump" > may be

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-08 Thread Nicolas Goaziou
Hello, "N. Raghavendra" writes: > Continuing the soliloquy, I was wondering if any of the maintainers have > seen this patch, I saw it. > and the bug that it addresses. That is above my pay-grade. I'm Cc'ing Matt Price, who introduced klipse feature, for some insight.

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-08 Thread N. Raghavendra
At 2017-06-06T20:50:21+05:30, N. Raghavendra wrote: > CSS rules like > > pre.src-awk:before { content: 'Awk'; } > > in `org-html-style-default' don't work in the current Org version, > because the class attribute has been moved from the `pre' element to a > `code' child of that element. As a

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-06 Thread N. Raghavendra
At 2017-06-06T20:50:21+05:30, N. Raghavendra wrote: > CSS rules like > > pre.src-awk:before { content: 'Awk'; } > > in `org-html-style-default' don't work in the current Org version, > because the class attribute has been moved from the `pre' element to a > `code' child of that element. It

[O] [PATCH] ox-html.el: Fix display of language indicators for source blocks

2017-06-06 Thread N. Raghavendra
CSS rules like pre.src-awk:before { content: 'Awk'; } in `org-html-style-default' don't work in the current Org version, because the class attribute has been moved from the `pre' element to a `code' child of that element. As a result, the name of the language isn't dipslayed when hovering over