Re: [O] [PATCH] ox-latex: provide width and height options for images

2013-03-06 Thread Nicolas Goaziou
Hello, aarone...@gmail.com writes: This should now be handled. The new patch will follow this email. In related news, I have completed the FSF copyright assignment process, so the patch can be merged whenever it is deemed ready. Your patch looks good. I have pushed it with minor stylistic

Re: [O] [PATCH] ox-latex: provide width and height options for images

2013-03-05 Thread aaronecay
2013ko otsailak 27an, Nicolas Goaziou-ek idatzi zuen: Thank you for your patch. Here are a few comments. Thank you for the comments! I think the patch is simpler and better thanks to them. These are implemented with \resizebox, and thus are uniform across different types of image inclusion

Re: [O] [PATCH] ox-latex: provide width and height options for images

2013-02-27 Thread Nicolas Goaziou
Hello, Aaron Ecay aarone...@gmail.com writes: Thank you for your patch. Here are a few comments. These are implemented with \resizebox, and thus are uniform across different types of image inclusion (\includegraphics, \input of tikz images). This differs from the older way of using width

Re: [O] [PATCH] ox-latex: provide width and height options for images

2013-02-27 Thread Achim Gratz
Rasmus writes: For tikz figures resizing should be done via the scale argument to preserve the right font sizes. If people want to resize a tikz figure they should do so in their tikz code. No, that doesn't work for many tikz pictures; in particular it doesn't work for tikz files produced by

[O] [PATCH] ox-latex: provide width and height options for images

2013-02-26 Thread Aaron Ecay
These are implemented with \resizebox, and thus are uniform across different types of image inclusion (\includegraphics, \input of tikz images). This differs from the older way of using width and height optional args to \includegraphics. Thus, the default value for

Re: [O] [PATCH] ox-latex: provide width and height options for images

2013-02-26 Thread Rasmus
Aaron Ecay aarone...@gmail.com writes: WDYT? [...] These are implemented with \resizebox, and thus are uniform across different types of image inclusion (\includegraphics, \input of tikz images). This differs from the older way of using width and height optional args to \includegraphics. I

Re: [O] [PATCH] ox-latex: provide width and height options for images

2013-02-26 Thread Aaron Ecay
2013ko otsailak 26an, Rasmus-ek idatzi zuen: I don't like it. Why would we use resizebox rather than the the arguments in includegraphics for pictures? Because it achieves the same result, but allows the operation to be more uniform from the org side of things. A \resizebox is something that