Re: [O] [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument

2019-03-15 Thread Sebastian Miele
Nicolas Goaziou writes: > However, from experience, having to fix a regression when your only > indication comes from a test you do not fully understand is a pain. To > see what I mean, have a look at tests in > "test-ob-header-arg-defaults.el" and imagine one of them fails… After looking

Re: [O] [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument

2019-03-14 Thread Nicolas Goaziou
Sebastian Miele writes: > After some initial tooth-grinding, My intent is not to be negative. I do understand that writing tests takes time. However, from experience, having to fix a regression when your only indication comes from a test you do not fully understand is a pain. To see what I

Re: [O] [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument

2019-03-14 Thread Sebastian Miele
Nicolas Goaziou writes: > [...] > > > However, your tests are very convoluted. It is better than no test, but > if, unfortunately, one of them fail in some distant future, it may take > more time understanding what happens in the test than actually fixing > the bug. > > Would you mind rewriting

Re: [O] [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument

2019-03-14 Thread Nicolas Goaziou
Hello, Sebastian Miele writes: > * testing/lisp/test-ob-emacs-lisp.el > (test-ob-emacs-lisp-dynamic-lexical-text, > test-ob-emacs-lisp-dynamic-lexical-expr, > ob-emacs-lisp/dynamic-lexical-execute, > ob-emacs-lisp/dynamic-lexical-edit): Add tests that check the > correct handling of

[O] [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument

2019-03-14 Thread Sebastian Miele
* testing/lisp/test-ob-emacs-lisp.el (test-ob-emacs-lisp-dynamic-lexical-text, test-ob-emacs-lisp-dynamic-lexical-expr, ob-emacs-lisp/dynamic-lexical-execute, ob-emacs-lisp/dynamic-lexical-edit): Add tests that check the correct handling of the :lexical header argument when executing