Re: [O] [RFC] Replace lambda functions added to org-mode-hook with named funcs

2019-10-06 Thread stardiviner
I propose one vote for this too. This give user better understanding. Some times I check out the variable org-mode-hook's value for troubleshooting, the meaningful function names can help me read quickly. Phil Sainty writes: > On Fri, Oct 5, 2018, 6:42 AM Nicolas Goaziou wrote: >> Kaushal Mod

Re: [O] [RFC] Replace lambda functions added to org-mode-hook with named funcs

2019-09-30 Thread Phil Sainty
On Fri, Oct 5, 2018, 6:42 AM Nicolas Goaziou wrote: Kaushal Modi writes: > I propose to replace such lamba functions with named functions. > Here's an example of diff on maint branch, after making one such change: > > -;; Remove overlays when changing major mode > -(add-hook 'org-mode-hook > -

Re: [O] [RFC] Replace lambda functions added to org-mode-hook with named funcs

2018-10-06 Thread Kaushal Modi
On Fri, Oct 5, 2018, 6:42 AM Nicolas Goaziou wrote: > > If that's a function added to `org-mode-hook', it is not useful to add > "on major mode change". > Yes, I'll remove that one hook addition. > If there is no objection to this, I can fix this everywhere in maint, > > and then merge that int

Re: [O] [RFC] Replace lambda functions added to org-mode-hook with named funcs

2018-10-05 Thread Nicolas Goaziou
Hello, Kaushal Modi writes: > Going down the rabbit hole, I discovered many places in Org source > where lambdas were added to org-mode-hook. > > I propose to replace such lamba functions with named functions. > Here's an example of diff on maint branch, after making one such change: > > = >

[O] [RFC] Replace lambda functions added to org-mode-hook with named funcs

2018-10-04 Thread Kaushal Modi
Hello, Yesterday, while helping someone out[0] with why their custom functions added to org-mode-hook didn't work, I asked them to reveal the value of org-mode-hook, and they presented this as the default value of org-mode-hook once Org was loaded: = '(org-mode-hook (quote (#[0 "\300\3