Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-12-18 Thread David Maus
Hi Jeff, At Wed, 14 Dec 2011 20:30:06 -0500, Jeff Horn wrote: > > On Sun, Nov 13, 2011 at 12:32, Nick Dokos wrote: > > Good enough for me. I don't remember whether you supplied a patch for this > > (sorry, no time to check atm) but if you did, maybe the OP can test it and > > make sure that it do

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-12-14 Thread Jeff Horn
On Sun, Nov 13, 2011 at 12:32, Nick Dokos wrote: > Good enough for me. I don't remember whether you supplied a patch for this > (sorry, no time to check atm) but if you did, maybe the OP can test it and > make sure that it does what he expected (or maybe he's done that already - > I can't remember

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-13 Thread Nick Dokos
David Maus wrote: > First sorry for the late response, some pressing family matters kept > me busy last week. > > At Sun, 06 Nov 2011 17:29:06 -0500, > Nick Dokos wrote: > > No, I mean the handling in org-insert-link itself: > > > > line 9048 says > > > > (setq link (org-extract-

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-13 Thread David Maus
First sorry for the late response, some pressing family matters kept me busy last week. At Sun, 06 Nov 2011 17:29:06 -0500, Nick Dokos wrote: > No, I mean the handling in org-insert-link itself: > > line 9048 says > > (setq link (org-extract-attributes > (org-link-u

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-06 Thread Nick Dokos
David Maus wrote: > > What a mess - thanks for the clear explanation. Be that as it may, the > > treatment of links in org-insert-link is inconsistent: in one case, the > > link is unescaped once, in the other not at all. > > Hm. I still don't see an inconsistency here: `org-insert-link' reads a

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-06 Thread David Maus
At Sat, 05 Nov 2011 11:38:56 -0400, Nick Dokos wrote: > > David Maus wrote: > > > At Fri, 04 Nov 2011 14:25:42 -0400, > > Nick Dokos wrote: > > > > > > Nick Dokos wrote: > > > > > > > It probably does, but that's probably not the best place to do it: it > > > > might be > > > > better to do it i

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-05 Thread Nick Dokos
David Maus wrote: > At Fri, 04 Nov 2011 14:25:42 -0400, > Nick Dokos wrote: > > > > Nick Dokos wrote: > > > > > It probably does, but that's probably not the best place to do it: it > > > might be > > > better to do it in the (setq link on line 9090 or thereabouts. Otherwise, > > > in > > > th

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-05 Thread David Maus
At Fri, 04 Nov 2011 14:25:42 -0400, Nick Dokos wrote: > > Nick Dokos wrote: > > > It probably does, but that's probably not the best place to do it: it might > > be > > better to do it in the (setq link on line 9090 or thereabouts. Otherwise, in > > the *other* case (editing the link at point), w

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-04 Thread Nick Dokos
Nick Dokos wrote: > It probably does, but that's probably not the best place to do it: it might be > better to do it in the (setq link on line 9090 or thereabouts. Otherwise, in > the *other* case (editing the link at point), we'll end up unescaping twice: > probably not a problem, since unescapi

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-04 Thread Nick Dokos
Brian Wightman wrote: > On Fri, Nov 4, 2011 at 11:52 AM, Nick Dokos wrote: > > probably not a problem, since unescaping should be idempotent (in contrast > > to > > escaping ;-) ) but why do it twice? > > I am not sure I am reading this correctly - I am reading this as > unescaping a url-encod

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-04 Thread Nick Dokos
Nick Dokos wrote: > Jeff Horn wrote: > > > I just pulled the latest org-mode. The problem persists for me, even > > though it was reported as fixed in a previous thread. Can anyone > > replicate with the latest org? > > > > Org-mode version 7.7 (release_7.7.513.g2a5877) > > GNU Emacs 24.0.50.3

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-04 Thread Nick Dokos
Jeff Horn wrote: > I just pulled the latest org-mode. The problem persists for me, even > though it was reported as fixed in a previous thread. Can anyone > replicate with the latest org? > > Org-mode version 7.7 (release_7.7.513.g2a5877) > GNU Emacs 24.0.50.3 (i386-apple-darwin9.8.0, NS apple-a

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-04 Thread Nick Dokos
Jeff Horn wrote: > I just pulled the latest org-mode. The problem persists for me, even > though it was reported as fixed in a previous thread. Can anyone > replicate with the latest org? > Yes - just pulled the same version as below - I see the same thing you see. Nick > Org-mode version 7.7

Re: [O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-04 Thread Jeff Horn
I just pulled the latest org-mode. The problem persists for me, even though it was reported as fixed in a previous thread. Can anyone replicate with the latest org? Org-mode version 7.7 (release_7.7.513.g2a5877) GNU Emacs 24.0.50.3 (i386-apple-darwin9.8.0, NS apple-appkit-949.54) of 2011-08-10 on

[O] [bug] Org link dialog escapes URL spaces incorrectly

2011-11-01 Thread Jeff Horn
Org-mode version 7.7 (release_7.7.404.ga17c.dirty) GNU Emacs 24.0.50.3 (i386-apple-darwin9.8.0, NS apple-appkit-949.54) of 2011-08-10 on braeburn.aquamacs.org - Aquamacs Distribution 3.xdev Inserting a link through the link dialog doesn't escape URLs with spaces properly. Where a space is '%20', o