Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-09-13 Thread Rasmus
Hi, I have been busy. So was the consensus to fix this using "old-style" advice or can I use nadvice syntax? As Nicolas mentioned, the latter bumps the requirement of master to 24.4 instead of 24.3, but it's much nicer to write, read and debug. BTW: I think recently AUCTeX made changes that req

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-31 Thread Rasmus
Hi, >> But are the slowdowns associated with outline.el functions anything that >> will realistically be felt in normal usage? > > They are noticeable under certain circumstances. I implemented > `org-show-children' because `show-children' was /reported/ as slow. OK. > Generally speaking, outlin

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-30 Thread Nicolas Goaziou
Rasmus writes: > But are the slowdowns associated with outline.el functions anything that > will realistically be felt in normal usage? They are noticeable under certain circumstances. I implemented `org-show-children' because `show-children' was /reported/ as slow. Generally speaking, outline

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-30 Thread Rasmus
Hi, >> Do you mean to change org-cycle-internal-local as in this patch or to make >> a hook around it? > > The former. However, a hook is OK too, but I couldn't find an acceptable > candidate. > > Funnily, `org-end-of-subtree' does the exact opposite: it hard-codes > behaviour and switch to the sl

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-30 Thread Nicolas Goaziou
Rasmus writes: > Do you mean to change org-cycle-internal-local as in this patch or to make > a hook around it? The former. However, a hook is OK too, but I couldn't find an acceptable candidate. Funnily, `org-end-of-subtree' does the exact opposite: it hard-codes behaviour and switch to the sl

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-30 Thread Rasmus
Hi, Nicolas Goaziou writes: >> I tried to add show-children, and NOT have org-show-children in the setup >> but alas it doesn't change the situation. But anyway it's called through >> `org-cycle', in my use-case at least. This in turn rely on at least >> org-cycle-internal-local which in turn

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-30 Thread Nicolas Goaziou
Rasmus writes: > I tried to add show-children, and NOT have org-show-children in the setup > but alas it doesn't change the situation. But anyway it's called through > `org-cycle', in my use-case at least. This in turn rely on at least > org-cycle-internal-local which in turn uses org-show-chil

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-29 Thread Rasmus
Nicolas Goaziou writes: > Rasmus writes: > >> I tried to recompile with that line commented out but it doesn't make a >> difference. I also tried to remove that defun from orgstruct-setup, but >> that also didn't make change anything. > > What if you replace the defun with `show-children' in `o

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-16 Thread Rasmus
Nicolas Goaziou writes: > Rasmus writes: > >> Great. The bad commit seems to be: >> >> commit 898cfbcac0560d1d742d939a62c5a8253fe9b66f >> Author: Nicolas Goaziou >> Date: Mon Aug 10 13:34:07 2015 +0200 >> >> Implement faster `show-children' function >> >> * lisp/o

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-14 Thread Nicolas Goaziou
Rasmus writes: > Great. The bad commit seems to be: > > commit 898cfbcac0560d1d742d939a62c5a8253fe9b66f > Author: Nicolas Goaziou > Date: Mon Aug 10 13:34:07 2015 +0200 > > Implement faster `show-children' function > > * lisp/org.el (org-show-children): New functio

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-11 Thread Nicolas Goaziou
Rasmus writes: > I tried to recompile with that line commented out but it doesn't make a > difference. I also tried to remove that defun from orgstruct-setup, but > that also didn't make change anything. What if you replace the defun with `show-children' in `orgstruct-setup' instead of simply r

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-11 Thread Rasmus
Nicolas Goaziou writes: > Rasmus writes: > >> I tried to recompile with that line commented out but it doesn't make a >> difference. I also tried to remove that defun from orgstruct-setup, but >> that also didn't make change anything. > > Hmm. Odd. >> >> If there is a way to get the buffer-stri

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-11 Thread Nicolas Goaziou
Rasmus writes: > I tried to recompile with that line commented out but it doesn't make a > difference. I also tried to remove that defun from orgstruct-setup, but > that also didn't make change anything. Hmm. Odd. > > If there is a way to get the buffer-string for what is actually displayed > i

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-11 Thread Rasmus
Hi, >> In org 8.3 orgstruct-mode and org-cycle is no longer working as >> expected. > > I assume you mean development version (i.e., Org 8.4), not Org 8.3 > (maint). I pull from master, but (org-version) gives "Org-mode version 8.3.1 (release_8.3.1-47-g3e7aa3 @ /usr/share/emacs/site-lisp/org/)".

Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-11 Thread Nicolas Goaziou
Hello, Rasmus writes: > In org 8.3 orgstruct-mode and org-cycle is no longer working as > expected. I assume you mean development version (i.e., Org 8.4), not Org 8.3 (maint). > With org 8.3+, when I use org-cycle on a headline, e.g. ";;* Org", the > display is no longer consistent with outlin

[O] [bug] org-cycle changed behavior in orgstruct-mode

2015-08-11 Thread Rasmus
Hi, In org 8.3 orgstruct-mode and org-cycle is no longer working as expected. In my init file I have, ;; Local Variables: ;; outline-regexp: ";;\\*+\\|\\`" ;; orgstruct-heading-prefix-regexp: ";;\\*+\\|\\`" ;; eval: (when after-init-time (orgstruct-mode) (org-global-cycle 3))