Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-31 Thread Nicolas Richard
Thorsten Jolitz writes: > Nicolas Richard writes: >> Thanks for the URL. The description looks great but why not patch >> outline.el instead of making it an external library ? Is there an >> incompatibility ? > > Well, outshine merges quite old extension libraries for outline like > outline-magic

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-30 Thread Thorsten Jolitz
Nicolas Richard writes: > Thorsten Jolitz writes: > >> Nicolas Richard writes: >> >>> I think backporting narrow-to-subtree to outline is a very good move. >>> (Other things would be cool in outline, e.g. why does it not have >>> outline-cycle ? But that's a longer story, I guess.) >> >> It doe

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-30 Thread Nicolas Richard
Thorsten Jolitz writes: > Nicolas Richard writes: > >> I think backporting narrow-to-subtree to outline is a very good move. >> (Other things would be cool in outline, e.g. why does it not have >> outline-cycle ? But that's a longer story, I guess.) > > It does via outline-magic.el (now "maintai

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-30 Thread Thorsten Jolitz
Nicolas Richard writes: > I think backporting narrow-to-subtree to outline is a very good move. > (Other things would be cool in outline, e.g. why does it not have > outline-cycle ? But that's a longer story, I guess.) It does via outline-magic.el (now "maintained" by me: https://github.com/tj64

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-30 Thread Nicolas Richard
Hello Bastien, Bastien writes: > I think it's fine to bind `org-narrow-to-subtree' in narrow-map. > It's basically to enjoy the `C-x n prefix', which is natural here. I agree, but it is not compatible with keeping it only for org-mode buffers while using something else for some other modes, whic

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-28 Thread Bastien
Hi Nicolas, Nicolas Richard writes: > But now that I think about it, org mode simply should avoid narrow-map > completely : users (me included) won't randomly try to run > org-narrow-to-subtree outside of org buffers (and those who do deserve a > bad error message) but they might want to give "C

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-28 Thread Bastien
Hi Nicolas, Nicolas Richard writes: > org-narrow-to-subtree is very nice, and I now have C-x n s hard-wired > into my fingers, but it doesn't work when outline-regexp is too > different from org-outline-regexp in Outline-but-non-Org mode buffers. > > It looked pretty easy to fix, so here is my s

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-25 Thread Nicolas Goaziou
Nicolas Richard writes: > But now that I think about it, org mode simply should avoid narrow-map > completely : users (me included) won't randomly try to run > org-narrow-to-subtree outside of org buffers (and those who do deserve a > bad error message) but they might want to give "C-x n s" a try

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-24 Thread Thorsten Jolitz
Nicolas Richard writes: > But now that I think about it, org mode simply should avoid narrow-map > completely : users (me included) won't randomly try to run > org-narrow-to-subtree outside of org buffers (and those who do deserve a > bad error message) but they might want to give "C-x n s" a try

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-24 Thread Nicolas Richard
Nicolas Goaziou writes: > Nicolas Richard writes: > >> I think it should try to have at least a sensible error message. The >> current "Before first headline" isn't quite clear (my patch doesn't >> address this, btw). > > "Not in an Org mode buffer" could be better indeed. > > Anyway, this kind

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-24 Thread Nicolas Goaziou
Nicolas Richard writes: > I think it should try to have at least a sensible error message. The > current "Before first headline" isn't quite clear (my patch doesn't > address this, btw). "Not in an Org mode buffer" could be better indeed. Anyway, this kind of change (including compatibility wit

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-24 Thread Nicolas Richard
Nicolas Goaziou writes: > `org-narrow-to-subtree' is an Org function. I don't think it should > bother about non Org mode buffers. It's an Org function that grafts itself to narrow-map, which is globally available. I think it should try to have at least a sensible error message. The current "Bef

Re: [O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-24 Thread Nicolas Goaziou
Hello, Nicolas Richard writes: > org-narrow-to-subtree is very nice, and I now have C-x n s hard-wired > into my fingers, but it doesn't work when outline-regexp is too > different from org-outline-regexp in Outline-but-non-Org mode buffers. `org-narrow-to-subtree' is an Org function. I don't t

[O] Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]

2014-07-22 Thread Nicolas Richard
Hello all, org-narrow-to-subtree is very nice, and I now have C-x n s hard-wired into my fingers, but it doesn't work when outline-regexp is too different from org-outline-regexp in Outline-but-non-Org mode buffers. It looked pretty easy to fix, so here is my suggestion, below. It should be rathe