Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-22 Thread Aaron Ecay
Hi Nick, hi Nicolas, 2016ko otsailak 20an, Nick Dokos-ek idatzi zuen: >> IMO, it looks good. You might as well push it and wait for more >> feedback, if needed. >> >> Regards, > > I did some testing as well and it seems to work. Thanks for the feedback. Pushed to master. -- Aaron Ecay

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-20 Thread Nick Dokos
Nicolas Goaziou writes: > Hello, > > Aaron Ecay writes: > >> I’ve tested, and remote execution seems to work (when tramp works for >> me, which it does not do consistently – a known problem) > > Thank you. > > IMO, it looks good. You might as well

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-20 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > I’ve tested, and remote execution seems to work (when tramp works for > me, which it does not do consistently – a known problem) Thank you. IMO, it looks good. You might as well push it and wait for more feedback, if needed. Regards, --

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-14 Thread Aaron Ecay
Hi Nick, 2016ko otsailak 12an, Nick Dokos-ek idatzi zuen: >> AFAICS my patch does not affect the work Michael did. I will test some >> simple remote execution scenarios before I push the patch, just in case. >> > > OK - good! I’ve tested, and remote execution seems to work (when tramp works

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-12 Thread Aaron Ecay
Hi Nick, 2016ko otsailak 11an, Nick Dokos-ek idatzi zuen: > > Not sure if there are tests for remote babel execution, AFAIK no. It would be useful to have these. All the machines I use run Linux and are configured very similarly. Many of the problems in remote execution come from

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-12 Thread Aaron Ecay
Hi Nicolas, 2016ko otsailak 10an, Nicolas Goaziou-ek idatzi zuen: > > Hello, > > Aaron Ecay writes: > >> I’d like to install the attached patch to master, if there are no >> objections. That should resolve your concern as well as cleaning up the >> dead code. > > No

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-12 Thread Nick Dokos
Aaron Ecay writes: > Hi Nick, > > 2016ko otsailak 11an, Nick Dokos-ek idatzi zuen: >> >> Not sure if there are tests for remote babel execution, > > AFAIK no. It would be useful to have these. All the machines I use run > Linux and are configured very similarly. Many of

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-11 Thread Nick Dokos
Aaron Ecay writes: > Hi Gary, > > 2016ko otsailak 8an, Gary Oberbrunner-ek idatzi zuen: >> >> org-babel-execute-src-block has a big unwind-protect that basically eats >> all errors inside it. I don't think it used to do that. > > The unwind-protect exists since 2010, so

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-10 Thread Aaron Ecay
Hi Gary, 2016ko otsailak 8an, Gary Oberbrunner-ek idatzi zuen: > > org-babel-execute-src-block has a big unwind-protect that basically eats > all errors inside it. I don't think it used to do that. The unwind-protect exists since 2010, so you’re probably mistaken about that (depending on your

Re: [O] Errors get suppressed by org-babel-execute-src-block

2016-02-10 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > I’d like to install the attached patch to master, if there are no > objections. That should resolve your concern as well as cleaning up the > dead code. No objection, but... > +(require 'subr-x); For `if-let' ... you are

[O] Errors get suppressed by org-babel-execute-src-block

2016-02-08 Thread Gary Oberbrunner
org-babel-execute-src-block has a big unwind-protect that basically eats all errors inside it. I don't think it used to do that. It makes it hard to debug my sql code since I can't figure out where the actual problem is. In my case, I'm probably returning no result from some query, and ob-sql is