Re: [O] Regression in `org-todo'

2012-04-02 Thread Michael Strey
Hi Moritz Bastien, This bug fix seems not to be complete. At least switching the todo state in repeated tasks and in conjunction with org-checklist didn't work for me as it used to before the last update. PFA a patch that solved the problem for me. ATTENTION: Please check this patch very

Re: [O] Regression in `org-todo'

2012-04-02 Thread Bastien
Hi Michael, Michael Strey mst...@strey.biz writes: This bug fix seems not to be complete. At least switching the todo state in repeated tasks and in conjunction with org-checklist didn't work for me as it used to before the last update. PFA a patch that solved the problem for me. Thanks

Re: [O] Regression in `org-todo'

2012-04-02 Thread Michael Strey
Hi Bastien, On Mon, Apr 02, 2012 at 05:03:04PM +0200, Bastien wrote: ... Please test against latest HEAD and tell me if your problem is still here, it shouldn't. I confirm that the problem is solved. Thank you! It's interesting to see how a bug in a module from the contrib path can cause

Re: [O] Regression in `org-todo'

2012-04-02 Thread Bastien
Hi Michael, Michael Strey mst...@strey.biz writes: It's interesting to see how a bug in a module from the contrib path can cause strange behaviour of org-mode's core functions. Indeed. Perhaps org-checklist.el should be part of core. Opinions? -- Bastien

Re: [O] Regression in `org-todo'

2012-04-02 Thread Nick Dokos
Michael Strey mst...@strey.biz wrote: Hi Bastien, On Mon, Apr 02, 2012 at 05:03:04PM +0200, Bastien wrote: ... Please test against latest HEAD and tell me if your problem is still here, it shouldn't. I confirm that the problem is solved. Thank you! It's interesting to see how a

Re: [O] Regression in `org-todo'

2012-04-02 Thread Nick Dokos
Bastien b...@altern.org wrote: Hi Michael, Michael Strey mst...@strey.biz writes: It's interesting to see how a bug in a module from the contrib path can cause strange behaviour of org-mode's core functions. Indeed. Perhaps org-checklist.el should be part of core. Opinions?

Re: [O] Regression in `org-todo'

2012-04-02 Thread Bastien
Hi Nick, Nick Dokos nicholas.do...@hp.com writes: Michael Strey mst...@strey.biz wrote: Hi Bastien, On Mon, Apr 02, 2012 at 05:03:04PM +0200, Bastien wrote: ... Please test against latest HEAD and tell me if your problem is still here, it shouldn't. I confirm that the problem is

Re: [O] Regression in `org-todo'

2012-04-02 Thread Bernt Hansen
Bastien b...@altern.org writes: If the features provided by org-checklist.el are useful to many people, including them in core seems quite natural. I don't use it myself, I'm just wondering how people do. But I agree with you here that we should not move things into core inconsiderately.

[O] Regression in `org-todo'

2012-04-01 Thread Moritz Ulrich
Commit 6cbf1f417222321a47848a7368427ba8a22fe3a5 renames variable `last-state' to `org-last-state' in org.el. This change isn't reflected in function `org-todo'. That causes the following regression: Toggling a TODO state to DONE on a headline via C-c C-t (`org-todo') results in: Symbol's value as