Re: [O] Warning with latest git pull

2013-02-26 Thread Bastien
Hi Achim, Achim Gratz writes: > The point of having the new macro is to avoid the question about > reverting the file when the file visited by a buffer has been edited > outside Emacs. You can do exactly the same changes (cosmetic or not) > with both macros, but org-unmodified will ask you when

Re: [O] Warning with latest git pull

2013-02-25 Thread Achim Gratz
Bastien writes: > I fixed the comment, thanks. I'm starting to sound like Drew, but the new comment says exactly what the old one did, just the two parts juxtaposed. The point of having the new macro is to avoid the question about reverting the file when the file visited by a buffer has been edit

Re: [O] Warning with latest git pull

2013-02-25 Thread Bastien
Hi Achim, Achim Gratz writes: > We shouldn't define things that don't have an org prefix. Fair enough. (Note that `with-buffer-modified-unmodified', from which org-unmodified was heavily copied, lives in bookmark.el. Perhaps Emacs should put it elsewhere.) > I don't really see why we needed

Re: [O] Warning with latest git pull

2013-02-25 Thread Bastien
Hi Achim, Achim Gratz writes: > I hereby declare that XEmacs compatibility is broken already and he who > wants to have this corrected should bring a working version of ert for > XEmacs. Let's encourage XEmacs users to report bugs and incompatibility. Asking them to write an XEmacs ERT sounds a

Re: [O] Warning with latest git pull

2013-02-24 Thread Achim Gratz
Bastien writes: > There is already this in org-macs.el: > > (when (and (not (fboundp 'with-silent-modifications)) > (or (< emacs-major-version 23) > (and (= emacs-major-version 23) > (< emacs-minor-version 2 > (defmacro with-silent-modifications (&rest

Re: [O] Warning with latest git pull

2013-02-23 Thread Bastien
Hi Achim, Achim Gratz writes: > Bastien writes: >> I hereby declare that I want Org to be fully functional for Emacs 23 >> and older, and I wish Org can be reasonably functional for Emacs <23 >> and XEmacs. > > If I may say so, XEmacs and Emacs up to 23.2 are missing > with-silent-modifications,

Re: [O] Warning with latest git pull

2013-02-23 Thread Achim Gratz
Bastien writes: > I hereby declare that I want Org to be fully functional for Emacs 23 > and older, and I wish Org can be reasonably functional for Emacs <23 > and XEmacs. If I may say so, XEmacs and Emacs up to 23.2 are missing with-silent-modifications, preferring to make them loudly. Compatibi

Re: [O] Warning with latest git pull

2013-02-23 Thread Achim Gratz
Bastien writes: >> No it's there, in gnus/time-date.elc ― maybe your versions are all >> without Gnus? > > Yes, my versions come without Gnus. I directly downloaded them > from xemacs.org (which is completely outdated by the way.) Which means that our compatibility function doesn't provide compa

Re: [O] Warning with latest git pull

2013-02-23 Thread Bastien
Hi Achim, Achim Gratz writes: > Bastien writes: >> And time-to-seconds seems absent -- but it seems absent from >> *any* version of XEmacs I could check (21.4.1, 21.4.9, 21.5.9). > > No it's there, in gnus/time-date.elc — maybe your versions are all > without Gnus? Yes, my versions come without

Re: [O] Warning with latest git pull

2013-02-23 Thread Achim Gratz
Bastien writes: > And time-to-seconds seems absent -- but it seems absent from > *any* version of XEmacs I could check (21.4.1, 21.4.9, 21.5.9). No it's there, in gnus/time-date.elc — maybe your versions are all without Gnus? > So yes, I think it's safe to remove this compat function. Let me kno

Re: [O] Warning with latest git pull

2013-02-23 Thread Bastien
Achim Gratz writes: > Bastien writes: >> Fixed, thanks! > > Uh… no, you switched the wrong function in the second line (which > incidentally indicates that this branch of the conditional never sees > any testing). Fixed in master by using org-float-time. Indeed, thanks for fixing this. > I c

Re: [O] Warning with latest git pull

2013-02-23 Thread Achim Gratz
Bastien writes: > Fixed, thanks! Uh… no, you switched the wrong function in the second line (which incidentally indicates that this branch of the conditional never sees any testing). Fixed in master by using org-float-time. I checked in XEmacs 21.5 and it has float-time, so maybe we wouldn't nee

Re: [O] Warning with latest git pull

2013-02-21 Thread Bastien
Hi Thomas, t...@tsdye.com (Thomas S. Dye) writes: > Here is a warning I don't remember seeing before, posted here in case it > is useful information: > > Compiling /Users/dk/.emacs.d/src/org-mode/lisp/org.el... > > In org-current-time: > org.el:5341:16:Warning: `time-to-seconds' is an obsolete fu

[O] Warning with latest git pull

2013-02-20 Thread Thomas S. Dye
Aloha all, Here is a warning I don't remember seeing before, posted here in case it is useful information: Compiling /Users/dk/.emacs.d/src/org-mode/lisp/org.el... In org-current-time: org.el:5341:16:Warning: `time-to-seconds' is an obsolete function (as of 21.1); use `float-time' instead. o