Daimrod writes:
> In `org-fix-ellipsis-at-bol', the change wasn't
> : (save-excursion (set-window-start (selected-window) (window-start)))
>
> but
> : (save-excursion (set-window-start (selected-window) (point-min)))
>
> which is not a noop.
>
> But it does the wrong thing with isearch.
Yes, it
Bastien writes:
> Nicolas Richard writes:
>
>> Perhaps this isn't the right place to ask, but I wonder how
>> (save-excursion (set-window-start (selected-window) (window-start)))
>> isn't a noop.
>
> Perhaps it is a noop -- The purpose of `org-fix-ellipsis-at-bol'
> is to remove the ellipsis ove
Nicolas Richard writes:
> Perhaps this isn't the right place to ask, but I wonder how
> (save-excursion (set-window-start (selected-window) (window-start)))
> isn't a noop.
Perhaps it is a noop -- The purpose of `org-fix-ellipsis-at-bol'
is to remove the ellipsis overlay that outline-mode may le
Bastien writes:
> I've now fixed this in the maint and master branch of Org's
> repository.
Thanks for looking into it.
Perhaps this isn't the right place to ask, but I wonder how
(save-excursion (set-window-start (selected-window) (window-start)))
isn't a noop.
--
Nico.
Daimrod writes:
> I've read the fix in org-mode and I understand that it was a silly
> question. Please ignore it.
Well, the whole thread gave me the guts to dive in and to find, as
often, how tiny the challenge was -- so thanks for soft-prodding!
--
Bastien
Daimrod writes:
> Daimrod writes:
>
>> Nicolas Richard writes:
>>
>>> Daimrod writes:
> PS: The change about throwing an error when recentering a window
> that does not display the current buffer breaks ~37 tests in Org
> master branch, even with this fix. I need to digg this furt
I've now fixed this in the maint and master branch of Org's
repository.
Firmly waiting for warnings from the CAR and CDR random checks!
--
Bastien
Daimrod writes:
> Nicolas Richard writes:
>
>> Daimrod writes:
PS: The change about throwing an error when recentering a window
that does not display the current buffer breaks ~37 tests in Org
master branch, even with this fix. I need to digg this further.
>>>
>>> Err, what's th
Nicolas Richard writes:
> Daimrod writes:
>>> PS: The change about throwing an error when recentering a window
>>> that does not display the current buffer breaks ~37 tests in Org
>>> master branch, even with this fix. I need to digg this further.
>>
>> Err, what's the rational behind this chan
Daimrod writes:
>> PS: The change about throwing an error when recentering a window
>> that does not display the current buffer breaks ~37 tests in Org
>> master branch, even with this fix. I need to digg this further.
>
> Err, what's the rational behind this change?
It is meant to catch cases w
Stefan Monnier writes:
>> +(defun org-recenter (&optional arg)
>> + "Like `recenter' but ensure that the `current-buffer' is
>> +properly set."
>> + (with-current-buffer (window-buffer)
>> +(recenter arg)))
>
> This doesn't make much sense: in many case (window-buffer) can be
> a buffer c
> +(defun org-recenter (&optional arg)
> + "Like `recenter' but ensure that the `current-buffer' is
> +properly set."
> + (with-current-buffer (window-buffer)
> +(recenter arg)))
This doesn't make much sense: in many case (window-buffer) can be
a buffer completely unrelated to Org.
Bastien writes:
> Nicolas Richard writes:
>
>> David Griffiths writes:
>>> Debugger entered--Lisp error: (error "`recenter'ing a window that does
>>> not display current-buffer.")
>>> recenter((4))
>>> org-overview()
>>
>> So that's a duplicate of #17724. It is fixed in org-mode (upstream) mast
13 matches
Mail list logo
