Re: [O] doc patch: move footnote in external links

2015-02-07 Thread Alan Schmitt
Hello, Here is a new version of the patch, with some tests and a mention in ORG-NEWS. I did not know if I should mention the ORG-NEWS change in the Changelog (I did not). Best, Alan From ea6fb4d8134b1708ae195a342b41de268453b470 Mon Sep 17 00:00:00 2001 From: Alan Schmitt

Re: [O] doc patch: move footnote in external links

2015-02-07 Thread Nicolas Goaziou
Hello, Alan Schmitt alan.schm...@polytechnique.org writes: Here is a new version of the patch, with some tests and a mention in ORG-NEWS. Applied. Thank you. I slightly modified the regexp used for the match (mainly removing unnecessary match groups). I did not know if I should mention the

Re: [O] doc patch: move footnote in external links

2015-01-16 Thread Nicolas Goaziou
Alan Schmitt alan.schm...@polytechnique.org writes: Would the following work as a regexp builder that allows arbitrary space and cookies between each word (making sure there is at least one)? #+begin_src emacs-lisp (defun org-heading-regexp-build (s) (let* ((sp (reverse (org-split-string

Re: [O] doc patch: move footnote in external links

2015-01-14 Thread Alan Schmitt
On 2015-01-12 23:56, Nicolas Goaziou m...@nicolasgoaziou.fr writes: Alan Schmitt alan.schm...@polytechnique.org writes: Should we assume the cookie is at the end of the headline or not? The cookie can be anywhere within the headline text. I'd gladly do this, but to use the

Re: [O] doc patch: move footnote in external links

2015-01-12 Thread Nicolas Goaziou
Alan Schmitt alan.schm...@polytechnique.org writes: I don't understand: won't you need the [33%] bit for an exact search? A statistics cookie is a variable part. If it ever changes, all your links become invalid. It is better to simply ignore them (which is already the case). Also, does

Re: [O] doc patch: move footnote in external links

2015-01-12 Thread Alan Schmitt
On 2015-01-12 09:43, Nicolas Goaziou m...@nicolasgoaziou.fr writes: Alan Schmitt alan.schm...@polytechnique.org writes: I don't understand: won't you need the [33%] bit for an exact search? A statistics cookie is a variable part. If it ever changes, all your links become invalid. It is

Re: [O] doc patch: move footnote in external links

2015-01-12 Thread Nicolas Goaziou
Alan Schmitt alan.schm...@polytechnique.org writes: Should we assume the cookie is at the end of the headline or not? The cookie can be anywhere within the headline text. I'd gladly do this, but to use the `org-element-map' function it seem that I need a parse tree. How can I get it? Or is

Re: [O] doc patch: move footnote in external links

2015-01-11 Thread Nicolas Goaziou
Alan Schmitt alan.schm...@polytechnique.org writes: Here is an updated patch. I can push it or not, depending on the issue below. Thanks. The patch is OK. I have looked at the code and it works *very* differently. I think I can make the `org-export-resolve-fuzzy-link' take spaces into

Re: [O] doc patch: move footnote in external links

2015-01-11 Thread Alan Schmitt
On 2015-01-11 23:00, Nicolas Goaziou m...@nicolasgoaziou.fr writes: Alan Schmitt alan.schm...@polytechnique.org writes: Here is an updated patch. I can push it or not, depending on the issue below. Thanks. The patch is OK. Great. I won't commit it, though, as I prefer to solve the space

Re: [O] doc patch: move footnote in external links

2015-01-10 Thread Alan Schmitt
Sorry for the delay in answering … On 2014-12-20 23:15, Nicolas Goaziou m...@nicolasgoaziou.fr writes: -file:projects.org::*task title@r{heading search in Org file} +file:projects.org::*task title@r{heading search in Org file}@footnote{ +Headline searches always

Re: [O] doc patch: move footnote in external links

2014-12-20 Thread Nicolas Goaziou
Alan Schmitt alan.schm...@polytechnique.org writes: I'm fine with this. Here is the patch extended to take this into account, which is mostly deleting all the code that deals with headline match when `org-link-search-must-match-exact-headline' is nil. Thanks. Some comments follow.

Re: [O] doc patch: move footnote in external links

2014-12-17 Thread Alan Schmitt
On 2014-12-16 22:54, Nicolas Goaziou m...@nicolasgoaziou.fr writes: I think *headline links should assume this variable is non-nil, notwithstanding its real value. Of course, a `query-to-create' value still makes sense. WDYT? I'm fine with this. Here is the patch extended to take this into

Re: [O] doc patch: move footnote in external links

2014-12-16 Thread Alan Schmitt
On 2014-12-13 15:17, Nicolas Goaziou m...@nicolasgoaziou.fr writes: Also, `org-link-search-must-match-exact-headline' docstring could be improved: When nil, the link... doesn't apply to *headline type paths. As I was writing this, I experimented a little. It seems that, for *headline links,

Re: [O] doc patch: move footnote in external links

2014-12-16 Thread Nicolas Goaziou
Alan Schmitt alan.schm...@polytechnique.org writes: On 2014-12-13 15:17, Nicolas Goaziou m...@nicolasgoaziou.fr writes: Also, `org-link-search-must-match-exact-headline' docstring could be improved: When nil, the link... doesn't apply to *headline type paths. As I was writing this, I

Re: [O] doc patch: move footnote in external links

2014-12-13 Thread Alan Schmitt
Hello, On 2014-12-12 18:29, Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Alan Schmitt alan.schm...@polytechnique.org writes: I think the footnote in http://orgmode.org/manual/External-links.html#fn-1 is in the wrong place, it should be on the next line. Here is a patch to fix

Re: [O] doc patch: move footnote in external links

2014-12-13 Thread Nicolas Goaziou
Alan Schmitt alan.schm...@polytechnique.org writes: So you are correct the footnote applies to the text search. However, I think is also applies to the headline search (as suggested by the second line of the snippet). In other words, if I search for file:projects.org::*Headline with

Re: [O] doc patch: move footnote in external links

2014-12-12 Thread Nicolas Goaziou
Hello, Alan Schmitt alan.schm...@polytechnique.org writes: I think the footnote in http://orgmode.org/manual/External-links.html#fn-1 is in the wrong place, it should be on the next line. Here is a patch to fix it. If you prefer I can push it directly myself. I think the current

[O] doc patch: move footnote in external links

2014-12-11 Thread Alan Schmitt
Hello, I think the footnote in http://orgmode.org/manual/External-links.html#fn-1 is in the wrong place, it should be on the next line. Here is a patch to fix it. If you prefer I can push it directly myself. From 4f3ccb3531744fb57d2b26a7844daf54e034e38f Mon Sep 17 00:00:00 2001 From: Alan