Re: [O] ob-lilypond code cleanup

2014-08-20 Thread Achim Gratz
Nicolas Goaziou writes: > FWIW, I think prefix conformance should go to maint. Patch has been split and just the prefix conformance committed to maint in b8bd2147cb. Introduction of defcustom, some code cleanups and associated tests committed to master in 64821bd967. Regards, Achim. -- +<[Q+ M

Re: [O] ob-lilypond code cleanup

2014-08-18 Thread Achim Gratz
Achim Gratz writes: > Thanks for the reminder. In any case, these will need to become > defcustoms as well. Improved patch now with defcustom. I hope I did get that defcustom stuff right, please check. >From 35c3be896c159fcd9fb727b39273750fc0264592 Mon Sep 17 00:00:00 2001 From: Achim Gratz Da

Re: [O] ob-lilypond code cleanup

2014-08-18 Thread Achim Gratz
Nicolas Goaziou writes: > FWIW, I think prefix conformance should go to maint. OK. > Also, you shouldn't use `pcase' as Org preserves compatibility with > Emacs 23. Thanks for the reminder. In any case, these will need to become defcustoms as well. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+

Re: [O] ob-lilypond code cleanup

2014-08-18 Thread Nicolas Goaziou
Hello, Achim Gratz writes: > Triggered by the discussion about it, I've looked at ob-lilypond and > found that it should be cleaned up a bit. The defvars holding the > various commands should really be defcustoms, but I've ran out of time > for now. If anybody thinks this should go to maint pl

[O] ob-lilypond code cleanup

2014-08-17 Thread Achim Gratz
Triggered by the discussion about it, I've looked at ob-lilypond and found that it should be cleaned up a bit. The defvars holding the various commands should really be defcustoms, but I've ran out of time for now. If anybody thinks this should go to maint please say so, otherwise I will commit