Re: [PATCH] Fix window width when line numbers present

Bastien writes: > Hi Ihor, > > Ihor Radchenko writes: > >> The text is mostly clear. However, there is a slight confusion about >> actual current Emacs version vs. planned Emacs version. > > I've rephrased it a bit to focus on "releases", not "versions": > > We aim at keeping the latest

Re: [PATCH] Fix window width when line numbers present

Hi Ihor, Ihor Radchenko writes: > The text is mostly clear. However, there is a slight confusion about > actual current Emacs version vs. planned Emacs version. I've rephrased it a bit to focus on "releases", not "versions": We aim at keeping the latest stable version of Org compatible with

Re: [PATCH] Fix window width when line numbers present

Ihor Radchenko writes: > Bastien writes: > >> Our commitment is that the latest Org version is compatible with the >> last three stable versions of Emacs. >> >> So when Emacs 28 and Org 9.6 are both out, we guarantee that Org is >> compatible with Emacs 28, 27 and 26. >> >> Does that explain

Re: [PATCH] Fix window width when line numbers present

Bastien writes: > Our commitment is that the latest Org version is compatible with the > last three stable versions of Emacs. > > So when Emacs 28 and Org 9.6 are both out, we guarantee that Org is > compatible with Emacs 28, 27 and 26. > > Does that explain it better? > > Let me know if you

Supported Emacs version (was: [PATCH] Fix window width when line numbers present)

Hi Bastien, > Our commitment is that the latest Org version is compatible with the > last three stable versions of Emacs. > > So when Emacs 28 and Org 9.6 are both out, we guarantee that Org is > compatible with Emacs 28, 27 and 26. > > Does that explain it better? Thanks for clarifying. That’s

Re: [PATCH] Fix window width when line numbers present

Hi Timothy, Timothy writes: > So I take this to mean that we will now assume that Org 9.6+ will target Emacs > 29? This seems reasonable to me, but doesn’t quite accord with how I read > . Our commitment is that the latest Org

Re: [PATCH] Fix window width when line numbers present

Hi Bastien, > We can safely assume that Org 9.6 will be released after Emacs 28, so > let’s use `line-number-display-width’ on main. So I take this to mean that we will now assume that Org 9.6+ will target Emacs 29? This seems reasonable to me, but doesn’t quite accord with how I read

Re: [PATCH] Fix window width when line numbers present

Hi Matt, Matt Huszagh writes: > Bastien writes: > >> See https://orgmode.org/worg/org-maintenance.html#emacs-compatibility > > Ah, my mistake. Thanks for pointing me to that. So does this stay on > some other branch until the Emacs official release is at 28? We can safely assume that Org 9.6

Re: [PATCH] Fix window width when line numbers present

Nicolas Goaziou writes: > `line-number-display-width’ is Emacs 26+. So I guess it is unfortunately > not acceptable on main branch. Ooops, thanks for picking that up Nicolas. I see we actually have ┌ │ (if (fboundp 'line-number-display-width) │ (defalias 'org-line-number-display-width

Re: [PATCH] Fix window width when line numbers present

Bastien writes: > See https://orgmode.org/worg/org-maintenance.html#emacs-compatibility Ah, my mistake. Thanks for pointing me to that. So does this stay on some other branch until the Emacs official release is at 28? Matt

Re: [PATCH] Fix window width when line numbers present

Hi Matt, Matt Huszagh writes: > Nicolas Goaziou writes: > >> `line-number-display-width' is Emacs 26+. So I guess it is unfortunately >> not acceptable on main branch. > > Does org-mode not require 26+ even though the Emacs official release is > on 27? See

Re: [PATCH] Fix window width when line numbers present

Nicolas Goaziou writes: > `line-number-display-width' is Emacs 26+. So I guess it is unfortunately > not acceptable on main branch. Does org-mode not require 26+ even though the Emacs official release is on 27? Matt

Re: [PATCH] Fix window width when line numbers present

Hello, Timothy writes: > Thanks for this patch. I wasn’t aware of `line-number-display-width' when I > wrote > that, but it looks like a better fit than my `(or ... 0)' statement. As such, > I’ve > just applied your patch as cd3e138, tweaking the commit message to no longer > go > over the

Re: [PATCH] Fix window width when line numbers present

Oops, I forgot to mark this patch as applied for updates.orgmode.org. Done in this message.

Re: [PATCH] Fix window width when line numbers present

Hi Matt, > This is a very small patch that I believe fixes a previous, incorrect > fix for computing the window text area when line numbers are > present. The previous fix seemed to assume that > display-line-numbers-width being nil meant that this means line numbers > are not present. However,

[PATCH] Fix window width when line numbers present

Hello, This is a very small patch that I believe fixes a previous, incorrect fix for computing the window text area when line numbers are present. The previous fix seemed to assume that display-line-numbers-width being nil meant that this means line numbers are not present. However, it can also