Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-16 Thread James N . V . Cash
Kyle Meyer writes: > Basil L. Contovounesios writes: >> How involved would it be to make org-eldoc work in >> non-"backwards-compatibility" mode? > > I think we can do that, while still supporting Org's minimum Emacs > version, by following python.el. Here's what it does: > ... > > ...

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-15 Thread Kyle Meyer
Basil L. Contovounesios writes: > "James N. V. Cash" writes: > >> This patch makes it continue to work by setting the new variable >> eldoc-documentation-strategy, which puts eldoc in >> "backwards-compatability" mode. > > How involved would it be to make org-eldoc work in >

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-15 Thread Basil L. Contovounesios
wards-compatibility" mode? > From 5c04048c0d1ed3f80c7dd3e6477e12fc8e760675 Mon Sep 17 00:00:00 2001 > From: "James N. V. Cash" > Date: Fri, 10 Jul 2020 11:56:23 -0400 > Subject: [PATCH] Make org-eldoc work with Emacs 28's new eldoc API > > Still using backward-compatability to use th

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-13 Thread James N . V . Cash
Nicolas Goaziou writes: > Do we need another variable for that? Could > org-eldoc-documentation-function catch wrong-number-of-arguments error, > and try another call instead? I believe that the issue is org-eldoc-documentation-function itself is called with the wrong number of arguments; the

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-13 Thread Nicolas Goaziou
Hello, "James N. V. Cash" writes: > In Emacs 28, eldoc now passes in a callback to the documentation > functions. This breaks org-eldoc as it currently is, as > org-eldoc-documentation-function gets called with the wrong number of > arguments. > > This patch makes it continue to work by setting

[PATCH] Make org-eldoc work with Emacs 28

2020-07-12 Thread James N. V. Cash
, which puts eldoc in "backwards-compatability" mode. >From 5c04048c0d1ed3f80c7dd3e6477e12fc8e760675 Mon Sep 17 00:00:00 2001 From: "James N. V. Cash" Date: Fri, 10 Jul 2020 11:56:23 -0400 Subject: [PATCH] Make org-eldoc work with Emacs 28's new eldoc API Still using