Re: [PATCH] New LaTeX code export option: engraved

2022-05-10 Thread Sébastien Miquel
Hi, Timothy writes:  2. `minted` supports a `mathescape` option to render math content     inside code. `fvextra` supports the same option, but maths     characters are escaped by engrave-faces-latex-face-mapper. I’l also take a look at this:) Implemented in engrave-faces-latex, but not

Re: [PATCH] New LaTeX code export option: engraved

2022-05-10 Thread Timothy
Hi Sebastien, >>  1. engrave-faces-generate-preset generates emacs colors such as >>     `:foreground “grey70”` which are not supported by >>     engrave-faces-latex-gen-preamble-line and co. > > I’ll see if I can incorporate this into engrave-faces v0.3.1. Done. >>  2. `minted` supports a

Re: [PATCH] New LaTeX code export option: engraved

2022-05-09 Thread Timothy
Hi Sebastien, > I’m quite exited and impressed to see this alternative to minted, > thank you. That’s great to hear! > I haven’t been able to test your patches to org, but I have tried > engrave-faces.el. Here’s a couple issues I’ve run into. Still helpful, thanks. >  1.

Re: [PATCH] New LaTeX code export option: engraved

2022-05-09 Thread Sébastien Miquel
Hi Timothy, I'm quite exited and impressed to see this alternative to minted, thank you. I haven't been able to test your patches to org, but I have tried engrave-faces.el. Here's a couple issues I've run into.  1. engrave-faces-generate-preset generates emacs colors such as     `:foreground

Re: [PATCH] New LaTeX code export option: engraved

2022-05-07 Thread Daniel Fleischer
Hi Timothy, Very nice set of patches, it looks good. Listings and minted are still workable options and your new engrave library is available. I must admit it's not clear how to customize faces since engrave is a bridge between major modes choices and latex but maybe show one or two examples (say

Re: [PATCH] New LaTeX code export option: engraved

2022-05-07 Thread Timothy
Ooops, a paren error managed to slip in there. Here’s a new set, with a little extra refactoring slipped in. – Timothy >From d231437e2c9f96bf70520d9ddda810a95667fcdd Mon Sep 17 00:00:00 2001 From: TEC Date: Sun, 21 Nov 2021 14:35:34 +0800 Subject: [PATCH 1/7] ox-latex: Refactor

Re: [PATCH] New LaTeX code export option: engraved

2022-05-07 Thread Timothy
Hi Ihor, Find attached an updated patchset, and comments below :) Ihor Radchenko writes: > Maybe “The other two options”? Also, using first/second here is a bit > confusing because: (1) they are actually 3/4 in the above list; (2) > engraved is listed last. Docstring changed. >> +The second

Re: [PATCH] New LaTeX code export option: engraved

2022-05-06 Thread Ihor Radchenko
Timothy writes: Thanks for the updated patch! See some more comments below. > +The first two options provide basic syntax > +highlighting (listings), or none at all (verbatim). > ... > -Alternatively, > +There are two options for more comprehensive fontification. The > +first can be set with,

Re: [PATCH] New LaTeX code export option: engraved

2022-05-06 Thread Ihor Radchenko
Max Nikulin writes: >> +(defun org-latex-src-block--verbatim >> +(src-block info _lang caption caption-above-p _label >> + _num-start _retain-labels _attributes float) > > On the one hand I have no a better suggestion, but on the other hand 10 > arguments is too much for

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Ihor Radchenko
Timothy writes: >> Let me learn a bit about the different code highlighting options in >> order to understand what you offer. > > Sure. If it’s any help, here’s a comparison example I whipped up: > Timothy, could you please not use 0x0 to share not-so-large images? 0x0

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Max Nikulin
On 05/05/2022 22:17, Timothy wrote: Subject: [PATCH 1/4] ox-latex: Refactor `org-latex-src-block' When I was trying to fix an issue with caption, I was not brave enough for massive changes. I do not like the original code of the function. There are some unit tests for exporting of src

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Timothy
> [5. text/x-patch; 0004-ox-latex-Introduce-engraved-code-highlighting.patch]… Ooops, I had some ucommited changes. The correct version is attached. Timothy >From b66c291b1f0d1419742449bcde42bf0c4d620c23 Mon Sep 17 00:00:00 2001 From: TEC Date: Sun, 21 Nov 2021 20:04:12 +0800 Subject: [PATCH]

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Timothy
Hi Daniel, > Hi Timothy, thank you very much for your work! Thanks for the kind words  > Let me learn a bit about the different code highlighting options in > order to understand what you offer. Sure. If it’s any help, here’s a comparison example I whipped up: All

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Timothy
Hi Ihor, > Thanks! > Implementing fontification using Emacs capabilities is certainly a step > in the right direction. LaTeX support for fontification has always been > tricky. I’m glad to hear you’re of a similar mind to me with this. > - I tried to test your patch, and it only works

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Ihor Radchenko
Timothy writes: > This patchset accomplishes two things: > 1. It refactors the overly large `org-latex-src-block' function, and makes a > few >other improvements to pre-existing code > 2. It adds a new option for exporting code, named (you guessed it!) “engraved” > > What is this new

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Daniel Fleischer
Timothy [2022-05-04 Wed 23:59] wrote: > I’ve been fairly busy as of late (hence my recent silence on this ML), > however I have a patchset that’s been in the > works for a while that I’ve finally polished up. Hi Timothy, thank you very much for your work! Let me learn a bit about the

Re: [PATCH] New LaTeX code export option: engraved

2022-05-05 Thread Daniel Fleischer
Timothy [2022-05-04 Wed 23:59] wrote: > I’ve been fairly busy as of late (hence my recent silence on this ML), > however I have a patchset that’s been in the > works for a while that I’ve finally polished up. Hi Timothy, thank you very much for your work! Let me learn a bit about the

[PATCH] New LaTeX code export option: engraved

2022-05-04 Thread Timothy
Hi All, I’ve been fairly busy as of late (hence my recent silence on this ML), however I have a patchset that’s been in the works for a while that I’ve finally polished up. Short version: It adds a new (superior) option for exporting code blocks with syntax highlighting to LaTeX. The long