Re: [PATCH] c-csl : accept relative CSL filenames

2022-02-18 Thread Kaushal Modi
> It is already in the main branch, AFAIU. I assume you mean it should be > back-ported to bugfix branch. If that's the case, I don't know. This is > a new feature, and not a critical one: there are workarounds, as you > found out. Yes, sorry, I meant the bugfix branch. > This should be

Re: [PATCH] c-csl : accept relative CSL filenames

2022-02-18 Thread Nicolas Goaziou
Hello, Kaushal Modi writes: > Can this commit[1] be merged into the main branch. It is already in the main branch, AFAIU. I assume you mean it should be back-ported to bugfix branch. If that's the case, I don't know. This is a new feature, and not a critical one: there are workarounds, as you

Re: [PATCH] c-csl : accept relative CSL filenames

2022-02-18 Thread Kaushal Modi
Hello Nicolas, > Since you are probably busy, I implemented this on your behalf. The new > behaviour is in main branch. Thank you. > Can this commit[1] be merged into the main branch. Locally on my machine, I use org built from main and something like this was working fine: #+cite_export: csl

Re: [PATCH] c-csl : accept relative CSL filenames

2021-12-10 Thread Nicolas Goaziou
Hello, Emmanuel Charpentier writes: > Quintus' example illustrates why I think my proposed patch is useful > (or, rather, will be when corrected :-)), and why the order of research > should be from most-specific to less-specific. > > If a finename is not absolute, search : > 1. relatively

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-19 Thread M . ‘quintus’ Gülker
Am Freitag, dem 19. November 2021 schrieb Nicolas Goaziou: > I think a better order for a relative file name would be: > > 1. relatively to `org-cite-csl-styles-dir', > 2. relatively to buffer's default directory, > 3. failure. > > WDYT? I would be fine with it. -quintus -- Dipl.-Jur. M.

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-19 Thread Nicolas Goaziou
Hello, Emmanuel Charpentier writes: > If a finename is not absolute, search : > 1. relatively to the buffer's default directory > 2. if 1. unsuccessfull, relatively to`org-cite-csl-styles-dir' > 3. if 2. unsuccessfull, relatively to emacs' default directory > (BTW :

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-05 Thread Emmanuel Charpentier
Quintus' example illustrates why I think my proposed patch is useful (or, rather, will be when corrected :-)), and why the order of research should be from most-specific to less-specific. If a finename is not absolute, search : 1. relatively to the buffer's default directory 2. if

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-05 Thread Eric S Fraga
On Thursday, 4 Nov 2021 at 18:36, Bruce D'Arcus wrote: > I'm strongly opposed to 2. > > 1 seems fine. I'm with Bruce on this. I would like to specify a directory for csl style search that differs from the default directory for Emacs as a whole. The latter is already getting rather cluttered

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-05 Thread M . ‘quintus’ Gülker
Am Donnerstag, dem 04. November 2021 schrieb Nicolas Goaziou: > I think there are two ways forward when a relative file name is used: > > 1. First check `org-cite-csl-styles-dir' and, if it is nil, expand >against `default-directory'; > > 2. Drop `org-cite-csl-styles-dir' and always expand

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-04 Thread Bruce D'Arcus
On Thu, Nov 4, 2021 at 6:20 PM Nicolas Goaziou wrote: > I think there are two ways forward when a relative file name is used: > > 1. First check `org-cite-csl-styles-dir' and, if it is nil, expand >against `default-directory'; > > 2. Drop `org-cite-csl-styles-dir' and always expand against >

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-04 Thread Nicolas Goaziou
Hello, Emmanuel Charpentier writes: > IMHO, `org-cite-csl-styles-dir' is deemed to be a more-or-less > permanent setting (possibly in `.emacs'), whereas allowing a relative > filename doesn't need any initial setup. But your patch blocks any use for `org-cite-csl-styles-dir' (relative file

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-04 Thread Emmanuel Charpentier
Le mercredi 03 novembre 2021 à 17:19 +0100, Nicolas Goaziou a écrit : > Hello, > > Emmanuel Charpentier writes: > > > This (minuscule) patch allows to pass a relative (to the buffer's > > default directory) file name to denote the CSL style file. > > Thank you. However, I'm not sure to

Re: [PATCH] c-csl : accept relative CSL filenames

2021-11-03 Thread Nicolas Goaziou
Hello, Emmanuel Charpentier writes: > This (minuscule) patch allows to pass a relative (to the buffer's > default directory) file name to denote the CSL style file. Thank you. However, I'm not sure to understand the purpose of the patch. > Rationale : this allows the use of "one-of" styles

[PATCH] c-csl : accept relative CSL filenames

2021-10-19 Thread Emmanuel Charpentier
This (minuscule) patch allows to pass a relative (to the buffer's default directory) file name to denote the CSL style file. Rationale : this allows the use of "one-of" styles for "one-of" projects without overloading a defailt CSL style directory (which may or may not exist on a given system :