Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Mon, Jan 23 2023, Ihor Radchenko wrote: > Ihor Radchenko writes: > >> Ihor Radchenko writes: >> >>> So, the test failure is real. >> >> The error buffer contents when the test fails is the following: >> >> warning: using the gnuplot graphics toolkit is discouraged >> ... >> [ Babel

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor Radchenko writes: > Ihor Radchenko writes: > >> So, the test failure is real. > > The error buffer contents when the test fails is the following: > > warning: using the gnuplot graphics toolkit is discouraged > ... > [ Babel evaluation exited with code 0 ] > > Exit code is 0, so octave

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On 14/01/2023 20:04, Leo Butler wrote: line 0: warning: iconv failed to convert degree sign This warning makes no sense to me. Just a guess. Some code creates a plot with the "°" character, but worker locale is ASCII, not UTF-8 (en_US.UTF-8, C.UTF-8, etc.)

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: >> The gnuplot graphics toolkit is not actively maintained and has a number >> of limitations that are unlikely to be fixed. Communication with gnuplot >> uses a one-directional pipe and limited information is passed back to the >> Octave interpreter so most changes made

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Fri, Jan 13 2023, Ihor Radchenko wrote: > Ihor Radchenko writes: > >> So, the test failure is real. > > The error buffer contents when the test fails is the following: > > warning: using the gnuplot graphics toolkit is discouraged > > The gnuplot graphics toolkit is not actively maintained

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor Radchenko writes: > So, the test failure is real. The error buffer contents when the test fails is the following: warning: using the gnuplot graphics toolkit is discouraged The gnuplot graphics toolkit is not actively maintained and has a number of limitations that are unlikely to be

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: >> So, the test failure is real. >> >> https://orgmode.org/list/94980226-d29a-4969-8640-1143a1979...@bundesbrandschatzamt.de >> might be related. > > Ihor, > > How do you want to treat the patch that was included? I think we should > have something like that to catch errors

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Wed, Jan 11 2023, Ihor Radchenko wrote: > Leo Butler writes: > >> Leo, could you please take a look? > > An earlier test is creating that *Org Babel Error Output* buffer. >>> >>> I will try to look into improving the tests so that we can trap the test(s) >>> that is(are) creating

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: > Leo, could you please take a look? An earlier test is creating that *Org Babel Error Output* buffer. >> >> I will try to look into improving the tests so that we can trap the test(s) >> that is(are) creating that error buffer. > > See the attachment. There are

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Sat, Jan 07 2023, Leo Butler wrote: > On Fri, Jan 06 2023, Ihor Radchenko wrote: > >> >> Leo Butler writes: >> https://builds.sr.ht/~bzg/job/914954 2 unexpected results: FAILED ob-octave/graphics-file ((should-not (get-buffer "*Org-Babel Error Output*")) :form

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor Radchenko writes: >> See the attached patch. > > Thanks! > Installed onto bugfix. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41ebc2e40 And still not enough... Though this time it does not look like our fault: https://builds.sr.ht/~bzg/job/918602 3 unexpected

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Fri, Jan 06 2023, Ihor Radchenko wrote: > > Caution: This message was sent from outside the University of Manitoba. > > > Leo Butler writes: > >>> Apparently, `sleep-for' 1

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: >> Apparently, `sleep-for' 1 second was not enough, and I decided to remove >> checking file size completely. > > Hello Ihor, > > Is there an environment variable that could be used to determine is the > tests are being run on sourcehut? This would let us cut out that test on

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Mon, Jan 02 2023, Ihor Radchenko wrote: > Ihor Radchenko writes: > >> Ihor Radchenko writes: >> There is a race condition between writing the contents of the graphics file to disk and emacs checking the file size. My guess is that this is causing the problem (and that the

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor Radchenko writes: > Ihor Radchenko writes: > >>> There is a race condition between writing the contents of the graphics >>> file to disk and emacs checking the file size. My guess is that this is >>> causing the problem (and that the same failure applies for emacs-2{6,7}, >>> since only

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor Radchenko writes: >> There is a race condition between writing the contents of the graphics >> file to disk and emacs checking the file size. My guess is that this is >> causing the problem (and that the same failure applies for emacs-2{6,7}, >> since only the emacs-28 reports the exact

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: >> Note that the tests are failing only partially. The graphics file does >> get created, but it has 0 size for some reason. Maybe something to do >> with non-graphical CI environment. > > There is a race condition between writing the contents of the graphics > file to disk

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Wed, Dec 21 2022, Ihor Radchenko wrote: > Ihor Radchenko writes: > >>> Upon confirming the FSF copyright assignment, I have applied the patch >>> onto bugfix. >>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=01c0ebee2 >> >> Your patch appears to not work in some

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor Radchenko writes: >> Upon confirming the FSF copyright assignment, I have applied the patch >> onto bugfix. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=01c0ebee2 > > Your patch appears to not work in some environments: > > https://builds.sr.ht/~bzg/job/906710 > > Any

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor Radchenko writes: > Leo Butler writes: > >> From 386c9c2f65730459bdc69b2e0b0b76e22e32dbc9 Mon Sep 17 00:00:00 2001 >> From: Leo Butler >> Date: Tue, 8 Nov 2022 13:31:47 -0600 >> Subject: [PATCH] prevent error in Octave process, add tests, update test docs > > Upon confirming the FSF

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: > From 386c9c2f65730459bdc69b2e0b0b76e22e32dbc9 Mon Sep 17 00:00:00 2001 > From: Leo Butler > Date: Tue, 8 Nov 2022 13:31:47 -0600 > Subject: [PATCH] prevent error in Octave process, add tests, update test docs Upon confirming the FSF copyright assignment, I have applied the

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Mon, Nov 14 2022, Ihor Radchenko wrote: > Leo Butler writes: > >> The amended patch is attached. Thanks for your helpful feedback. > > Thanks for the patch! > It looks good, and the tests are passing. However, there is a side effect > leaving testing/examples/octave-workspace file after

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: > The amended patch is attached. Thanks for your helpful feedback. Thanks for the patch! It looks good, and the tests are passing. However, there is a side effect leaving testing/examples/octave-workspace file after running the tests. Can something be done about this? --

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Ihor, see below. On Wed, Nov 09 2022, Ihor Radchenko wrote: > Leo Butler writes: > >> Ihor, >> Thanks for your feeback and the pointer. I have revised the tests and >> attach the revised patch. > > Thanks! > > Note that your patch is over 15LOC, which exceeds legally allowed > contribution

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

Leo Butler writes: > Ihor, > Thanks for your feeback and the pointer. I have revised the tests and > attach the revised patch. Thanks! Note that your patch is over 15LOC, which exceeds legally allowed contribution size for people without copyright assignment. Would you be interested to sign

[PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

On Tue, Nov 08 2022, Ihor Radchenko wrote: > Leo Butler writes: > >> However, I would like feedback/suggestions on writing such a >> test. Issues include: >> >> 1. how to clean up the side-effects, including changes in the test >>buffer, filesystem and potentially creating an error buffer;