Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-08-02 Thread Ihor Radchenko
Joseph Turner writes: > I've added a couple of (message ...) blocks to log the value of > do-export and params. It appears that this combination is producing a > params value which is equivalent to the value of params produced by the > current org-babel-execute:plantuml function. However, when

Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-07-31 Thread Joseph Turner
Ihor Radchenko writes: > You also need to change :result-params and :result-type. > See `org-babel-execute-src-block'. Here's what I've got so far: ``` (defvar org-babel-default-header-args:plantuml '((:exports . "results")) "Default arguments for evaluating a plantuml source block.")

Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-07-28 Thread Ihor Radchenko
Joseph Turner writes: > Ihor Radchenko writes: >> You can examine :result-params property inside params plist. If that >> property does not explicitly mention different results Type (see 16.6 >> Results of Evaluation), ob-plantuml may set the type to "file" with >> plist-put. > > Perhaps I'm

Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-07-27 Thread Joseph Turner
Ihor Radchenko writes: > You can examine :result-params property inside params plist. If that > property does not explicitly mention different results Type (see 16.6 > Results of Evaluation), ob-plantuml may set the type to "file" with > plist-put. Perhaps I'm confused, but I think

Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-07-25 Thread Ihor Radchenko
Joseph Turner writes: >> The solution will be simply removing the default :results setting. > > I think you're suggesting something like this: > > (defvar org-babel-default-header-args:plantuml > '((:exports . "results")) > "Default arguments for evaluating a plantuml source block.") > >

Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-07-25 Thread Joseph Turner
Thank you for your feedback, Ihor! > Most importantly, the patch does not change the default value of > org-babel-default-header-args:plantuml. :results header arg is set to > "file" by default. Yes, I noticed this issue also. > The solution will be simply removing the default :results setting.

Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-07-25 Thread Ihor Radchenko
Joseph Turner writes: > Allow src block execution without ":file" header arg. When ":file" is > omitted, insert txt output in buffer below src block. > > TINYCHANGE Thanks for your contribution! This addition makes a lot of sense. Some comments: Most importantly, the patch does not change the

[PATCH] lisp/ob-plantuml.el: Insert results in buffer

2022-07-21 Thread Joseph Turner
Allow src block execution without ":file" header arg. When ":file" is omitted, insert txt output in buffer below src block. TINYCHANGE --- etc/ORG-NEWS| 5 + lisp/ob-plantuml.el | 10 +++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/etc/ORG-NEWS