Hi Ian,
ian martins writes:
> Thanks for fixing this. I re-read the woof documentation and realized
> I needed to put "Applied" at the beginning of the line.
Yes - and also add a "X-Woof-Patch: applied" header in your reply.
On Sat, Apr 24, 2021 at 11:44 PM Timothy wrote:
>
> This was not marked as applied on updates.orgmode.org.
> Doing so with the X-Woof-Patch header.
>
> ian martins writes:
>
> > Thanks. And thanks for taking the time to fix issues that you find. It
> > continues to improve because of your
This was not marked as applied on updates.orgmode.org.
Doing so with the X-Woof-Patch header.
ian martins writes:
> Thanks. And thanks for taking the time to fix issues that you find. It
> continues to improve because of your contributions.
> The patch looks good. Applied.
Thanks. And thanks for taking the time to fix issues that you find. It
continues to improve because of your contributions.
The patch looks good. Applied.
On Thu, Jan 28, 2021 at 3:04 PM John Herrlin wrote:
>
>
> ian martins writes:
>
> >> I found this case:
> >> And it seems to me that the
Stay safe!
>From 92c72792fb18a73572ee35d34a5e1d5ce56d8b6a Mon Sep 17 00:00:00 2001
From: John Herrlin
Date: Tue, 26 Jan 2021 08:19:19 +0100
Subject: [PATCH] ob-java: Allow import to end with asterisk
* lisp/ob-java.el (org-babel-java--imports-re,
org-babel-java--import-maybe): Allow import to e
Thank you for the guidence! I will try to figure it out and sending a
updated patch soon.
ian martins writes:
>> I found this case:
>> And it seems to me that the import regex dont see the asterisk.
>>
>> I attached a possible patch.
>
> Thanks again, John. You're right the regex is missing
> I found this case:
> And it seems to me that the import regex dont see the asterisk.
>
> I attached a possible patch.
Thanks again, John. You're right the regex is missing the asterisk
include. Thanks for the patch fixing. This works but it will add
redundant includes if the source block
00:00:00 2001
From: John Herrlin
Date: Tue, 26 Jan 2021 08:19:19 +0100
Subject: [PATCH] ob-java: Allow import to end with asterisk
* lisp/ob-java.el (org-babel-java--imports-re): Allow import to end
with asterisk.
TINYCHANGE
---
lisp/ob-java.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
