[SOLVED] Re: [PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer

2020-02-12 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bastien writes: > Hi Stardiviner, > > stardiviner writes: > >> Hmmm.. Just a gentle ping ... This might is been missed Let me >> resume this thread. > > I've seen this suggestion and the previous ping but did not really > understand the chan

Re: [PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer

2020-02-12 Thread Bastien
Hi Stardiviner, stardiviner writes: > Hmmm.. Just a gentle ping ... This might is been missed Let me > resume this thread. I've seen this suggestion and the previous ping but did not really understand the change. I have edited your patch a little bit to avoid redundant lines and pushed it

Re: [PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer

2020-02-11 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hmmm.. Just a gentle ping ... This might is been missed Let me resume this thread. stardiviner writes: > I tried to write an alist of all database names. and write an function to used > to match name to possible names. But I found this solu

Re: [PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer

2020-02-05 Thread stardiviner
About this patch, patch, what do you think? Nicolas and Bastien. stardiviner writes: > I tried to write an alist of all database names. and write an function to used > to match name to possible names. But I found this solution is a little kind of > complicated. > > Another simple solution is j

[PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer

2020-02-04 Thread stardiviner
I tried to write an alist of all database names. and write an function to used to match name to possible names. But I found this solution is a little kind of complicated. Another simple solution is just add an duplicate code of "postgresql" for alias "postgres". Because I found only one exception