Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-07 Thread Rudolf Adamkovič
Ihor Radchenko writes: > Because I missed it. Gotcha! (Just wanted to make sure I understand.) > Now, added the info link. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0a9c9ede Thank you! Rudy -- "Genius is 1% inspiration and 99% perspiration." -- Thomas Alva Edison,

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-07 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> Thanks! >> Applied, onto bugfix. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3d817c52c > > Why not the one with the correct Info link, as per Max's excellent nitpick? Because I missed it. Now, added the info link.

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-05 Thread Rudolf Adamkovič
Ihor Radchenko writes: > Thanks! > Applied, onto bugfix. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3d817c52c Why not the one with the correct Info link, as per Max's excellent nitpick? Rudy -- "Be especially critical of any statement following the word 'obviously.'" --

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-05 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Please see the attached patch, revised as follows: > > - no leading space in the mode line element to make it completely correct > - a clear explanation (with a citation) to avoid pointless discussions > - two new automated tests to avoid future regressions > - a

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-04 Thread Rudolf Adamkovič
8?q?Rudolf=20Adamkovi=C4=8D?= Date: Thu, 2 Mar 2023 15:06:19 +0100 Subject: [PATCH] org-clock: Add a trailing space to the mode line string * lisp/org-clock.el (org-clock-get-clock-string): End the mode line element in a space, instead of beginning with space, to make it play well with other mod

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-03 Thread Max Nikulin
On 04/03/2023 04:03, Rudolf Adamkovič wrote: +(ert-deftest test-org-clock/mode-line () + "Test mode line string ends in a space. + +\"Elements that are added to [the mode line] should normally end +in a space (to ensure that consecutive 'global-mode-string' +elements display properly)\" per

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-03 Thread Rudolf Adamkovič
15:06:19 +0100 Subject: [PATCH] org-clock: Add a trailing space to the mode line string * lisp/org-clock.el (org-clock-get-clock-string): End the mode line element in a space, instead of beginning with space, to make it play well with other mode line strings, which typically end a space. For refer

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-03 Thread Ihor Radchenko
Max Nikulin writes: > On 02/03/2023 21:14, Rudolf Adamkovič wrote: >> +++ b/lisp/org-clock.el >> @@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50." >> 'org-mode-line-clock-overrun >>'org-mode-line-clock))) >>

Re: [PATCH] org-clock: Add a trailing space to the mode line string

2023-03-02 Thread Max Nikulin
On 02/03/2023 21:14, Rudolf Adamkovič wrote: +++ b/lisp/org-clock.el @@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50." 'org-mode-line-clock-overrun 'org-mode-line-clock))) (effort-str

[PATCH] org-clock: Add a trailing space to the mode line string

2023-03-02 Thread Rudolf Adamkovič
* lisp/org-clock.el (org-clock-get-clock-string): End the mode line string with a space character to make it play well with other mode line strings which traditionally end with a space character. For reference, see the mode line string of the Display Time mode. --- lisp/org-clock.el | 4 ++-- 1