Re: [PATCH] org-get-cursor-date regexp patch

2020-08-10 Thread Kyle Meyer
No Wayman writes: > Addressed in attached patch. Applied (ab9b14a80), dropping the unrelated whitespace changes that were introduced in the updated patch.

Re: [PATCH] org-get-cursor-date regexp patch

2020-08-09 Thread No Wayman
Makes sense. IMO it'd be nice to see something along the lines of this explanation in the commit message itself. The function name is missing here: * lisp/org.el (org-get-cursor-date): ... To my eyes, the new variable doesn't add any clarity over keeping it inline. Addressed in att

Re: [PATCH] org-get-cursor-date regexp patch

2020-08-09 Thread Kyle Meyer
Thanks for the patch. No Wayman writes: > The regular expression in `org-get-cursor-date' assumes the time > grid string will have two digits in the hour portion of the time > strng. > However, the grid time string does not always have two digits. For > example: > > " 8:00.." Makes sense.

[PATCH] org-get-cursor-date regexp patch

2020-08-02 Thread No Wayman
The regular expression in `org-get-cursor-date' assumes the time grid string will have two digits in the hour portion of the time strng. However, the grid time string does not always have two digits. For example: " 8:00.." The attached patch accounts for this and uses the rx macro to c