Re: [PATCH] org-macs.el: Do not compare wall time and file modification time

2022-10-01 Thread Ihor Radchenko
Max Nikulin writes: > From b2a546e239f32c78fb2dfaf92201a0b23eb76059 Mon Sep 17 00:00:00 2001 > From: Max Nikulin > Date: Fri, 6 May 2022 23:34:52 +0700 > Subject: [PATCH] org-macs.el: Do not compare wall time and file modification > time Max, the patch does not currently apply

Re: [PATCH] org-macs.el: Do not compare wall time and file modification time

2022-05-13 Thread Paul Eggert
On 5/13/22 05:28, Max Nikulin wrote: Feel free to commit your variant though, I will not object, but I am not going to update my patch in this way as well. I'll leave it up to you; it's not a big deal either way.

Re: [PATCH] org-macs.el: Do not compare wall time and file modification time

2022-05-13 Thread Max Nikulin
On 13/05/2022 05:52, Paul Eggert wrote: On 5/12/22 09:55, Max Nikulin wrote: +    (unless (file-exists-p file) +  (error "File to tangle does not exist: %s" file)) +    (when (file-newer-than-file-p file tangled-file)    (org-babel-tangle-file file ... file-newer-than-file-p succeeds

Re: [PATCH] org-macs.el: Do not compare wall time and file modification time

2022-05-12 Thread Paul Eggert
On 5/12/22 09:55, Max Nikulin wrote: +(unless (file-exists-p file) + (error "File to tangle does not exist: %s" file)) +(when (file-newer-than-file-p file tangled-file) (org-babel-tangle-file file ... file-newer-than-file-p succeeds only if FILE exists, so in that case it'

Re: [PATCH] org-macs.el: Do not compare wall time and file modification time

2022-05-12 Thread Max Nikulin
s why I did not bother if the code may be optimized a bit. Finally I have found `file-newer-than-file-p' that looks suitable for such case. From b2a546e239f32c78fb2dfaf92201a0b23eb76059 Mon Sep 17 00:00:00 2001 From: Max Nikulin Date: Fri, 6 May 2022 23:34:52 +0700 Subject: [PATCH] org-mac

Re: [PATCH] org-macs.el: Do not compare wall time and file modification time

2022-05-11 Thread Paul Eggert
The comments don't seem to match the code here. + (let* ((tangled-file (concat (file-name-sans-extension file) ".el")) + (file-mtime (file-attribute-modification-time + (file-attributes (file-truename file + (tangled-mtime (file-attribute-modification-ti

Re: [PATCH] org-macs.el: Do not compare wall time and file modification time

2022-05-11 Thread Max Nikulin
I consider such case as a rare and peculiar one.From e5f98dbc729904297bef529009ade96361dd4dd2 Mon Sep 17 00:00:00 2001 From: Max Nikulin Date: Fri, 6 May 2022 23:34:52 +0700 Subject: [PATCH] org-macs.el: Do not compare wall time and file modification time * lisp/org-macs.el (org-file-newer-than-p

[PATCH] org-macs.el: Do not compare wall time and file modification time

2022-05-06 Thread Max Nikulin
17 00:00:00 2001 From: Max Nikulin Date: Fri, 6 May 2022 23:34:52 +0700 Subject: [PATCH] org-macs.el: Do not compare wall time and file modification time * lisp/org-macs.el (org-file-newer-than-p): Fix Emacs-29 problem with changed representation of system clock timestamp. Recommend passing fil