Fwd: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-10-02 Thread Gustav Wikström
10:48 PM To: Gustav Wikström Subject: Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing Gustav Wikström writes: > Aha, hmm... I don't remember commiting any other persons code. I > honestly think it's just me fixing the same thing thing that > apparently al

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-09-27 Thread Emily Bourke
Hi Bastien, > oh, you're right! Sorry I pinged you for nothing on this. No worries! Best wishes, Emily

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-09-27 Thread Bastien
Hi Emily, Emily Bourke writes: > It looks like the same changes have been made separately and merged > into master since my original email – see commit > aa0fa8c75360d2aa491b9ae10e59d22de2aedc92 by Gustav Wikström. oh, you're right! Sorry I pinged you for nothing on this. Gustav, for next

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-09-27 Thread Emily Bourke
Hi Bastien, It looks like the same changes have been made separately and merged into master since my original email – see commit aa0fa8c75360d2aa491b9ae10e59d22de2aedc92 by Gustav Wikström. Best wishes, Emily

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-09-26 Thread Emily Bourke
Hi Bastien, > Tomorrow for sure, and probably next week will be okay too. Perfect, I’ll get back to you once I’ve taken a look tomorrow. > To be clear, I hope we can release 9.5 soon to be able to make it > included in the next Emacs 28.1 version. Understood, thanks for the clarification.

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-09-26 Thread Bastien
Hi Emily, thanks for your quick feedback! Emily Bourke writes: >> ... did you have time to take a closer look at this? > > I’m afraid I haven’t had any look at this since. However, I’ll have > time tomorrow and later in the week to take a look – will that be > early enough for the 9.5 release?

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-09-26 Thread Emily Bourke
Hi Bastien, Thanks for getting in touch! > ... did you have time to take a closer look at this? I’m afraid I haven’t had any look at this since. However, I’ll have time tomorrow and later in the week to take a look – will that be early enough for the 9.5 release? Best wishes, Emily

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-09-26 Thread Bastien
Hi Emily, sorry to bump an old thread... Emily Bourke writes: > I'm afraid I haven't had a chance to look at this any further since > my last email. I'll try to find some time this week. ... did you have time to take a closer look at this? We are working on preparing Org 9.5, hopefully

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-05-05 Thread Emily Bourke
Hi Bastien, > thanks for the patch and sorry to reactivate this old thread. No problem, thanks for getting in touch - the reminder is appreciated. > Did you find time to make the tests and, perhaps, to update the patch? I'm afraid I haven't had a chance to look at this any further since my

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-05-01 Thread Bastien
Hi Emily, thanks for the patch and sorry to reactivate this old thread. Did you find time to make the tests and, perhaps, to update the patch? Please let us know - thanks! -- Bastien

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-01-06 Thread Dr. Arne Babenhauserheide
Kyle Meyer writes: > Nothing jumps out to me. For large files that are already visited, I > suppose find-file-noselect returning an existing buffer can be faster, > so relevant factors would include how many Org files a project has, how > large they are, and how many of those are visited in

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-01-06 Thread Emily Bourke
Thanks for the feedback! > Nothing jumps out to me. For large files that are already visited, I > suppose find-file-noselect returning an existing buffer can be faster, > so relevant factors would include how many Org files a project has, how > large they are, and how many of those are visited in

Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-01-03 Thread Kyle Meyer
t gain, though that gain would be narrowed some if the temporary buffer was put into org-mode rather than kept in fundamental-mode (more below). > Subject: [PATCH] ox-publish.el: Speed up > org-publish-cache-file-needs-publishing > > * lisp/ox-publish.el (org-publish-cache-file-

[PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing

2021-01-01 Thread Emily Bourke
Hi, I found publishing when there were no changes to be slower than expected. Profiling showed me that `org-publish-cache-file-needs-publishing' was invoking the `after-find-file' hooks, which I don't think is necessary. I've changed it to avoid doing that, by using `with-temp-buffer' and