Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description

2022-09-13 Thread Ihor Radchenko
Ihor Radchenko writes: >> Yes, I've tested it with target and custom_id links and, as you said, there >> is no change in behavior. The entire URL is still pasted and no chance to >> edit it is given to the user. > > Oops. Somehow some way things worked for me at some point when I was > making

Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description

2022-09-12 Thread Max Nikulin
On 12/09/2022 18:02, Ihor Radchenko wrote: Max Nikulin writes: Unfortunately, your patch does not fix the real issue. The title (not nil) should be saved for link description when the heading contains the CUSTOM_ID property. I tried to address it in the following patches: Max Nikulin. Re:

Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description

2022-09-12 Thread Ihor Radchenko
Max Nikulin writes: > Unfortunately, your patch does not fix the real issue. The title (not > nil) should be saved for link description when the heading contains the > CUSTOM_ID property. I tried to address it in the following patches: > > Max Nikulin. Re: Bug: org-store-link uses CUSTOM_ID

Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description

2022-09-11 Thread Max Nikulin
On 14/08/2022 16:53, Max Nikulin wrote: On 13/08/2022 12:01, Ihor Radchenko wrote: See the updated version of the patch attached. It works on my side. --- a/lisp/ol.el +++ b/lisp/ol.el @@ -1577,10 +1577,8 @@ (defun org-store-link (arg interactive?)    t (setq link (plist-get

Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description

2022-08-14 Thread Max Nikulin
On 13/08/2022 12:01, Ihor Radchenko wrote: See the updated version of the patch attached. It works on my side. --- a/lisp/ol.el +++ b/lisp/ol.el @@ -1577,10 +1577,8 @@ (defun org-store-link (arg interactive?) t (setq link (plist-get org-store-link-plist :link))

[PATCH v2] Re: Adding target and custom id links doesn't ask for description

2022-08-12 Thread Ihor Radchenko
Carlos Pita writes: >> Carlos, have you tried Ihor's patch? I like the intention, but I do not >> see any effect. >> > > Yes, I've tested it with target and custom_id links and, as you said, there > is no change in behavior. The entire URL is still pasted and no chance to > edit it is given to