Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters

2022-07-17 Thread Ihor Radchenko
Max Nikulin writes: > Ihor, Hugo raised a question how to interpret nil returned by > :insert-description functions. Do you have any opinion? I do not like > the idea to consider it as an error since string is expected. I would > prefer to call `org-link-make-description-function' as a

Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters

2022-07-17 Thread Ihor Radchenko
Hugo Heagren writes: >> Can you also update the documentation for >> org-link-make-description-function? > > I'm not sure what sort of documentation you have in mind? What should > I add? I referred to my earlier statement: > tl;dr The question is: what is the Good Behaviour when

Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters

2022-07-17 Thread Max Nikulin
Hi, Ihor, Hugo raised a question how to interpret nil returned by :insert-description functions. Do you have any opinion? I do not like the idea to consider it as an error since string is expected. I would prefer to call `org-link-make-description-function' as a fallback. On 17/07/2022

Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters

2022-07-16 Thread Ihor Radchenko
Hugo Heagren writes: >> Currently, the internal implementation will treat nil return value as if >> there was no :default-description and org-link-make-description-function >> were set to nil. We may probably document this. It sounds like a useful >> behavior. > > I added some relevant