Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

2021-07-08 Thread Christian Hopps
It may eventually be incorporated into the very popular emacs-mac port (railwaycat tap in homebrew); however, it will probably not be incorporated into the nextstep/emacs main code. I started looking at doing a version for the mainline code, but it’s hard to get motivated b/c using that version

Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

2021-07-07 Thread stardiviner
Hi Chris, thanks for your work. I have a question, will your patch of notification code be merged to upstream? If yes, I think my patch will be not necessary. If no, then I think add a my workaround for macOS is considerable. > On Jul 7, 2021, at 2:23 AM, Christian Hopps wrote: > > It supports

Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

2021-07-06 Thread Christian Hopps
It supports imagemagick (specify —with-imagemagick), and it includes svg by default, I simply forked the railwaycat version and added the native notification code. Thanks, Chris. > On Jul 6, 2021, at 11:30 AM, stardiviner wrote: > > Thanks for your suggestion. Does your Emacs build supports i

Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

2021-07-06 Thread stardiviner
Thanks for your suggestion. Does your Emacs build supports imagemagick image view and svg feature support? Because company-mode now have built-in icons support. This is the reason that I switch from https://emacsformacosx.com/ to Homebrew cask Emacs version. > On J