Mario Frasca writes:
> comments on the html page org-contribute.html:
[...]
> the procedure mentioned there guides me in creating several patch files,
> one per commit. it does not describe the "squashing" you suggested me.
> I'm following your guide, but you might want to review the page your
On 03/06/2020 10:29, Bastien wrote:
The few lines above is what we called the "changelog". It should be
the first part of the commit message -- after which you can add more
free-form context and explanations, if needed.
this "Changelog", and I'm sure I am the stiffy one, isn't clear from the
fixing things is not as difficult as following stiff rules. anyhow,
again an attempt, with the terrible feeling I'm wasting my and your
time. (looks like I found a printer, for signing the paperwork.)
>From 3375ee101054dc087b40da119941e0433b63fea5 Mon Sep 17 00:00:00 2001
From: mfrasca
Date:
Mario Frasca writes:
> yes, I received the ASSIGNMENT –GNU EMACS pdf last night, I'm now
> seeing how I print & sign it. it might take some time.
Sure - probably a few weeks. Let us know when this is done so that
we can go ahead with applying your patches.
--
Bastien
Mario Frasca writes:
> I'm sure you do understand what I mean, and I guess you know what
> would be the correctly formatted version. can you show me?
Yes. You mentioned earlier that you missed this section:
https://orgmode.org/worg/org-contribute.html#commit-messages
Let me quote the text
On 03/06/2020 10:13, Bastien wrote:
Also you need to sign the FSF copyright assignment if you want to make
big changes like this one.
yes, I received the ASSIGNMENT –GNU EMACS pdf last night, I'm now seeing
how I print & sign it. it might take some time.
I'm very so much sorry Bastien, but I do not know what you mean, by "not
correctly formatted". if it were a bug report, you do agree it would be
a useless one? like "it doesn't work".
I'm sure you do understand what I mean, and I guess you know what would
be the correctly formatted version.
Mario Frasca writes:
> see attachment
Thanks for the effort -- the commit message is not correctly formatted
though. See https://orgmode.org/worg/org-contribute.html#commit-messages
and perhaps also read previous commit messages.
Also you need to sign the FSF copyright assignment if you want t
see attachment
>From 2a30f377281955f57723ef46ff56613373cf721d Mon Sep 17 00:00:00 2001
From: mfrasca
Date: Tue, 2 Jun 2020 16:10:11 -0500
Subject: [PATCH] org-plot.el: implementing new feature "with-as-list"
Allows user specify as many `with' values as the columns in `deps'.
User can indicate t
Dear Mario,
Mario Frasca writes:
> is there any mention of git-send-mail in the org-contribute guide? I
> don't see it. nor do I find hints on what to do once you have
> produced files by git-format-patch. your "send as attachment" would
> be useful there.
I added this line to org-contribu
er wrote:
Mario Frasca writes:
From 436bfd0b9fd656f52ea9d7e6a6a665a32564ae93 Mon Sep 17 00:00:00 2001
From: Mario Frasca
Date: Tue, 2 Jun 2020 15:46:20 +0000
Subject: [PATCH] implementing `with' as a list, and respecting `deps' order.
Thank you for sending an updated patch. Unfortunately it looks lik
Mario Frasca writes:
> From 436bfd0b9fd656f52ea9d7e6a6a665a32564ae93 Mon Sep 17 00:00:00 2001
> From: Mario Frasca
> Date: Tue, 2 Jun 2020 15:46:20 +
> Subject: [PATCH] implementing `with' as a list, and respecting `deps' order.
Thank you for sending an updated pa
From 436bfd0b9fd656f52ea9d7e6a6a665a32564ae93 Mon Sep 17 00:00:00 2001
From: Mario Frasca
Date: Tue, 2 Jun 2020 15:46:20 +
Subject: [PATCH] implementing `with' as a list, and respecting `deps' order.
---
doc/org-manual.org | 7 ++--
lisp/org-plot.el
Mario Frasca writes:
> On 31/05/2020 19:19, Kyle Meyer wrote:
>> You've been sending a diff,
>> presumably from the point you branched off of to the tip of your branch.
>> In that case, you're already presenting each iteration you've sent as
>> one change; it just lacks a commit message.
>
> right
On 31/05/2020 19:19, Kyle Meyer wrote:
You've been sending a diff,
presumably from the point you branched off of to the tip of your branch.
In that case, you're already presenting each iteration you've sent as
one change; it just lacks a commit message.
right, that's indeed what I did, and this
Mario Frasca writes:
> On 30/05/2020 16:29, Mario Frasca wrote:
>> I hope to be back soon with a single commit...
>
> one doubt. what's the point of having me squash all in a single commit,
> when I do not have write access to the repository?
To provide me or another committer with a polished
On 30/05/2020 16:29, Mario Frasca wrote:
I hope to be back soon with a single commit...
one doubt. what's the point of having me squash all in a single commit,
when I do not have write access to the repository? if we were on
github, I would be working on a pull request, which would have a
Mario Frasca writes:
> On 30/05/2020 15:25, Kyle Meyer wrote:
>> Could you update this header to match the style used by other tests
>> (see, e.g., test-org-num.el)?
>
> apparently, I managed to pick precisely the wrong example!
>
> ;;; test-org-clock.el --- Tests for org-clock.el
Ha, I poked aro
On 30/05/2020 15:25, Kyle Meyer wrote:
Could you update this header to match the style used by other tests
(see, e.g., test-org-num.el)?
apparently, I managed to pick precisely the wrong example!
;;; test-org-clock.el --- Tests for org-clock.el
oops .. you mentioned `cl-loop' and I found it interesting, in
particular the de-structuring part.
so I rewrote the (dolist (col-with …) …) as (cl-loop for (col . with) in
… do …).
so I could simplify `(car col-with)' and `(cdr col-with)', then I
replaced the `do' with a `collect', so I coul
Mario Frasca writes:
> diff --git a/lisp/org-plot.el b/lisp/org-plot.el
> index a23195d2a..c44cca991 100644
> --- a/lisp/org-plot.el
> +++ b/lisp/org-plot.el
> @@ -156,7 +156,8 @@ and dependent variables."
> table)))
> ;; write table to gnuplot grid datafile format
>
Mario Frasca writes:
> btw. are you on irc.freenode.net? I'm `mariotomo' there. and I just
> joined `#org-mode'. I don't think that my terminal will ring a bell if
> I'm mentioned there.
No, sorry, I'm not.
> On 30/05/2020 01:22, Kyle Meyer wrote:
>> Mario Frasca writes:
>
>> Two meta-comme
what's new …
edited the documentation string to `org-plot/zip-deps-with',
removed some redundancies there,
removed my ›zip‹ function, in favour of ›cl-mapcar 'cons‹,
simplified the double test `stringp', `string=' with `equal'.
simplified the unit tests correspondingly.
make test: no unexpec
On 30/05/2020 09:23, Mario Frasca wrote:
The code above looks fine to me. Another option would be to use
number-sequence and then filter out the ind value.
no, that would break functionality: I need to keep the given order.
ah, no, sorry, you are totally right here. I'll see if using
number-
Hi Kyle,
thank you for writing back, I have a couple of questions in reply.
btw. are you on irc.freenode.net? I'm `mariotomo' there. and I just
joined `#org-mode'. I don't think that my terminal will ring a bell if
I'm mentioned there.
On 30/05/2020 01:22, Kyle Meyer wrote:
Mario Frasca
Mario Frasca writes:
> now and then I use emacs to make graphs. now recently I was plotting
> point data, and a running average "fit", so I wanted to have points, and
> lines, which I know it's possible in `gnuplot` but now how do I do that
> from org-plot …
>
> I wrote a small patch for org-p
I have added a couple of unit tests to the suite, describing the two
functions I added. I have no unexpectedly failing tests now.
I'm explicitly cc-ing Eric Schulte because he's in the header for
org-plot.el, and —missing the unit tests for that source— I hope he can
assist me not breaking wh
good day to you all
now and then I use emacs to make graphs. now recently I was plotting
point data, and a running average "fit", so I wanted to have points, and
lines, which I know it's possible in `gnuplot` but now how do I do that
from org-plot …
I wrote a small patch for org-plot.el, I'
28 matches
Mail list logo
