Re: BUG: org-table: table option “:missing” not working (in ob-gnuplot.el)

2021-10-01 Thread Ihor Radchenko
Nicolas Goaziou writes: >> At this point, third-party code is likely to rely on the existing logic, >> so I do not see any reason to insist on changing org-table. > > If you think it is overall an improvement, feel free to discuss it. I'm > merely pointing out what was the initial intent, not nec

Re: BUG: org-table: table option “:missing” not working (in ob-gnuplot.el)

2021-10-01 Thread Nicolas Goaziou
Hello, Ihor Radchenko writes: > At this point, third-party code is likely to rely on the existing logic, > so I do not see any reason to insist on changing org-table. If you think it is overall an improvement, feel free to discuss it. I'm merely pointing out what was the initial intent, not nec

Re: BUG: org-table: table option “:missing” not working (in ob-gnuplot.el)

2021-09-30 Thread Ihor Radchenko
Nicolas Goaziou writes: > I'm not sure. I wrote this some years ago. I guess the rationale at that > time was that it didn't feel useful to apply a format to an empty cell. > For example, if you use `:fmt "$%s$"', I assume you wouldn't want to get > "$$" in otherwise empty cells. Also makes sens

Re: BUG: org-table: table option “:missing” not working (in ob-gnuplot.el)

2021-09-30 Thread Ihor Radchenko
Ihor Radchenko writes: > The attached patch should fix the issue, though it may be more > reasonable to fix orgtbl-to-generic logic. Given Nicholas' reply, changing orgtbl-to-generic may not be a good idea and break other code using orgtbl-to-generic. Applied as ddee7b617 on bugfix Best, Ihor

Re: BUG: org-table: table option “:missing” not working (in ob-gnuplot.el)

2021-09-30 Thread Nicolas Goaziou
Hello, Ihor Radchenko writes: > Nicolas, > > Is there a rationale behind bypassing :fmt and :hfmt for empty table > cells in `org-table--to-generic-cell'? In this patch, I have to work > around this using :raw parameter in `orgtbl-to-generic' call. I do not > feel like such workaround should be

Re: BUG: org-table: table option “:missing” not working (in ob-gnuplot.el)

2021-09-30 Thread Ihor Radchenko
Robert Klein writes: > When trying to run a table with missing values with ob-gnuplot.el > there's a “:missing value” option. ob-gnuplot is supposed to put the > “value” into the place of empty cell values before calling on gnuplot. > It doesn't do this currently. Confirmed The problem is part

BUG: org-table: table option “:missing” not working (in ob-gnuplot.el)

2021-06-17 Thread Robert Klein
Hi everyone, a bug report: Emacs : GNU Emacs 27.2 (build 1, x86_64-unknown-openbsd, GTK+ Version 2.24.33) of 2021-04-20 Package: Org mode version 9.4.6 (release_9.4.6-4-g093c94 @ /home/roklein/.emacs.d/org-mode/lisp/) When trying to run a table with missing values with ob-gnuplot.el there's