Re: Minor patch

2024-03-13 Thread Ihor Radchenko
Stefan Monnier writes: > The minor patch below clarifies what the computation is about and > removes the assumption that point-min == 1, while arguably > making the the code ever so slightly more efficient. Thanks! Applied, onto main, with minor amendments to the commit messa

Minor patch

2024-03-13 Thread Stefan Monnier
The minor patch below clarifies what the computation is about and removes the assumption that point-min == 1, while arguably making the the code ever so slightly more efficient. Stefan >From d386af0653ff75956cc20e0df8ddb5bfa86fec9d Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date:

Re: Minor patch for org-attach.el

2022-02-06 Thread Stefan Monnier
> I pushed this to the development branch 'main' of Org. Perfect, thanks, Stefan

Re: Minor patch for org-attach.el

2022-02-06 Thread Marco Wahl
Stefan Monnier writes: > Here's a patch which cleans up some magic numbers in > `org-attach.el` and gets rif of the use of the second arg of `commandp`, > by making `org-attach-commands` accept any commands (including keyboard > macros). > > > Stefan > > > diff --git

Minor patch for org-attach.el

2022-02-06 Thread Stefan Monnier
Here's a patch which cleans up some magic numbers in `org-attach.el` and gets rif of the use of the second arg of `commandp`, by making `org-attach-commands` accept any commands (including keyboard macros). Stefan diff --git a/lisp/org/org-attach.el b/lisp/org/org-attach.el index

Re: [O] a minor patch to awk invocation

2014-06-13 Thread Achim Gratz
The problem was that a) I'm using tcsh. b) Some part of the system-wide csh.cshrc related to Emacs' shell-mode was also run for non-interactive shell invocation while only appropriate for interactive use (that's where the errors from tset and stty came from). c) Your second patch

Re: [O] a minor patch to awk invocation

2014-06-07 Thread Eric Schulte
Greg Minshall minsh...@acm.org writes: though, in the spirit of no good deed goes unpunished: #+name: foo | a | b | c | #+begin_src awk :var a=foo BEGIN{ print a; } #+end_src gives an error (and, ':var a=this is a test' doesn't behave as one might expect). i haven't looked at

Re: [O] a minor patch to awk invocation

2014-06-07 Thread Eric Schulte
Achim Gratz strom...@nexgo.de writes: Eric Schulte writes: Thanks for pointing out this shortcoming and for suggesting the command-line variable assignment option. I've just pushed up a patch which changes the behavior of awk code blocks to assign variables on the command line, so the

Re: [O] a minor patch to awk invocation

2014-06-07 Thread Achim Gratz
Eric Schulte writes: I can't reproduce these problems. Could you provide examples, and maybe a stack traces? The tests have all been done with make vanilla and testing/examples/ob-awk-test.org. The test failure is: --8---cut here---start-8--- ((tset:

Re: [O] a minor patch to awk invocation

2014-06-07 Thread Eric Schulte
Achim Gratz strom...@nexgo.de writes: Eric Schulte writes: I can't reproduce these problems. Could you provide examples, and maybe a stack traces? The tests have all been done with make vanilla and testing/examples/ob-awk-test.org. The test failure is: [...] I've no idea how to get at

Re: [O] a minor patch to awk invocation

2014-06-07 Thread Achim Gratz
Eric Schulte writes: Are these failures only present *after* these recent changes to ob-awk? I can't think of how these changes could be related to this STDIN error. Yes, they've just started with the second commit (the first one broke the tests in a different way as you may know). I would be

Re: [O] a minor patch to awk invocation

2014-06-07 Thread Greg Minshall
thanks -- nice!

Re: [O] a minor patch to awk invocation

2014-06-06 Thread Eric Schulte
Greg Minshall minsh...@acm.org writes: hi. i just wandered down a rathole others could avoid. the following program fails in (what was to me) a mysterious way: #+BEGIN_SRC awk :var a=2 BEGIN{print $a;} #+END_SRC it turns out values for variables to awk need to be strings

Re: [O] a minor patch to awk invocation

2014-06-06 Thread Greg Minshall
very nice -- thanks! I've just pushed up a patch which changes the behavior of awk code blocks to assign variables on the command line, so the following now work. #+begin_src awk :var a=2 BEGIN{ print a; } #+end_src #+RESULTS: : 2

Re: [O] a minor patch to awk invocation

2014-06-06 Thread Greg Minshall
though, in the spirit of no good deed goes unpunished: #+name: foo | a | b | c | #+begin_src awk :var a=foo BEGIN{ print a; } #+end_src gives an error (and, ':var a=this is a test' doesn't behave as one might expect). i haven't looked at ob-*.el enough to know the patterns used to wrap

Re: [O] [PATCH] minor patch to org-babel-load-file

2013-06-20 Thread Eric Schulte
Michael Brand michael.ch.br...@gmail.com writes: Hi Levin On Tue, Jun 18, 2013 at 9:44 AM, Levin Du zsle...@gmail.com wrote: Below is the patch that solves this problem. Recently I also noticed a regression of org-babel-load-file that is resolved with your patch. Thank you for saving me of

Re: [O] [PATCH] minor patch to org-babel-load-file

2013-06-20 Thread Michael Brand
Hi Eric On Thu, Jun 20, 2013 at 5:58 PM, Eric Schulte schulte.e...@gmail.com wrote: I've just pushed up a fix in commit a79fd4be [2]. Thank you, the issue with org-babel-load-file that I noticed is resolved in the current master branch. Michael

Re: [O] [PATCH] minor patch to org-babel-load-file

2013-06-20 Thread Achim Gratz
Eric Schulte writes: Recently I also noticed a regression of org-babel-load-file that is resolved with your patch. Thank you for saving me of one of my TODOs. This patch doesn't fix the actual cause of this bug. The problem stems from commit 693dda67 [1], and I've just pushed up a fix in

[O] [PATCH] minor patch to org-babel-load-file

2013-06-18 Thread Levin Du
Hi, all I find org-babel-load-file not work for my emacs-starter-kit org file. After some traces, I find that (org-babel-merge-params nil nil nil) returns: ((:comments . ) (:shebang . ) (:cache . ) (:padline . ) (:noweb . ) (:tangle . ) (:exports . ) (:results . )) which will override

Re: [O] [PATCH] minor patch to org-babel-load-file

2013-06-18 Thread Michael Brand
Hi Levin On Tue, Jun 18, 2013 at 9:44 AM, Levin Du zsle...@gmail.com wrote: Below is the patch that solves this problem. Recently I also noticed a regression of org-babel-load-file that is resolved with your patch. Thank you for saving me of one of my TODOs. Michael

[O] v minor patch

2011-06-01 Thread Barak A. Pearlmutter
v minor patch, purely cosmetic From 83fb2858d3ff8fc08b07a48f425b15579617fdbc Mon Sep 17 00:00:00 2001 From: Barak A. Pearlmutter barak+...@cs.nuim.ie Date: Wed, 1 Jun 2011 13:56:41 +0100 Subject: [PATCH] remove unnecessary parenthesis in Makefile --- Makefile | 24 1