Re: PATCH: Re: Reading the parameters of a special-block

2022-10-20 Thread Ihor Radchenko
[adding Org ML back to CC] Bruno Barbier writes: >> Thanks! LGTM. >> > >> Now, can you also make a patch against https://git.sr.ht/~bzg/worg >> adding the new parameter to >> https://orgmode.org/worg/dev/org-element-api.html? > > Sure. Let me know if the attached patch is good enough. Applied

Re: PATCH: Re: Reading the parameters of a special-block

2022-10-19 Thread Ihor Radchenko
Bruno Barbier writes: > I also added a new independent patch, to fix a bug when interpreting a special > block that has no content, and some tests. > > Let me know if I did miss something, > And thank you for the review! Thanks! LGTM. Now, can you also make a patch against

Re: PATCH: Re: Reading the parameters of a special-block

2022-10-19 Thread Bruno Barbier
Ihor Radchenko writes: > The property name could be simply :parameters. Just like in src blocks > (see org-element-src-block-parser). Indeed. Done. > We probably want something like > > :parameters (and (org-string-nw-p parameters) (org-trim parameters)) > > Just as in

Re: PATCH: Re: Reading the parameters of a special-block

2022-10-17 Thread Ihor Radchenko
Bruno Barbier writes: > My understanding is that the parameters line is just ignored for special > blocks. > > I wrote and used a patch a while ago to fix this; it was on my todo list > to clean it up and submit it to org. Now looks like a good time. > > My patch adds a `:parameters-line'

PATCH: Re: Reading the parameters of a special-block

2022-10-17 Thread Bruno Barbier
Damien Cassou writes: > Hi, > > in Worg's description of Org's syntax, there is a section about "greater > blocks" [1]. The syntax is > > #+begin_NAME PARAMETERS > CONTENTS > #+end_NAME > > There is then a "PARAMETERS" optional string attached to special > blocks. Unfortunately, in