Re: Provide sane default for the @direntry

2024-03-08 Thread Ihor Radchenko
Stefan Monnier writes: > I fixed those three issues (I still get test failures, but I get the > same with or without my patch ). Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4fd869194

Re: Provide sane default for the @direntry

2024-03-08 Thread Stefan Monnier
> Thanks! > Unfortunately, the patch causes some tests (make test) to fail. > Looks like export to temporary buffer is broken (temporary buffer does > not have a filename): > > 2 unexpected results: >FAILED test-ox-texinfo/end-to-end-inline stringp >FAILED

Re: Provide sane default for the @direntry

2024-03-07 Thread Ihor Radchenko
Stefan Monnier writes: >> The patches are against Emacs git repository, not against Org mode. May >> your please port them? > > See attached. Thanks! Unfortunately, the patch causes some tests (make test) to fail. Looks like export to temporary buffer is broken (temporary buffer does not have a

Re: Provide sane default for the @direntry

2024-03-06 Thread Stefan Monnier
> The patches are against Emacs git repository, not against Org mode. May > your please port them? See attached. >> Subject: [PATCH 1/2] * lisp/org/ox-texinfo.el: Remove redundant `:group`s > By our convention, we drop leading * in the first line of the commit message. Done. >> *

Re: Provide sane default for the @direntry

2024-03-06 Thread Ihor Radchenko
Stefan Monnier writes: > New version of the patch, which I believe address your comments. Thanks! The patches are against Emacs git repository, not against Org mode. May your please port them? See some more minor comments inline. > Subject: [PATCH 1/2] * lisp/org/ox-texinfo.el: Remove

Re: Provide sane default for the @direntry

2024-03-05 Thread Stefan Monnier
New version of the patch, which I believe address your comments. Stefan >From 53c8fab18625e8a722657181cb3c825a1d8c895c Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Tue, 5 Mar 2024 14:11:19 -0500 Subject: [PATCH 1/2] * lisp/org/ox-texinfo.el: Remove redundant `:group`s ---

Re: Provide sane default for the @direntry

2024-03-05 Thread Ihor Radchenko
Stefan Monnier writes: > The "* DIRTITLE: (FILENAME)." syntax is Texinfo's syntax, and currently the > Org user needs to know that syntax and abide by it (even though it's > not well defined nor well documented, IME). My change mostly makes it > unnecessary for the user to know that syntax

Re: Provide sane default for the @direntry

2024-03-04 Thread Stefan Monnier
>> * doc/misc/org.org (Texinfo specific export settings): Adjust accordingly. > It would be nice to provide etc/ORG-NEWS entry as well. Yes, thanks. >>#+cindex: @samp{TEXINFO_DIR_TITLE}, keyword >>The directory title of the document. >> + This is the short name under which the ~m~

Re: Provide sane default for the @direntry

2024-03-04 Thread Ihor Radchenko
Stefan Monnier writes: >> May you please supply a ChangeLog entry? I am not sure if I understand >> the purpose of each change in the diff. >> >> Also, it looks like you introduce some DWIM behaviour for auto-generating >> @direntry contents. Such new behaviour ought to be documented in the >>

Re: Provide sane default for the @direntry

2024-03-02 Thread Stefan Monnier
> May you please supply a ChangeLog entry? I am not sure if I understand > the purpose of each change in the diff. > > Also, it looks like you introduce some DWIM behaviour for auto-generating > @direntry contents. Such new behaviour ought to be documented in the > manual and announced in the

Re: Provide sane default for the @direntry

2024-02-28 Thread Ihor Radchenko
Stefan Monnier writes: > When exporting to Texinfo, the patch below makes it easier to generate > a good `@direntry` by using sane defaults. > For most files, you'll just need > > #+TEXINFO_DIR_CATEGORY: {my-category} > > I believe it also makes it a bit harder to shoot oneself in the foot

Provide sane default for the @direntry

2024-02-27 Thread Stefan Monnier
When exporting to Texinfo, the patch below makes it easier to generate a good `@direntry` by using sane defaults. For most files, you'll just need #+TEXINFO_DIR_CATEGORY: {my-category} I believe it also makes it a bit harder to shoot oneself in the foot and generate an invalid entry (e.g.