Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Hello, stardiviner writes: > Can you remove it? Regenerate patches on my side is little kind of > trouble. Done. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Nicolas Goaziou writes: > Hello, > > stardiviner writes: > >> Aha, Thanks, Nicolas, I almost forget this patch. That's great! > > Speaking of which, there's an issue in > `org-babel-eshell-initiate-session'. > > First, it uses (get-buffer (current-buffer)), which is equivalent to >

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Hello, stardiviner writes: > Aha, Thanks, Nicolas, I almost forget this patch. That's great! Speaking of which, there's an issue in `org-babel-eshell-initiate-session'. First, it uses (get-buffer (current-buffer)), which is equivalent to (current-buffer). But, more importantly, it doesn't do

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Nicolas Goaziou writes: > Hello, > > stardiviner writes: > >> Subject: [PATCH] ob-eshell.el: Add Eshell support for Babel. > > Applied on "next" branch. Thank you. Aha, Thanks, Nicolas, I almost forget this patch. That's great! > > Regards, -- [ stardiviner ] don't need to convince with

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Hello, stardiviner writes: > Subject: [PATCH] ob-eshell.el: Add Eshell support for Babel. Applied on "next" branch. Thank you. Regards, -- Nicolas Goaziou0x80A93738

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, Nicolas. Now Org 9.1.12 is released. Maybe it's time to merge this ob-eshell PATCH? If still has some places need modified, please tell me. Thanks. - -- [ stardiviner ] don't need to convince with trends. Blog:

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Nicolas Goaziou writes: > I'm not convinced this is less work to edit, but I changed it anyway. It > makes it easier to follow alphabetical order. I also wrapped > identifiers within verbatim markup. > You're right, still not improved a lot. Anyway, thanks. And I

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Hello, stardiviner writes: > After some thinking, I think the following table sort might better, > because Org Table support insert a field below is easy when has new > entry need to add. No need to move a lot of fields. > > WDYT? I'm not convinced this is less work to

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Nicolas Goaziou writes: > stardiviner writes: > >> Hi, Nicolas, thank you always review my Org-mode patches. Yesterday, I >> ask Bastein about Worg ox-org question. He mentioned I should at least >>

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

stardiviner writes: > Hi, Nicolas, thank you always review my Org-mode patches. Yesterday, I > ask Bastein about Worg ox-org question. He mentioned I should at least > say "Hi" in message. I'm not good at English culture of something else. > But I just want to say, I'm glad

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Nicolas Goaziou writes: > Hello, > > stardiviner writes: > >> From 596da7b0384d64f3c1c22a49bc9bced8d0d8abf8 Mon Sep 17 00:00:00 2001 >> From: stardiviner >> Date: Sun, 22 Apr

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

Hello, stardiviner writes: > From 596da7b0384d64f3c1c22a49bc9bced8d0d8abf8 Mon Sep 17 00:00:00 2001 > From: stardiviner > Date: Sun, 22 Apr 2018 09:37:40 +0800 > Subject: [PATCH] ob-eshell.el: Add Eshell support for Babel. Thank you. This could go

Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

In this latest PATCH, contains fix of ob-shell :session initialize and execution. From 596da7b0384d64f3c1c22a49bc9bced8d0d8abf8 Mon Sep 17 00:00:00 2001 From: stardiviner Date: Sun, 22 Apr 2018 09:37:40 +0800 Subject: [PATCH] ob-eshell.el: Add Eshell support for Babel. *